linux-toradex.git/drivers/w1, branch v3.15.10

w1: do not unlock unheld list_mutex in __w1_remove_master_device()

2014-07-01T03:13:53+00:00

commit a0f104644ec27ce5bbb36e950eb426dba9a3ad44 upstream.

w1_process_callbacks() expects to be called with dev->list_mutex held,
but it is the fact only in w1_process(). __w1_remove_master_device()
calls w1_process_callbacks() after it releases list_mutex.

The patch fixes __w1_remove_master_device() to acquire list_mutex
for w1_process_callbacks().

Found by Linux Driver Verification project (linuxtesting.org).

Signed-off-by: Alexey Khoroshilov 
Acked-by: David Fries 
Acked-by: Evgeniy Polyakov 
Signed-off-by: Greg Kroah-Hartman

w1: avoid recursive device_add

2014-04-16T21:07:51+00:00

__w1_attach_slave_device calls device_add which calls w1_bus_notify
which calls the w1_bq27000 slave driver, which calls
platform_device_add and device_add and deadlocks on getting
&(&priv->bus_notifier)->rwsem as it is still held in the previous
device_add.  This avoids the problem by processing the family
add/remove outside of the slave device_add call.

Commit 47eba33a0997fc7362a introduced this deadlock and added
a KOBJ_ADD, as the add was already reported in device_register two add
events were being sent.  This change suppresses the device_register
add so that any slave device sysfs entries are setup before the add
goes out.

Belisko Marek reported this change fixed the deadlock he was seeing on
ARM device tree, while testing on my x86-64 system never saw the
deadlock.

Reported-by: Belisko Marek 
Signed-off-by: David Fries 
Signed-off-by: Greg Kroah-Hartman

w1: fix netlink refcnt leak on error path

2014-04-16T21:07:51+00:00

If the message type is W1_MASTER_CMD or W1_SLAVE_CMD, then a reference
is taken when searching for the slave or master device.  If there
isn't any following data m->len (mlen is a copy) is 0 and packing up
the message for later execution is skipped leaving nothing to
decrement the reference counts.

Way back when, m->len was checked before the search that increments the
reference count, but W1_LIST_MASTERS has no additional data, the check
was moved in 9be62e0b2fadaf5ff causing this bug.

This change reorders to put the check before the reference count is
incremented avoiding the problem.

Signed-off-by: David Fries 
Acked-by: Evgeniy Polyakov 
Signed-off-by: Greg Kroah-Hartman

w1: mxc_w1: Enable driver compilation with COMPILE_TEST

2014-02-28T23:27:09+00:00

This helps increasing build testing coverage.
To do this, __raw_{read,write}b() functions was be replaced with
simple {read,write}b() variants.

Signed-off-by: Alexander Shiyan 
Signed-off-by: Greg Kroah-Hartman

w1: mxc_w1: Driver cleanup

2014-02-28T23:27:09+00:00

- Remove old and currently wrong address of the FSF from license
  parts of the code.
- Remove unused #include and sort remaining headers alphabetically.
- Remove unised definitions.
- Add definitions for bit-fields.
- Add missing module owner field.

Signed-off-by: Alexander Shiyan 
Signed-off-by: Greg Kroah-Hartman

w1: mxc_w1: Fix mxc_w1_ds2_reset_bus() return value

2014-02-28T23:27:09+00:00

This patch fix mxc_w1_ds2_reset_bus() return value.
According to i.MX reference manual, "presence status" reflected
in the bit 6 of control register.

Signed-off-by: Alexander Shiyan 
Signed-off-by: Greg Kroah-Hartman

w1: Remove excess dependencies on W1 for masters and slaves

2014-02-28T23:27:09+00:00

Configuration for masters and slaves is included only if W1 symbol
enabled, so no reason to check it once more.

Signed-off-by: Alexander Shiyan 
Signed-off-by: Greg Kroah-Hartman

w1-gpio: handle of_get_gpio() returning -EPROBE_DEFER better

2014-02-15T20:08:38+00:00

of_get_gpio() might return -EPROBE_DEFER meaning that the driver
providing the gpio isn't ready yet. If that happens for the first gpio
the resulting kernel output without this patch is:

	w1-gpio somename: Failed to parse DT
	platform somename: Driver w1-gpio requests probe deferral

The first message is misleading and so is suppressed with this patch.

Further if determining the gpio to switch the external pullup yields
-EPROBE_DEFER this error should be passed back to the caller instead of
just continuing without pullup.

Signed-off-by: Uwe Kleine-König 
Signed-off-by: Greg Kroah-Hartman

w1: small type cleanup in sysfs

2014-02-15T19:51:05+00:00

On 64 bit systems, a large value for "long tmp" is truncated when
assigning to "int md->max_slave_count" so we still end up with a value
less than one despite the "tmp < 1" check.

This is more of a problem for static checkers than a real life issue,
but it's simple enough to fix.

Acked-by: David Fries 
Signed-off-by: Dan Carpenter 
Signed-off-by: Greg Kroah-Hartman

Revert ds1wm.c from "w1: hold bus_mutex in netlink and search"

2014-02-08T21:30:43+00:00

This reverts ds1wm.c from commit d3a8a9dbb903c73a7ec2deae4c9b7d74b6834f4c.
Of the three files changed ds1wm.c ds2490.c and w1_netlink.c, it turns out
ds1wm.c was locking bus_mutex, but inside the loop and I missed it.
Reverting ds1wm.c to the previous version.

Reported-by: Dan Carpenter 
Signed-off-by: David Fries 
Signed-off-by: Greg Kroah-Hartman