linux-toradex.git/drivers/watchdog/max63xx_wdt.c, branch v4.4.27

watchdog: max63xx: dynamically allocate device

2015-06-29T09:50:53+00:00

This patch removes the static watchdog device for a new max63xx_wdt data
structure, and constifies the max63xx_timeout data.

The new structure contains pointers to pin access routines, which
abstracts mmap-specific code. This will ease future accesses like GPIO.

Signed-off-by: Vivien Didelot 
Reviewed-by: Guenter Roeck 
Signed-off-by: Wim Van Sebroeck

watchdog: max63xx_wdt: Constify platform_device_id

2015-06-22T13:54:22+00:00

The platform_device_id is not modified by the driver and core uses it as
const.

Signed-off-by: Krzysztof Kozlowski 
Reviewed-by: Guenter Roeck 
Signed-off-by: Wim Van Sebroeck

watchdog: drop owner assignment from platform_drivers

2014-10-20T14:21:56+00:00

A platform_driver does not need to set an owner, it will be populated by the
driver core.

Signed-off-by: Wolfram Sang

watchdog: delete non-required instances of include

2014-03-31T11:22:45+00:00

None of these files are actually using any __init type directives
and hence don't need to include .  Most are just a
left over from __devinit and __cpuinit removal, or simply due to
code getting copied from one driver to the next.

Signed-off-by: Paul Gortmaker 
Reviewed-by: Guenter Roeck 
Signed-off-by: Wim Van Sebroeck 
Cc: linux-watchdog@vger.kernel.org

watchdog: Drop unnecessary include of miscdevice.h

2013-12-10T07:48:09+00:00

After commit 487722cf2 (watchdog: Get rid of MODULE_ALIAS_MISCDEV
statements) the affected drivers no longer need to include miscdevice.h.
Only exception is rt2880_wdt.c which never needed it.

Signed-off-by: Guenter Roeck 
Reviewed-by: Jean Delvare 
Signed-off-by: Wim Van Sebroeck

watchdog: Get rid of MODULE_ALIAS_MISCDEV statements

2013-11-17T18:38:13+00:00

I just can't find any value in MODULE_ALIAS_MISCDEV(WATCHDOG_MINOR)
and MODULE_ALIAS_MISCDEV(TEMP_MINOR) statements.

Either the device is enumerated and the driver already has a module
alias (e.g. PCI, USB etc.) that will get the right driver loaded
automatically.

Or the device is not enumerated and loading its driver will lead to
more or less intrusive hardware poking. Such hardware poking should be
limited to a bare minimum, so the user should really decide which
drivers should be tried and in what order. Trying them all in
arbitrary order can't do any good.

On top of that, loading that many drivers at once bloats the kernel
log. Also many drivers will stay loaded afterward, bloating the output
of "lsmod" and wasting memory. Some modules (cs5535_mfgpt which gets
loaded as a dependency) can't even be unloaded!

If defining char-major-10-130 is needed then it should happen in
user-space.

Signed-off-by: Jean Delvare 
Acked-by: Guenter Roeck 
Signed-off-by: Wim Van Sebroeck 
Cc: Stephen Warren 
Cc: Mike Frysinger 
Cc: Wan ZongShun 
Cc: Ben Dooks 
Cc: Kukjin Kim 
Cc: Zwane Mwaikambo 
Cc: Jim Cromie

watchdog: Convert to devm_ioremap_resource()

2013-01-25T20:21:48+00:00

Convert all uses of devm_request_and_ioremap() to the newly introduced
devm_ioremap_resource() which provides more consistent error handling.

devm_ioremap_resource() provides its own error messages so all explicit
error messages can be removed from the failure code paths.

Signed-off-by: Thierry Reding 
Cc: Wim Van Sebroeck 
Signed-off-by: Greg Kroah-Hartman

watchdog: remove use of __devexit

2012-11-28T20:00:24+00:00

CONFIG_HOTPLUG is going away as an option so __devexit is no
longer needed.

Signed-off-by: Bill Pemberton 
Cc: Wim Van Sebroeck 
Cc: Wan ZongShun 
Cc: Ben Dooks 
Cc: Kukjin Kim 
Acked-by: Mark Brown 
Signed-off-by: Greg Kroah-Hartman

watchdog: remove use of __devinit

2012-11-28T20:00:24+00:00

CONFIG_HOTPLUG is going away as an option so __devinit is no longer
needed.

Signed-off-by: Bill Pemberton 
Cc: Wim Van Sebroeck 
Cc: Wan ZongShun 
Cc: Ben Dooks 
Cc: Kukjin Kim 
Acked-by: Mark Brown 
Signed-off-by: Greg Kroah-Hartman

watchdog: remove use of __devexit_p

2012-11-28T20:00:24+00:00

CONFIG_HOTPLUG is going away as an option so __devexit_p is no longer
needed.

Signed-off-by: Bill Pemberton 
Cc: Wim Van Sebroeck 
Cc: Wan ZongShun 
Cc: Ben Dooks 
Cc: Kukjin Kim 
Acked-by: Mark Brown 
Signed-off-by: Greg Kroah-Hartman