<feed xmlns='http://www.w3.org/2005/Atom'>
<title>linux-toradex.git/drivers/watchdog/sbc_epx_c3.c, branch v3.19.3</title>
<subtitle>Linux kernel for Apalis and Colibri modules</subtitle>
<link rel='alternate' type='text/html' href='https://git.toradex.cn/cgit/linux-toradex.git/'/>
<entry>
<title>watchdog: Get rid of MODULE_ALIAS_MISCDEV statements</title>
<updated>2013-11-17T18:38:13+00:00</updated>
<author>
<name>Jean Delvare</name>
<email>jdelvare@suse.de</email>
</author>
<published>2013-10-21T15:38:49+00:00</published>
<link rel='alternate' type='text/html' href='https://git.toradex.cn/cgit/linux-toradex.git/commit/?id=487722cf2d66126338217896642bd5eec832c34b'/>
<id>487722cf2d66126338217896642bd5eec832c34b</id>
<content type='text'>
I just can't find any value in MODULE_ALIAS_MISCDEV(WATCHDOG_MINOR)
and MODULE_ALIAS_MISCDEV(TEMP_MINOR) statements.

Either the device is enumerated and the driver already has a module
alias (e.g. PCI, USB etc.) that will get the right driver loaded
automatically.

Or the device is not enumerated and loading its driver will lead to
more or less intrusive hardware poking. Such hardware poking should be
limited to a bare minimum, so the user should really decide which
drivers should be tried and in what order. Trying them all in
arbitrary order can't do any good.

On top of that, loading that many drivers at once bloats the kernel
log. Also many drivers will stay loaded afterward, bloating the output
of "lsmod" and wasting memory. Some modules (cs5535_mfgpt which gets
loaded as a dependency) can't even be unloaded!

If defining char-major-10-130 is needed then it should happen in
user-space.

Signed-off-by: Jean Delvare &lt;jdelvare@suse.de&gt;
Acked-by: Guenter Roeck &lt;linux@roeck-us.net&gt;
Signed-off-by: Wim Van Sebroeck &lt;wim@iguana.be&gt;
Cc: Stephen Warren &lt;swarren@wwwdotorg.org&gt;
Cc: Mike Frysinger &lt;vapier.adi@gmail.com&gt;
Cc: Wan ZongShun &lt;mcuos.com@gmail.com&gt;
Cc: Ben Dooks &lt;ben-linux@fluff.org&gt;
Cc: Kukjin Kim &lt;kgene.kim@samsung.com&gt;
Cc: Zwane Mwaikambo &lt;zwane@arm.linux.org.uk&gt;
Cc: Jim Cromie &lt;jim.cromie@gmail.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
I just can't find any value in MODULE_ALIAS_MISCDEV(WATCHDOG_MINOR)
and MODULE_ALIAS_MISCDEV(TEMP_MINOR) statements.

Either the device is enumerated and the driver already has a module
alias (e.g. PCI, USB etc.) that will get the right driver loaded
automatically.

Or the device is not enumerated and loading its driver will lead to
more or less intrusive hardware poking. Such hardware poking should be
limited to a bare minimum, so the user should really decide which
drivers should be tried and in what order. Trying them all in
arbitrary order can't do any good.

On top of that, loading that many drivers at once bloats the kernel
log. Also many drivers will stay loaded afterward, bloating the output
of "lsmod" and wasting memory. Some modules (cs5535_mfgpt which gets
loaded as a dependency) can't even be unloaded!

If defining char-major-10-130 is needed then it should happen in
user-space.

Signed-off-by: Jean Delvare &lt;jdelvare@suse.de&gt;
Acked-by: Guenter Roeck &lt;linux@roeck-us.net&gt;
Signed-off-by: Wim Van Sebroeck &lt;wim@iguana.be&gt;
Cc: Stephen Warren &lt;swarren@wwwdotorg.org&gt;
Cc: Mike Frysinger &lt;vapier.adi@gmail.com&gt;
Cc: Wan ZongShun &lt;mcuos.com@gmail.com&gt;
Cc: Ben Dooks &lt;ben-linux@fluff.org&gt;
Cc: Kukjin Kim &lt;kgene.kim@samsung.com&gt;
Cc: Zwane Mwaikambo &lt;zwane@arm.linux.org.uk&gt;
Cc: Jim Cromie &lt;jim.cromie@gmail.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>watchdog: nowayout is bool</title>
<updated>2012-03-27T18:06:02+00:00</updated>
<author>
<name>Wim Van Sebroeck</name>
<email>wim@iguana.be</email>
</author>
<published>2012-03-05T15:51:11+00:00</published>
<link rel='alternate' type='text/html' href='https://git.toradex.cn/cgit/linux-toradex.git/commit/?id=86a1e1896c2710402e29a875d8d830244274244d'/>
<id>86a1e1896c2710402e29a875d8d830244274244d</id>
<content type='text'>
nowayout is actually a boolean value.
So make it bool for all watchdog device drivers.

Signed-off-by: Wim Van Sebroeck &lt;wim@iguana.be&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
nowayout is actually a boolean value.
So make it bool for all watchdog device drivers.

Signed-off-by: Wim Van Sebroeck &lt;wim@iguana.be&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>watchdog: Use pr_&lt;fmt&gt; and pr_&lt;level&gt;</title>
<updated>2012-03-27T17:59:26+00:00</updated>
<author>
<name>Joe Perches</name>
<email>joe@perches.com</email>
</author>
<published>2012-02-15T23:06:19+00:00</published>
<link rel='alternate' type='text/html' href='https://git.toradex.cn/cgit/linux-toradex.git/commit/?id=27c766aaacb265d625dc634bf7903f7f9fd0c697'/>
<id>27c766aaacb265d625dc634bf7903f7f9fd0c697</id>
<content type='text'>
Use the current logging styles.

Make sure all output has a prefix.
Add missing newlines.
Remove now unnecessary PFX, NAME, and miscellaneous other #defines.
Coalesce formats.

Signed-off-by: Joe Perches &lt;joe@perches.com&gt;
Signed-off-by: Wim Van Sebroeck &lt;wim@iguana.be&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Use the current logging styles.

Make sure all output has a prefix.
Add missing newlines.
Remove now unnecessary PFX, NAME, and miscellaneous other #defines.
Coalesce formats.

Signed-off-by: Joe Perches &lt;joe@perches.com&gt;
Signed-off-by: Wim Van Sebroeck &lt;wim@iguana.be&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>watchdog: Initconst section fixes for watchdog</title>
<updated>2011-09-20T12:32:00+00:00</updated>
<author>
<name>Andi Kleen</name>
<email>ak@linux.intel.com</email>
</author>
<published>2011-09-15T20:09:51+00:00</published>
<link rel='alternate' type='text/html' href='https://git.toradex.cn/cgit/linux-toradex.git/commit/?id=4e8858d5130459c4af80b990c2280115a1d49877'/>
<id>4e8858d5130459c4af80b990c2280115a1d49877</id>
<content type='text'>
Signed-off-by: Andi Kleen &lt;ak@linux.intel.com&gt;
Signed-off-by: Wim Van Sebroeck &lt;wim@iguana.be&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Signed-off-by: Andi Kleen &lt;ak@linux.intel.com&gt;
Signed-off-by: Wim Van Sebroeck &lt;wim@iguana.be&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>Remove one to many n's in a word</title>
<updated>2011-03-01T14:47:58+00:00</updated>
<author>
<name>Justin P. Mattock</name>
<email>justinmattock@gmail.com</email>
</author>
<published>2011-03-01T14:06:02+00:00</published>
<link rel='alternate' type='text/html' href='https://git.toradex.cn/cgit/linux-toradex.git/commit/?id=ae0e47f02aaedbfdd5e4bec73f79b714d758223d'/>
<id>ae0e47f02aaedbfdd5e4bec73f79b714d758223d</id>
<content type='text'>
Signed-off-by: Justin P. Mattock &lt;justinmattock@gmail.com&gt;
Signed-off-by: Jiri Kosina &lt;jkosina@suse.cz&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Signed-off-by: Justin P. Mattock &lt;justinmattock@gmail.com&gt;
Signed-off-by: Jiri Kosina &lt;jkosina@suse.cz&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>[WATCHDOG] Correct WDIOF_MAGICCLOSE flag</title>
<updated>2009-06-18T07:30:57+00:00</updated>
<author>
<name>Wim Van Sebroeck</name>
<email>wim@iguana.be</email>
</author>
<published>2009-05-11T18:33:00+00:00</published>
<link rel='alternate' type='text/html' href='https://git.toradex.cn/cgit/linux-toradex.git/commit/?id=e73a780272a46e897bd94a4870fd6b6a8655d2d4'/>
<id>e73a780272a46e897bd94a4870fd6b6a8655d2d4</id>
<content type='text'>
Make sure that when the WDIOF_MAGICCLOSE flag is set we also
support the magic-close feature...

Signed-off-by: Wim Van Sebroeck &lt;wim@iguana.be&gt;

</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Make sure that when the WDIOF_MAGICCLOSE flag is set we also
support the magic-close feature...

Signed-off-by: Wim Van Sebroeck &lt;wim@iguana.be&gt;

</pre>
</div>
</content>
</entry>
<entry>
<title>[WATCHDOG] Some more general cleanup</title>
<updated>2009-06-18T07:30:30+00:00</updated>
<author>
<name>Wim Van Sebroeck</name>
<email>wim@iguana.be</email>
</author>
<published>2009-04-14T20:20:07+00:00</published>
<link rel='alternate' type='text/html' href='https://git.toradex.cn/cgit/linux-toradex.git/commit/?id=a77dba7e444a6618cbb666d1b42b79842b9c0171'/>
<id>a77dba7e444a6618cbb666d1b42b79842b9c0171</id>
<content type='text'>
Clean-up the watchdog drivers so that checkpatch.pl get's happy...

Signed-off-by: Wim Van Sebroeck &lt;wim@iguana.be&gt;

</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Clean-up the watchdog drivers so that checkpatch.pl get's happy...

Signed-off-by: Wim Van Sebroeck &lt;wim@iguana.be&gt;

</pre>
</div>
</content>
</entry>
<entry>
<title>[WATCHDOG] More coding-style and trivial clean-up</title>
<updated>2009-03-25T09:07:04+00:00</updated>
<author>
<name>Wim Van Sebroeck</name>
<email>wim@iguana.be</email>
</author>
<published>2009-03-18T08:35:09+00:00</published>
<link rel='alternate' type='text/html' href='https://git.toradex.cn/cgit/linux-toradex.git/commit/?id=143a2e54bf53216674eada16e8953f48b159e08a'/>
<id>143a2e54bf53216674eada16e8953f48b159e08a</id>
<content type='text'>
Some more cleaning-up of the watchdog drivers.

Signed-off-by: Wim Van Sebroeck &lt;wim@iguana.be&gt;

</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Some more cleaning-up of the watchdog drivers.

Signed-off-by: Wim Van Sebroeck &lt;wim@iguana.be&gt;

</pre>
</div>
</content>
</entry>
<entry>
<title>[PATCH] Switch all my contributions stuff to a single common address</title>
<updated>2008-10-28T19:16:11+00:00</updated>
<author>
<name>Alan Cox</name>
<email>alan@lxorguk.ukuu.org.uk</email>
</author>
<published>2008-10-27T15:17:56+00:00</published>
<link rel='alternate' type='text/html' href='https://git.toradex.cn/cgit/linux-toradex.git/commit/?id=29fa0586de4fe518f122a915b8c6e92d12e8ca7f'/>
<id>29fa0586de4fe518f122a915b8c6e92d12e8ca7f</id>
<content type='text'>
Signed-off-by: Alan Cox &lt;alan@redhat.com&gt;
Signed-off-by: Wim Van Sebroeck &lt;wim@iguana.be&gt;

</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Signed-off-by: Alan Cox &lt;alan@redhat.com&gt;
Signed-off-by: Wim Van Sebroeck &lt;wim@iguana.be&gt;

</pre>
</div>
</content>
</entry>
<entry>
<title>[WATCHDOG] Coding style - Indentation - part 2</title>
<updated>2008-08-06T13:21:09+00:00</updated>
<author>
<name>Wim Van Sebroeck</name>
<email>wim@iguana.be</email>
</author>
<published>2008-07-18T11:41:17+00:00</published>
<link rel='alternate' type='text/html' href='https://git.toradex.cn/cgit/linux-toradex.git/commit/?id=0c06090c9472db0525cb6fe229c3bea33bbbbb3c'/>
<id>0c06090c9472db0525cb6fe229c3bea33bbbbb3c</id>
<content type='text'>
This brings the watchdog drivers into line with coding style.
This patch takes cares of the indentation as described in chapter 1.
Main changes:
* Re-structure the ioctl switch call for all drivers as follows:
	switch (cmd) {
	case WDIOC_GETSUPPORT:
	case WDIOC_GETSTATUS:
	case WDIOC_GETBOOTSTATUS:
	case WDIOC_GETTEMP:
	case WDIOC_SETOPTIONS:
	case WDIOC_KEEPALIVE:
	case WDIOC_SETTIMEOUT:
	case WDIOC_GETTIMEOUT:
	case WDIOC_GETTIMELEFT:
	default:
	}

This to make the migration from the drivers to the uniform watchdog
device driver easier in the future.

Signed-off-by: Wim Van Sebroeck &lt;wim@iguana.be&gt;

</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This brings the watchdog drivers into line with coding style.
This patch takes cares of the indentation as described in chapter 1.
Main changes:
* Re-structure the ioctl switch call for all drivers as follows:
	switch (cmd) {
	case WDIOC_GETSUPPORT:
	case WDIOC_GETSTATUS:
	case WDIOC_GETBOOTSTATUS:
	case WDIOC_GETTEMP:
	case WDIOC_SETOPTIONS:
	case WDIOC_KEEPALIVE:
	case WDIOC_SETTIMEOUT:
	case WDIOC_GETTIMEOUT:
	case WDIOC_GETTIMELEFT:
	default:
	}

This to make the migration from the drivers to the uniform watchdog
device driver easier in the future.

Signed-off-by: Wim Van Sebroeck &lt;wim@iguana.be&gt;

</pre>
</div>
</content>
</entry>
</feed>
