linux-toradex.git/drivers/watchdog/softdog.c, branch v4.9.121

watchdog: softdog: implement pretimeout support

2016-10-08T08:27:27+00:00

Give devices which do not have hardware support for pretimeout at least a
software version of it.

Signed-off-by: Wolfram Sang 
Signed-off-by: Vladimir Zapolskiy 
Reviewed-by: Guenter Roeck 
Signed-off-by: Guenter Roeck 
Signed-off-by: Wim Van Sebroeck

watchdog: constify watchdog_ops structures

2016-09-24T06:50:10+00:00

Check for watchdog_ops structures that are only stored in the ops field of
a watchdog_device structure.  This field is declared const, so watchdog_ops
structures that have this property can be declared as const also.

The semantic patch that makes this change is as follows:
(http://coccinelle.lip6.fr/)

// 
@r disable optional_qualifier@
identifier i;
position p;
@@
static struct watchdog_ops i@p = { ... };

@ok@
identifier r.i;
struct watchdog_device e;
position p;
@@
e.ops = &i@p;

@bad@
position p != {r.p,ok.p};
identifier r.i;
struct watchdog_ops e;
@@
e@i@p

@depends on !bad disable optional_qualifier@
identifier r.i;
@@
static
+const
 struct watchdog_ops i = { ... };
// 

Signed-off-by: Julia Lawall 
Reviewed-by: Guenter Roeck 
Signed-off-by: Guenter Roeck 
Signed-off-by: Wim Van Sebroeck

watchdog: softdog: improve coding style

2016-07-17T18:54:52+00:00

Signed-off-by: Wolfram Sang 
Reviewed-by: Guenter Roeck 
Signed-off-by: Guenter Roeck 
Signed-off-by: Wim Van Sebroeck

watchdog: softdog: drop superfluous set_timeout callback

2016-07-17T18:54:49+00:00

If we leave set_timeout empty, the core will do exactly what is
implemented here anyway.

Signed-off-by: Wolfram Sang 
Reviewed-by: Guenter Roeck 
Signed-off-by: Guenter Roeck 
Signed-off-by: Wim Van Sebroeck

watchdog: softdog: sort includes to avoid duplicates

2016-07-17T18:54:45+00:00

Signed-off-by: Wolfram Sang 
Reviewed-by: Guenter Roeck 
Signed-off-by: Guenter Roeck 
Signed-off-by: Wim Van Sebroeck

watchdog: softdog: remove forward declaration

2016-07-17T18:54:42+00:00

Signed-off-by: Wolfram Sang 
Reviewed-by: Guenter Roeck 
Signed-off-by: Guenter Roeck 
Signed-off-by: Wim Van Sebroeck

watchdog: softdog: consistently use softdog_ prefix

2016-07-17T18:54:38+00:00

And move module_init/exit to the proper place while here.

Signed-off-by: Wolfram Sang 
Reviewed-by: Guenter Roeck 
Signed-off-by: Guenter Roeck 
Signed-off-by: Wim Van Sebroeck

watchdog: softdog: use watchdog core to init timeout value

2016-07-17T18:54:34+00:00

Error string and comment say we fall back to a default, but in reality
we bailed out. Refactor the code to use the core helper which then
matches the described behaviour. While updating the init message anyhow,
shorten it while we are here; no need for versioning there as well and
the name is already given via pr_fmt.

Signed-off-by: Wolfram Sang 
Reviewed-by: Guenter Roeck 
Signed-off-by: Guenter Roeck 
Signed-off-by: Wim Van Sebroeck

watchdog: softdog: remove obsolete comments

2016-07-17T18:54:31+00:00

The history is obsolete, especially since we switched to watchdog
framework. The section markers also don't make sense anymore given
the small size of the driver.

Signed-off-by: Wolfram Sang 
Reviewed-by: Guenter Roeck 
Signed-off-by: Guenter Roeck 
Signed-off-by: Wim Van Sebroeck

watchdog: refuse to unload softdog module when its timer is running

2015-12-27T20:02:21+00:00

the softdog has static variables which are accessed if its timer is
still running after the driver is unloaded. and lead to crash:

   $modprobe softdog
   $echo 1 >/dev/watchdog
   $modprobe -r softdog

   CPU 20 Unable to handle kernel paging request at virtual address
   Oops[#1]:
   CPU: 20 PID: 0 Comm: swapper/20 Not tainted 4.1.13-WR8.0.0.0_standard
   ...
   Modules linked in: [last unloaded: softdog]
    ....
   Call Trace:
   [] cascade+0x34/0xb0
   [] run_timer_softirq+0x30c/0x368
   [] __do_softirq+0x1ec/0x418
   [] irq_exit+0x90/0x98
   [] plat_irq_dispatch+0xa4/0x140
   [] ret_from_irq+0x0/0x4
   [] __r4k_wait+0x20/0x40
   [] cpu_startup_entry+0x2a0/0x368
   [] start_secondary+0x444/0x4d8

add the module ref when timer is running to avoid to unload the softdog
module

Signed-off-by: Li RongQing 
Signed-off-by: Guenter Roeck 
Signed-off-by: Wim Van Sebroeck