linux-toradex.git/drivers/watchdog, branch v2.6.27.13

ib700wdt.c - fix buffer_underflow bug

2008-12-13T23:29:36+00:00

commit 7c2500f17d65092d93345f3996cf82ebca17e9ff upstream.

This fixes Bug 11399:
if ibwdt_set_heartbeat(int t) is called with value 30 then
the check "if ((t < 0) || (t > 30))" in ibwdt_set_heartbeat
is not going to fail because t == 30, but in the loop, the
check wd_times[i] > t is never going to be true because
none of the wd_times are greater than the value of t (i.e. 30).
So we are exiting the loop with i == -1 and therefore setting
wd_margin to -1 which is wrong.

Reported-by: Zvonimir Rakamaric 
Signed-off-by: Wim Van Sebroeck 
Signed-off-by: Greg Kroah-Hartman

WATCHDOG: hpwdt: Fix kdump when using hpwdt

2008-12-05T18:55:23+00:00

commit 290172e79036fc25a22aaf3da4835ee634886183 upstream.

When the "hpwdt" module is loaded (even if the /dev/watchdog device is not
opened), then kdump does not work. The panic kernel either does not start at
all or crash in various places.

The problem is that hpwdt_pretimeout is registered with register_die_notifier()
with the highest possible priority. Because it returns NOTIFY_STOP, the
crash_nmi_callback which is also registered with register_die_notifier()
is never executed. This causes the shutdown of other CPUs to fail.

Reverting the order is no option: The crash_nmi_callback executes HLT
and so never returns normally. Because of that, it must be executed as
last notifier, which currently is done.

So, that patch returns NOTIFY_OK to keep the crash_nmi_callback executed.

Signed-off-by: Bernhard Walle 
Signed-off-by: Wim Van Sebroeck 
Signed-off-by: Thomas Mingarelli 
Cc: Vivek Goyal 
Signed-off-by: Greg Kroah-Hartman

WATCHDOG: hpwdt: set the mapped BIOS address space as executable

2008-12-05T18:55:23+00:00

commit 060264133b946786b4b28a1ba79e6725eaf258f3 upstream.

The address provided by the SMBIOS/DMI CRU information is mapped via
ioremap() in the virtual address space.  However, since the address is
executed (i.e.  call'd), we need to set that pages as executable.

Without that, I get following oops on a HP ProLiant DL385 G2
machine with BIOS from 05/29/2008 when I trigger crashdump:

    BUG: unable to handle kernel paging request at ffffc20011090c00
    IP: [] 0xffffc20011090c00
    PGD 12f813067 PUD 7fe6a067 PMD 7effe067 PTE 80000000fffd3173
    Oops: 0011 [1] SMP
    last sysfs file: /sys/devices/system/cpu/cpu3/cache/index2/shared_cpu_map
    CPU 1
    Modules linked in: autofs4 ipv6 af_packet cpufreq_conservative cpufreq_userspace
     cpufreq_powersave powernow_k8 fuse loop dm_mod rtc_cmos ipmi_si sg rtc_core i2c
    _piix4 ipmi_msghandler bnx2 sr_mod container button i2c_core hpilo joydev pcspkr
     rtc_lib shpchp hpwdt cdrom pci_hotplug usbhid hid ff_memless ohci_hcd ehci_hcd
    uhci_hcd usbcore edd ext3 mbcache jbd fan ide_pci_generic serverworks ide_core p
    ata_serverworks pata_acpi cciss ata_generic libata scsi_mod dock thermal process
    or thermal_sys hwmon
    Supported: Yes
    Pid: 0, comm: swapper Not tainted 2.6.27.5-HEAD_20081111100657-default #1
    RIP: 0010:[]  [] 0xffffc20011090c00
    RSP: 0018:ffff88012f6f9e68  EFLAGS: 00010046
    RAX: 0000000000000d02 RBX: 0000000000000000 RCX: 0000000000000000
    RDX: 0000000000000000 RSI: 0000000000000000 RDI: 0000000000000000
    RBP: ffff88012f6f9e98 R08: 666666666666660a R09: ffffffffa1006fc0
    R10: 0000000000000000 R11: ffff88012f6f3ea8 R12: ffffc20011090c00
    R13: ffff88012f6f9ee8 R14: 000000000000000e R15: 0000000000000000
    FS:  00007ff70b29a6f0(0000) GS:ffff88012f6512c0(0000) knlGS:0000000000000000
    CS:  0010 DS: 0018 ES: 0018 CR0: 000000008005003b
    CR2: ffffc20011090c00 CR3: 0000000000201000 CR4: 00000000000006e0
    DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
    DR3: 0000000000000000 DR6: 00000000ffff0ff0 DR7: 0000000000000400
    Process swapper (pid: 0, threadinfo ffff88012f6f2000, task ffff88007fa8a1c0)
    Stack:  ffffffffa0f8502b 0000000000000002 ffffffff80738d50 0000000000000000
     0000000000000046 0000000000000046 00000000fffffffe ffffffffa0f852ec
     0000000000000000 ffffffff804ad9a6 0000000000000000 0000000000000000
    Call Trace:
    Inexact backtrace:

       [] ? asminline_call+0x2b/0x55 [hpwdt]
     [] hpwdt_pretimeout+0x3c/0xa0 [hpwdt]
     [] ? notifier_call_chain+0x29/0x4c
     [] ? notify_die+0x2d/0x32
     [] ? default_do_nmi+0x53/0x1d9
     [] ? do_nmi+0x2e/0x43
     [] ? nmi+0xa2/0xd0
     [] ? native_safe_halt+0x2/0x3
     <>  [] ? default_idle+0x38/0x54
     [] ? c1e_idle+0x118/0x11c
     [] ? cpu_idle+0xa9/0xf1

    Code: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff <55> 50 e8 00 00 00 00 58 48 2d 07 10 40 00 48 8b e8 58 e9 68 02
    RIP  [] 0xffffc20011090c00
     RSP 
    CR2: ffffc20011090c00
    Kernel panic - not syncing: Fatal exception

Signed-off-by: Bernhard Walle 
Signed-off-by: Wim Van Sebroeck 
Cc: Ingo Molnar 
Acked-by: "H. Peter Anvin" 
Signed-off-by: Thomas Mingarelli 
Cc: Alan Cox 
Signed-off-by: Andrew Morton 
Signed-off-by: Greg Kroah-Hartman

[WATCHDOG] unlocked_ioctl changes

2008-09-23T08:12:30+00:00

Fix some drivers so that they use the unlocked_ioctl call.

Signed-off-by: Wim Van Sebroeck

[WATCHDOG] wdt285: fix sparse warnings

2008-09-23T08:06:57+00:00

The wdt285.c watchdog driver is producing a number of
sparse errors due to missing __user attributes to calls
to put_user and copy_to_user, as well as in the prototype
of watchdog_write.

wdt285.c:144:21: warning: incorrect type in argument 1 (different address spaces)
wdt285.c:144:21:    expected void [noderef] *to
wdt285.c:144:21:    got void *
wdt285.c:150:9: warning: incorrect type in initializer (different address spaces)
wdt285.c:150:9:    expected int const [noderef] *register __p
wdt285.c:150:9:    got int *
wdt285.c:159:9: warning: incorrect type in initializer (different address spaces)
wdt285.c:159:9:    expected int const [noderef] *register __p
wdt285.c:159:9:    got int *
wdt285.c:174:9: warning: incorrect type in initializer (different address spaces)
wdt285.c:174:9:    expected int const [noderef] *register __p
wdt285.c:174:9:    got int *
wdt285.c:183:12: warning: incorrect type in initializer (incompatible argument 2 (different address spaces))
wdt285.c:183:12:    expected int ( *write )( ... )
wdt285.c:183:12:    got int ( static [toplevel] * )( ... )

Signed-off-by: Ben Dooks 
Signed-off-by: Wim Van Sebroeck 
Signed-off-by: Andrew Morton

[WATCHDOG] ibmasr: remove unnecessary spin_unlock()

2008-09-23T08:05:32+00:00

__asr_toggle() is always called with asr_lock held.
But there is unnecessary spin_unlock() call in __asr_toggle().

Signed-off-by: Akinobu Mita 
Signed-off-by: Wim Van Sebroeck 
Acked-by: Andrey Panin 
Signed-off-by: Andrew Morton

[WATCHDOG] removed unused #include

2008-08-26T20:32:02+00:00

The drivers below do not use LINUX_VERSION_CODE nor KERNEL_VERSION.
  drivers/watchdog/pc87413_wdt.c

This patch removes the said #include .

Signed-off-by: Huang Weiyi 
Signed-off-by: Wim Van Sebroeck

[WATCHDOG] at91rm9200_wdt.c: fix misleading indentation

2008-08-26T20:20:55+00:00

Signed-off-by: Ilpo Jarvinen 
Signed-off-by: Wim Van Sebroeck

[WATCHDOG] mpc8xxx_wdt: fix modular build

2008-08-26T20:20:44+00:00

Fix the following build error when mpc8xxx_wdt is selected to build as a
module:

drivers/watchdog/mpc8xxx_wdt.c:304: error: redefinition of '__inittest'
drivers/watchdog/mpc8xxx_wdt.c:298: error: previous definition of '__inittest' was here
drivers/watchdog/mpc8xxx_wdt.c:304: error: redefinition of 'init_module'
drivers/watchdog/mpc8xxx_wdt.c:298: error: previous definition of 'init_module' was here

Reported-by: Dave Jones 
Signed-off-by: Anton Vorontsov 
Signed-off-by: Wim Van Sebroeck 
Cc: Adrian Bunk 
Signed-off-by: Andrew Morton

[WATCHDOG] hpwdt.c kdebug support

2008-08-26T20:20:32+00:00

add kdebug support for the hpwdt.c driver.

Signed-off-by: Thomas Mingarelli 
Signed-off-by: Wim Van Sebroeck