linux-toradex.git/drivers/xen/xen-pciback, branch v3.2.56

xen/pciback: Don't disable a PCI device that is already disabled.

2013-03-20T15:03:29+00:00

commit bdc5c1812cea6efe1aaefb3131fcba28cd0b2b68 upstream.

While shuting down a HVM guest with pci devices passed through we
get this:

pciback 0000:04:00.0: restoring config space at offset 0x4 (was 0x100000, writing 0x100002)
------------[ cut here ]------------
WARNING: at drivers/pci/pci.c:1397 pci_disable_device+0x88/0xa0()
Hardware name: MS-7640
Device pciback
disabling already-disabled device
Modules linked in:
Pid: 53, comm: xenwatch Not tainted 3.9.0-rc1-20130304a+ #1
Call Trace:
 [] warn_slowpath_common+0x7a/0xc0
 [] warn_slowpath_fmt+0x41/0x50
 [] pci_disable_device+0x88/0xa0
 [] xen_pcibk_reset_device+0x37/0xd0
 [] ? pcistub_put_pci_dev+0x6f/0x120
 [] pcistub_put_pci_dev+0x8d/0x120
 [] __xen_pcibk_release_devices+0x59/0xa0

This fixes the bug.

Reported-and-Tested-by: Sander Eikelenboom 
Signed-off-by: Konrad Rzeszutek Wilk 
Signed-off-by: Ben Hutchings

xen-pciback: rate limit error messages from xen_pcibk_enable_msi{,x}()

2013-03-06T03:24:19+00:00

commit 51ac8893a7a51b196501164e645583bf78138699 upstream.

... as being guest triggerable (e.g. by invoking
XEN_PCI_OP_enable_msi{,x} on a device not being MSI/MSI-X capable).

This is CVE-2013-0231 / XSA-43.

Also make the two messages uniform in both their wording and severity.

Signed-off-by: Jan Beulich 
Acked-by: Ian Campbell 
Reviewed-by: Konrad Rzeszutek Wilk 
[bwh: Backported to 3.2: add #include , needed by
 printk_ratelimited()]
Signed-off-by: Ben Hutchings

xen: Add module.h to modular drivers/xen users.

2011-10-31T23:32:11+00:00

Previously these drivers just got module.h implicitly, but we
are cleaning that up and it will be no longer.  Call out the
real users of it.

Signed-off-by: Paul Gortmaker

Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next

2011-10-25T11:25:22+00:00

* git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next: (1745 commits)
  dp83640: free packet queues on remove
  dp83640: use proper function to free transmit time stamping packets
  ipv6: Do not use routes from locally generated RAs
  |PATCH net-next] tg3: add tx_dropped counter
  be2net: don't create multiple RX/TX rings in multi channel mode
  be2net: don't create multiple TXQs in BE2
  be2net: refactor VF setup/teardown code into be_vf_setup/clear()
  be2net: add vlan/rx-mode/flow-control config to be_setup()
  net_sched: cls_flow: use skb_header_pointer()
  ipv4: avoid useless call of the function check_peer_pmtu
  TCP: remove TCP_DEBUG
  net: Fix driver name for mdio-gpio.c
  ipv4: tcp: fix TOS value in ACK messages sent from TIME_WAIT
  rtnetlink: Add missing manual netlink notification in dev_change_net_namespaces
  ipv4: fix ipsec forward performance regression
  jme: fix irq storm after suspend/resume
  route: fix ICMP redirect validation
  net: hold sock reference while processing tx timestamps
  tcp: md5: add more const attributes
  Add ethtool -g support to virtio_net
  ...

Fix up conflicts in:
 - drivers/net/Kconfig:
	The split-up generated a trivial conflict with removal of a
	stale reference to Documentation/networking/net-modules.txt.
	Remove it from the new location instead.
 - fs/sysfs/dir.c:
	Fairly nasty conflicts with the sysfs rb-tree usage, conflicting
	with Eric Biederman's changes for tagged directories.

xen/pciback: Check if the device is found instead of blindly assuming so.

2011-10-19T21:01:10+00:00

Just in case it is not found, don't try to dereference it.

[v1: Added WARN_ON, suggested by Jan Beulich ]
Signed-off-by: Konrad Rzeszutek Wilk

xen/pciback: Do not dereference psdev during printk when it is NULL.

2011-10-19T20:58:17+00:00

.. instead use BUG_ON() as all the callers of the kill_domain_by_device
check for psdev.

Suggested-by: Jan Beulich 
Signed-off-by: Konrad Rzeszutek Wilk

xen/pciback: double lock typo

2011-09-29T14:50:26+00:00

We called mutex_lock() twice instead of unlocking.

Signed-off-by: Dan Carpenter 
Signed-off-by: Konrad Rzeszutek Wilk

xen/pciback: Add flag indicating device has been assigned by Xen

2011-09-27T04:48:34+00:00

Device drivers that create and destroy SR-IOV virtual functions via
calls to pci_enable_sriov() and pci_disable_sriov can cause catastrophic
failures if they attempt to destroy VFs while they are assigned to
guest virtual machines.  By adding a flag for use by the Xen PCI back
to indicate that a device is assigned a device driver can check that
flag and avoid destroying VFs while they are assigned and avoid system
failures.

Signed-off-by: Konrad Rzeszutek Wilk 
Signed-off-by: David S. Miller

xen/pciback: use mutex rather than spinlock in vpci backend

2011-09-21T22:18:18+00:00

Similar to the "xen/pciback: use mutex rather than spinlock in passthrough backend"
this patch converts the vpci backend to use a mutex instead of
a spinlock. Note that the code taking the lock won't ever get called
from non-sleepable context

Signed-off-by: Konrad Rzeszutek Wilk

xen/pciback: Use mutexes when working with Xenbus state transitions.

2011-09-21T22:18:16+00:00

The caller that orchestrates the state changes is xenwatch_thread
and it takes a mutex. In our processing of Xenbus states we can take
the luxery of going to sleep on a mutex, so lets do that and
also fix this bug:

BUG: sleeping function called from invalid context at /linux/kernel/mutex.c:271
in_atomic(): 1, irqs_disabled(): 0, pid: 32, name: xenwatch
2 locks held by xenwatch/32:
 #0:  (xenwatch_mutex){......}, at: [] xenwatch_thread+0x4b/0x180
 #1:  (&(&pdev->dev_lock)->rlock){......}, at: [] xen_pcibk_disconnect+0x1b/0x80
Pid: 32, comm: xenwatch Not tainted 3.1.0-rc6-00015-g3ce340d #2
Call Trace:
 [] __might_sleep+0x102/0x130
 [] mutex_lock_nested+0x2f/0x50
 [] unbind_from_irq+0x2c/0x1b0
 [] ? free_irq+0x56/0xb0
 [] unbind_from_irqhandler+0x1c/0x30
 [] xen_pcibk_disconnect+0x2b/0x80
 [] xen_pcibk_frontend_changed+0xe8/0x140
 [] xenbus_otherend_changed+0xd2/0x150
 [] ? get_parent_ip+0x11/0x50
 [] frontend_changed+0x10/0x20
 [] xenwatch_thread+0xb2/0x180

Signed-off-by: Konrad Rzeszutek Wilk