linux-toradex.git/drivers, branch v2.6.32.15

Revert "ath9k: fix lockdep warning when unloading module" on stable kernels

2010-05-26T21:29:21+00:00

Johannes' patch 34e8950 titled:

	mac80211: allow station add/remove to sleep

changed the way mac80211 adds and removes peers. The new
sta_add() / sta_remove() callbacks allowed the driver callbacks
to sleep. Johannes also ported ath9k to use sta_add() / sta_remove()
via the patch 4ca7786 titled:

	ath9k: convert to new station add/remove callbacks

but this patch forgot to address a change in locking issue which
Ming Lei eventually found on his 2.6.33-wl #12 build. The 2.6.33-wl
build includes code for the 802.11 subsystem for 2.6.34 though so did
already have the above two patches (ath9k_sta_remove() on his trace),
the 2.6.33 kernel did not however have these two patches. Ming eventually
cured his lockdep warnign via the patch a9f042c titled:

	ath9k: fix lockdep warning when unloading module

This went in to 2.6.34 and although it was not marked as a stable
fix it did get trickled down and applied on both 2.6.33 and 2.6.32.

In review, the culprits:

	mac80211: allow station add/remove to sleep
git describe --contains 34e895075e21be3e21e71d6317440d1ee7969ad0
v2.6.34-rc1~233^2~49^2~107

	ath9k: convert to new station add/remove callbacks
git describe --contains 4ca778605cfec53d8a689f0b57babb93b030c784
v2.6.34-rc1~233^2~49^2~10

	ath9k: fix lockdep warning when unloading module

This last one trickled down to 2.6.33 (OK), 2.6.33 (invalid) and 2.6.32 (invalid).

git describe --contains a9f042cbe5284f34ccff15f3084477e11b39b17b
v2.6.34-rc2~48^2~77^2~7
git describe --contains 0524bcfa80f1fffb4e1fe18a0a28900869a58a7c
v2.6.33.2~125
git describe --contains 0dcc9985f34aef3c60bffab3dfc7f7ba3748f35a
v2.6.32.11~79

The patch titled "ath9k: fix lockdep warning when unloading module"
should be reverted on both 2.6.33 and 2.6.32 as it is invalid and
actually ended up causing the following warning:

ADDRCONF(NETDEV_CHANGE): wlan31: link becomes ready
phy0: WMM queue=2 aci=0 acm=0 aifs=3 cWmin=15 cWmax=1023 txop=0
phy0: WMM queue=3 aci=1 acm=0 aifs=7 cWmin=15 cWmax=1023 txop=0
phy0: WMM queue=1 aci=2 acm=0 aifs=2 cWmin=7 cWmax=15 txop=94
phy0: WMM queue=0 aci=3 acm=0 aifs=2 cWmin=3 cWmax=7 txop=47
phy0: device now idle
------------[ cut here ]------------
WARNING: at kernel/softirq.c:143 local_bh_enable_ip+0x7b/0xa0()
Hardware name: 7660A14
Modules linked in: ath9k(-) mac80211 ath cfg80211 
Pid: 2003, comm: rmmod Not tainted 2.6.32.11 #6
Call Trace:
 [] warn_slowpath_common+0x78/0xb0
 [] warn_slowpath_null+0xf/0x20
 [] local_bh_enable_ip+0x7b/0xa0
 [] _spin_unlock_bh+0x14/0x20
 [] ath_tx_node_cleanup+0x185/0x1b0 [ath9k]
 [] ath9k_sta_notify+0x57/0xb0 [ath9k]
 [] __sta_info_unlink+0x15a/0x260 [mac80211]
 [] sta_info_unlink+0x38/0x60 [mac80211]
 [] ieee80211_set_disassoc+0x1ae/0x210 [mac80211]
 [] ieee80211_mgd_deauth+0x109/0x110 [mac80211]
 [] ieee80211_deauth+0x19/0x20 [mac80211]
 [] __cfg80211_mlme_deauth+0xee/0x130 [cfg80211]
 [] ? init_object+0x50/0x90
 [] __cfg80211_disconnect+0x159/0x1d0 [cfg80211]
 [] cfg80211_netdev_notifier_call+0x10f/0x450 [cfg80211]
 [] notifier_call_chain+0x47/0x90
 [] raw_notifier_call_chain+0x11/0x20
 [] call_netdevice_notifiers+0x16/0x20
 [] dev_close+0x4d/0xa0
 [] rollback_registered+0x48/0x120
 [] unregister_netdevice+0x1d/0x70
 [] ieee80211_remove_interfaces+0x84/0xc0 [mac80211]
 [] ieee80211_unregister_hw+0x42/0xf0 [mac80211]
 [] ath_detach+0x8e/0x180 [ath9k]
 [] ath_cleanup+0x11/0x50 [ath9k]
 [] ath_pci_remove+0x1c/0x20 [ath9k]
 [] pci_device_remove+0x32/0x60
 [] __device_release_driver+0x53/0xb0
 [] driver_detach+0xc8/0xd0
 [] bus_remove_driver+0x85/0xe0
 [] driver_unregister+0x5a/0x90
 [] pci_unregister_driver+0x40/0xb0
 [] ath_pci_exit+0x10/0x20 [ath9k]
 [] ath9k_exit+0x9/0x2a [ath9k]
 [] sys_delete_module+0x1a8/0x270
 [] ? up_read+0x9/0x10
 [] system_call_fastpath+0x16/0x1b
---[ end trace fad957019ffdd40b ]---
phy0: Removed STA 00:22:6b:56:fd:e8
phy0: Destroyed STA 00:22:6b:56:fd:e8
wlan31: deauthenticating from 00:22:6b:56:fd:e8 by local choice (reason=3)
ath9k 0000:16:00.0: PCI INT A disabled

The original lockdep fixed an issue where due to the new changes
the driver was not disabling the bottom halves but it is incorrect
to do this on the older kernels since IRQs are already disabled.

Cc: Ming Lei 
Cc: Johannes Berg 
Cc: John W. Linville 
Signed-off-by: Luis R. Rodriguez 
Signed-off-by: Greg Kroah-Hartman

megaraid_sas: fix for 32bit apps

2010-05-26T21:29:20+00:00

commit b3dc1a212e5167984616445990c76056034f8eeb upstream.

It looks like this patch -

commit 7b2519afa1abd1b9f63aa1e90879307842422dae
Author: Yang, Bo 
Date:   Tue Oct 6 14:52:20 2009 -0600

    [SCSI] megaraid_sas: fix 64 bit sense pointer truncation

has caused a problem for 32bit programs with 64bit os -

http://bugzilla.kernel.org/show_bug.cgi?id=15001

fix by converting the user space 32bit pointer to a 64 bit one when
needed.

[jejb: fix up some 64 bit warnings]
Signed-off-by: Tomas Henzl 
Cc: Bo Yang 
Signed-off-by: James Bottomley 
Signed-off-by: Greg Kroah-Hartman

p54: disable channels with incomplete calibration data sets

2010-05-26T21:29:20+00:00

commit 93a59d7527147e3656664aa3179f8d19de256081 upstream.

James Grossmann [1] reported that p54 spews out confusing
messages instead of preventing the mayhem from happening.

the reason is that "p54: generate channel list dynamically"
is not perfect. It didn't discard incomplete channel data
sets and therefore p54 advertised to support them as well.

[1]: http://marc.info/?l=linux-wireless&m=125699830215890

Cc: Larry Finger 
Reported-by: James Grossmann 
Signed-off-by: Christian Lamparter 
Signed-off-by: John W. Linville 
Signed-off-by: Greg Kroah-Hartman

iwlwifi: clear all the stop_queue flag after load firmware

2010-05-26T21:29:20+00:00

commit a9e10fb9b1c6ad16e73cf2656951fce3a817611e upstream.

All the queues are awake and ready to use after loading firmware,
for firmware reload case, if any queues was stopped before
reload, mac80211 will wake those queues after restart hardware, so make
sure all the flag used to keep track of the queue status are
reset correctly.

Signed-off-by: Wey-Yi Guy 
Signed-off-by: Reinette Chatre 
Signed-off-by: Greg Kroah-Hartman

serial: imx.c: fix CTS trigger level lower to avoid lost chars

2010-05-26T21:29:16+00:00

commit 1c5250d6163dac28be3afabdfb6c723f107051b7 upstream.

The imx CTS trigger level is left at its reset value that is 32
chars. Since the RX FIFO has 32 entries, when CTS is raised, the
FIFO already is full. However, some serial port devices first empty
their TX FIFO before stopping when CTS is raised, resulting in lost
chars.

This patch sets the trigger level lower so that other chars arrive
after CTS is raised, there is still room for 16 of them.

Signed-off-by: Valentin Longchamp
Tested-by: Philippe Rétornaz
Acked-by: Wolfram Sang
Signed-off-by: Greg Kroah-Hartman

mmc: atmel-mci: remove data error interrupt after xfer

2010-05-26T21:29:15+00:00

commit abc2c9fdf636c4335a8d72ac3c5ae152bca44b68 upstream.

Disable data error interrupts while we are actually recording that there
is not such errors.  This will prevent, in some cases, the warning message
printed at new request queuing (in atmci_start_request()).

Signed-off-by: Nicolas Ferre 
Cc: Haavard Skinnemoen 
Cc: 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds 
Signed-off-by: Greg Kroah-Hartman

mmc: atmel-mci: prevent kernel oops while removing card

2010-05-26T21:29:15+00:00

commit 009a891b22395fc86e5f34057d79fffee4509ab5 upstream.

The removing of an SD card in certain circumstances can lead to a kernel
oops if we do not make sure that the "data" field of the host structure is
valid.  This patch adds a test in atmci_dma_cleanup() function and also
calls atmci_stop_dma() before throwing away the reference to data.

Signed-off-by: Nicolas Ferre 
Cc: Haavard Skinnemoen 
Cc: 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds 
Signed-off-by: Greg Kroah-Hartman

mmc: atmel-mci: fix two parameters swapped

2010-05-26T21:29:15+00:00

commit ebb1fea9b3adf25d7e2f643c614163af4f93a17f upstream.

Two parameters were swapped in the calls to atmci_init_slot().

Signed-off-by: Nicolas Ferre 
Reported-by: Anders Grahn 
Cc: Haavard Skinnemoen 
Cc: 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds 
Signed-off-by: Greg Kroah-Hartman

ACPI: sleep: eliminate duplicate entries in acpisleep_dmi_table[]

2010-05-26T21:29:14+00:00

commit 7d6fb7bd1919517937ec390f6ca2d7bcf4f89fb6 upstream.

Duplicate entries ended up acpisleep_dmi_table[] by accident.
They don't hurt functionality, but they are ugly, so let's get
rid of them.

Signed-off-by: Alex Chiang 
Signed-off-by: Linus Torvalds 
Signed-off-by: Greg Kroah-Hartman

fbdev: bfin-t350mcqb-fb: fix fbmem allocation with blanking lines

2010-05-26T21:29:14+00:00

commit de145b44b95b9d3212a82d1c0f29b09778ef33c5 upstream.

The current allocation does not include the memory required for blanking
lines.  So avoid memory corruption when multiple devices are using the DMA
memory near each other.

Signed-off-by: Michael Hennerich 
Signed-off-by: Mike Frysinger 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds 
Signed-off-by: Greg Kroah-Hartman