linux-toradex.git/drivers, branch v2.6.32.51

USB: cdc-acm: add IDs for Motorola H24 HSPA USB module.

2011-12-21T21:04:55+00:00

commit 6abff5dc4d5a2c90e597137ce8987e7fd439259b upstream.

Add USB IDs for Motorola H24 HSPA USB module.

Signed-off-by: Krzysztof Hałasa 
Acked-by: Oliver Neukum 
Signed-off-by: Greg Kroah-Hartman

oprofile: Fix locking dependency in sync_start()

2011-12-21T21:04:51+00:00

commit 130c5ce716c9bfd1c2a2ec840a746eb7ff9ce1e6 upstream.

This fixes the A->B/B->A locking dependency, see the warning below.

The function task_exit_notify() is called with (task_exit_notifier)
.rwsem set and then calls sync_buffer() which locks buffer_mutex. In
sync_start() the buffer_mutex was set to prevent notifier functions to
be started before sync_start() is finished. But when registering the
notifier, (task_exit_notifier).rwsem is locked too, but now in
different order than in sync_buffer(). In theory this causes a locking
dependency, what does not occur in practice since task_exit_notify()
is always called after the notifier is registered which means the lock
is already released.

However, after checking the notifier functions it turned out the
buffer_mutex in sync_start() is unnecessary. This is because
sync_buffer() may be called from the notifiers even if sync_start()
did not finish yet, the buffers are already allocated but empty. No
need to protect this with the mutex.

So we fix this theoretical locking dependency by removing buffer_mutex
in sync_start(). This is similar to the implementation before commit:

 750d857 oprofile: fix crash when accessing freed task structs

which introduced the locking dependency.

Lockdep warning:

oprofiled/4447 is trying to acquire lock:
 (buffer_mutex){+.+...}, at: [] sync_buffer+0x31/0x3ec [oprofile]

but task is already holding lock:
 ((task_exit_notifier).rwsem){++++..}, at: [] __blocking_notifier_call_chain+0x39/0x67

which lock already depends on the new lock.

the existing dependency chain (in reverse order) is:

-> #1 ((task_exit_notifier).rwsem){++++..}:
       [] lock_acquire+0xf8/0x11e
       [] down_write+0x44/0x67
       [] blocking_notifier_chain_register+0x52/0x8b
       [] profile_event_register+0x2d/0x2f
       [] sync_start+0x47/0xc6 [oprofile]
       [] oprofile_setup+0x60/0xa5 [oprofile]
       [] event_buffer_open+0x59/0x8c [oprofile]
       [] __dentry_open+0x1eb/0x308
       [] nameidata_to_filp+0x60/0x67
       [] do_last+0x5be/0x6b2
       [] path_openat+0xc7/0x360
       [] do_filp_open+0x3d/0x8c
       [] do_sys_open+0x110/0x1a9
       [] sys_open+0x20/0x22
       [] system_call_fastpath+0x16/0x1b

-> #0 (buffer_mutex){+.+...}:
       [] __lock_acquire+0x1085/0x1711
       [] lock_acquire+0xf8/0x11e
       [] mutex_lock_nested+0x63/0x309
       [] sync_buffer+0x31/0x3ec [oprofile]
       [] task_exit_notify+0x16/0x1a [oprofile]
       [] notifier_call_chain+0x37/0x63
       [] __blocking_notifier_call_chain+0x50/0x67
       [] blocking_notifier_call_chain+0x14/0x16
       [] profile_task_exit+0x1a/0x1c
       [] do_exit+0x2a/0x6fc
       [] do_group_exit+0x83/0xae
       [] sys_exit_group+0x17/0x1b
       [] system_call_fastpath+0x16/0x1b

other info that might help us debug this:

1 lock held by oprofiled/4447:
 #0:  ((task_exit_notifier).rwsem){++++..}, at: [] __blocking_notifier_call_chain+0x39/0x67

stack backtrace:
Pid: 4447, comm: oprofiled Not tainted 2.6.39-00007-gcf4d8d4 #10
Call Trace:
 [] print_circular_bug+0xae/0xbc
 [] __lock_acquire+0x1085/0x1711
 [] ? sync_buffer+0x31/0x3ec [oprofile]
 [] lock_acquire+0xf8/0x11e
 [] ? sync_buffer+0x31/0x3ec [oprofile]
 [] ? mark_lock+0x42f/0x552
 [] ? sync_buffer+0x31/0x3ec [oprofile]
 [] mutex_lock_nested+0x63/0x309
 [] ? sync_buffer+0x31/0x3ec [oprofile]
 [] sync_buffer+0x31/0x3ec [oprofile]
 [] ? __blocking_notifier_call_chain+0x39/0x67
 [] ? __blocking_notifier_call_chain+0x39/0x67
 [] task_exit_notify+0x16/0x1a [oprofile]
 [] notifier_call_chain+0x37/0x63
 [] __blocking_notifier_call_chain+0x50/0x67
 [] blocking_notifier_call_chain+0x14/0x16
 [] profile_task_exit+0x1a/0x1c
 [] do_exit+0x2a/0x6fc
 [] ? retint_swapgs+0xe/0x13
 [] do_group_exit+0x83/0xae
 [] sys_exit_group+0x17/0x1b
 [] system_call_fastpath+0x16/0x1b

Reported-by: Marcin Slusarz 
Cc: Carl Love 
Signed-off-by: Robert Richter 
Signed-off-by: Greg Kroah-Hartman

oprofile: Free potentially owned tasks in case of errors

2011-12-21T21:04:51+00:00

commit 6ac6519b93065625119a347be1cbcc1b89edb773 upstream.

After registering the task free notifier we possibly have tasks in our
dying_tasks list. Free them after unregistering the notifier in case
of an error.

Signed-off-by: Robert Richter 
Signed-off-by: Greg Kroah-Hartman

SCSI: Silencing 'killing requests for dead queue'

2011-12-09T17:21:47+00:00

commit 745718132c3c7cac98a622b610e239dcd5217f71 upstream.

When we tear down a device we try to flush all outstanding
commands in scsi_free_queue(). However the check in
scsi_request_fn() is imperfect as it only signals that
we _might start_ aborting commands, not that we've actually
aborted some.
So move the printk inside the scsi_kill_request function,
this will also give us a hint about which commands are aborted.

Signed-off-by: Hannes Reinecke 
Signed-off-by: James Bottomley 
Signed-off-by: Greg Kroah-Hartman

SCSI: scsi_lib: fix potential NULL dereference

2011-12-09T17:21:46+00:00

commit 03b147083a2f9a2a3fbbd2505fa88ffa3c6ab194 upstream.

Stanse found a potential NULL dereference in scsi_kill_request.

Instead of triggering BUG() in 'if (unlikely(cmd == NULL))' branch,
the kernel will Oops earlier on cmd dereference.

Move the dereferences after the if.

Signed-off-by: Jiri Slaby 
Signed-off-by: James Bottomley 
Signed-off-by: Greg Kroah-Hartman

USB: usb-storage: unusual_devs entry for Kingston DT 101 G2

2011-12-09T17:21:45+00:00

commit cec28a5428793b6bc64e56687fb239759d6da74e upstream.

Kingston DT 101 G2 replies a wrong tag while transporting, add an
unusal_devs entry to ignore the tag validation.

Signed-off-by: Qinglin Ye 
Signed-off-by: Greg Kroah-Hartman

usb: option: add SIMCom SIM5218

2011-12-09T17:21:45+00:00

commit ec0cd94d881ca89cc9fb61d00d0f4b2b52e605b3 upstream.

Tested with SIM5218EVB-KIT evaluation kit.

Signed-off-by: Veli-Pekka Peltola 
Signed-off-by: Greg Kroah-Hartman

usb: ftdi_sio: add PID for Propox ISPcable III

2011-12-09T17:21:44+00:00

commit 307369b0ca06b27b511b61714e335ddfccf19c4f upstream.

Signed-off-by: Marcin Kościelnicki 
Signed-off-by: Greg Kroah-Hartman

USB: whci-hcd: fix endian conversion in qset_clear()

2011-12-09T17:21:43+00:00

commit 8746c83d538cab273d335acb2be226d096f4a5af upstream.

qset->qh.link is an __le64 field and we should be using cpu_to_le64()
to fill it.

Signed-off-by: Dan Carpenter 
Signed-off-by: Greg Kroah-Hartman

Staging: comedi: fix signal handling in read and write

2011-12-09T17:21:42+00:00

commit 6a9ce6b654e491981f6ef7e214cbd4f63e033848 upstream.

After sleeping on a wait queue, signal_pending(current) should be
checked (not before sleeping).

Acked-by: Alessandro Rubini 
Signed-off-by: Federico Vaga 
Signed-off-by: Greg Kroah-Hartman