linux-toradex.git/fs/autofs, branch v6.7

autofs: add: new_inode check in autofs_fill_super()

2023-11-20T13:56:36+00:00

Add missing NULL check of root_inode in autofs_fill_super().

While we are at it simplify the logic by taking advantage of the VFS
cleanup procedures and get rid of the goto error handling, as suggested
by Al Viro.

Signed-off-by: Ian Kent 
Link: https://lore.kernel.org/r/20231119225319.331156-1-raven@themaw.net
Reviewed-by: Bill O'Donnell 
Cc: Al Viro 
Cc: Christian Brauner 
Cc: Bill O'Donnell 
Reported-by: 
Signed-off-by: Christian Brauner

Merge tag 'vfs-6.7.ctime' of gitolite.kernel.org:pub/scm/linux/kernel/git/vfs/vfs

2023-10-30T19:47:13+00:00

Pull vfs inode time accessor updates from Christian Brauner:
 "This finishes the conversion of all inode time fields to accessor
  functions as discussed on list. Changing timestamps manually as we
  used to do before is error prone. Using accessors function makes this
  robust.

  It does not contain the switch of the time fields to discrete 64 bit
  integers to replace struct timespec and free up space in struct inode.
  But after this, the switch can be trivially made and the patch should
  only affect the vfs if we decide to do it"

* tag 'vfs-6.7.ctime' of gitolite.kernel.org:pub/scm/linux/kernel/git/vfs/vfs: (86 commits)
  fs: rename inode i_atime and i_mtime fields
  security: convert to new timestamp accessors
  selinux: convert to new timestamp accessors
  apparmor: convert to new timestamp accessors
  sunrpc: convert to new timestamp accessors
  mm: convert to new timestamp accessors
  bpf: convert to new timestamp accessors
  ipc: convert to new timestamp accessors
  linux: convert to new timestamp accessors
  zonefs: convert to new timestamp accessors
  xfs: convert to new timestamp accessors
  vboxsf: convert to new timestamp accessors
  ufs: convert to new timestamp accessors
  udf: convert to new timestamp accessors
  ubifs: convert to new timestamp accessors
  tracefs: convert to new timestamp accessors
  sysv: convert to new timestamp accessors
  squashfs: convert to new timestamp accessors
  server: convert to new timestamp accessors
  client: convert to new timestamp accessors
  ...

autofs: fix add autofs_parse_fd()

2023-10-24T09:04:45+00:00

We are seeing systemd hang on its autofs direct mount at
/proc/sys/fs/binfmt_misc.

Historically this was due to a mismatch in the communication structure
size between a 64 bit kernel and a 32 bit user space and was fixed by
making the pipe communication record oriented.

During autofs v5 development I decided to stay with the existing usage
instead of changing to a packed structure for autofs <=> user space
communications which turned out to be a mistake on my part.

Problems arose and they were fixed by allowing for the 64 bit to 32
bit size difference in the automount(8) code.

Along the way systemd started to use autofs and eventually encountered
this problem too. systemd refused to compensate for the length
difference insisting it be fixed in the kernel. Fortunately Linus
implemented the packetized pipe which resolved the problem in a
straight forward and simple way.

In the autofs mount api conversion series I inadvertatly dropped the
packet pipe flag settings when adding the autofs_parse_fd() function.
This patch fixes that omission.

Fixes: 546694b8f658 ("autofs: add autofs_parse_fd()")
Signed-off-by: Ian Kent 
Link: https://lore.kernel.org/r/20231023093359.64265-1-raven@themaw.net
Tested-by: Anders Roxell 
Cc: Bill O'Donnell 
Cc: Christian Brauner 
Cc: Arnd Bergmann 
Cc: Dan Carpenter 
Cc: Anders Roxell 
Cc: Naresh Kamboju 
Cc: Stephen Rothwell 
Reported-by: Linux Kernel Functional Testing 
Reported-by: Anders Roxell 
Signed-off-by: Christian Brauner

autofs: convert to new timestamp accessors

2023-10-18T11:26:18+00:00

Convert to using the new inode timestamp accessor functions.

Signed-off-by: Jeff Layton 
Link: https://lore.kernel.org/r/20231004185347.80880-17-jlayton@kernel.org
Signed-off-by: Christian Brauner

autofs: fix protocol sub version setting

2023-09-22T12:08:02+00:00

There were a number of updates to protocol version 4, take account of
that when setting the super block info sub version field.

Signed-off-by: Ian Kent 
Reviewed-by: Bill O'Donnell 
Message-Id: <20230922041215.13675-9-raven@themaw.net>
Signed-off-by: Christian Brauner

autofs: convert autofs to use the new mount api

2023-09-22T12:08:02+00:00

Convert the autofs filesystem to use the mount API.

The conversion patch was originally written by David Howells.
I have taken that patch and broken it into several patches in an effort
to make the change easier to review.

Signed-off-by: Ian Kent 
Reviewed-by: Bill O'Donnell 
Message-Id: <20230922041215.13675-8-raven@themaw.net>
Signed-off-by: Christian Brauner

autofs: validate protocol version

2023-09-22T08:14:59+00:00

Move the protocol parameter validation into a seperate function.

Signed-off-by: Ian Kent 
Reviewed-by: Bill O'Donnell 
Message-Id: <20230922041215.13675-7-raven@themaw.net>
Signed-off-by: Christian Brauner

autofs: refactor parse_options()

2023-09-22T08:14:59+00:00

Seperate out parts of parse_options() that will match better the
individual option processing used in the mount API to further simplify
the upcoming conversion.

Signed-off-by: Ian Kent 
Reviewed-by: Bill O'Donnell 
Message-Id: <20230922041215.13675-6-raven@themaw.net>
Signed-off-by: Christian Brauner

autofs: reformat 0pt enum declaration

2023-09-22T08:14:59+00:00

The enum of options is only reformated in the patch to convert autofs
to use the mount API so do that now to simplify the conversion patch.

Signed-off-by: Ian Kent 
Reviewed-by: Bill O'Donnell 
Message-Id: <20230922041215.13675-5-raven@themaw.net>
Signed-off-by: Christian Brauner

autofs: refactor super block info init

2023-09-22T08:14:59+00:00

Move the allocation and initialisation of the super block
info struct to its own function.

Signed-off-by: Ian Kent 
Reviewed-by: Bill O'Donnell 
Message-Id: <20230922041215.13675-4-raven@themaw.net>
Signed-off-by: Christian Brauner