linux-toradex.git/fs/befs/datastream.c, branch v4.9.45

befs: befs: fix style issues in datastream.c

2016-10-08T09:01:36+00:00

Fixing the following checkpatch.pl errors:

ERROR: "foo * bar" should be "foo *bar"
+                            befs_blocknr_t blockno, befs_block_run * run);

WARNING: Missing a blank line after declarations
+       struct buffer_head *bh;
+       befs_debug(sb, "---> %s length: %llu", __func__, len);

WARNING: Block comments use * on subsequent lines
+       /*
+          Double indir block, plus all the indirect blocks it maps.

(and other instances of these)

Signed-off-by: Luis de Bethencourt 
Signed-off-by: Salah Triki

befs: improve documentation in datastream.c

2016-10-08T09:01:36+00:00

Convert function descriptions to kernel-doc style.

Signed-off-by: Luis de Bethencourt 
Signed-off-by: Salah Triki

befs: fix typos in datastream.c

2016-10-08T09:01:35+00:00

Signed-off-by: Luis de Bethencourt 
Signed-off-by: Salah Triki

fs: befs: remove unnecessary *befs_sb variable

2016-10-08T09:01:23+00:00

Remove *befs_sb and just call BEFS_SB(sb) directly, since the returned
value by this function is only used once.

Signed-off-by: Salah Triki 
Acked-by: Luis de Bethencourt

fs: befs: Remove useless calls to brelse in befs_find_brun_dblindirect

2016-10-08T09:01:20+00:00

The calls to brelse are useless since dbl_indir_block and indir_block
are NULL.

Signed-off-by: Salah Triki 
Acked-by: Luis de Bethencourt

fs: befs: Remove redundant validation from befs_find_brun_direct

2016-10-08T09:01:19+00:00

The only caller of befs_find_brun_direct is befs_fblock2brun, which
already validates that the block is within the range of direct blocks.
So remove the duplicate validation.

Signed-off-by: Salah Triki 
Acked-by: Luis de Bethencourt

befs: make consistent use of befs_error()

2016-10-08T09:01:16+00:00

befs_error() is used in potential errors that could happen in befs to
provide informational log messages. befs_debug() is silent when
CONFIG_BEFS_DEBUG=no, and very verbose when switched on, which is why it is
used for general debugging but not for errors.

Fix a few cases where the befs debug utility usage isn't following the
expected pattern. To make sure we have consistent information in the logs.

Signed-off-by: Luis de Bethencourt

fs: befs: replace befs_bread by sb_bread

2016-10-08T09:01:12+00:00

Since befs_bread merely calls sb_bread, replace it by sb_bread.

Link: http://lkml.kernel.org/r/1466800258-4542-1-git-send-email-salah.triki@gmail.com
Signed-off-by: Salah Triki 
Acked-by: Luis de Bethencourt 
Signed-off-by: Andrew Morton

fs/befs/datastream.c:befs_find_brun_dblindirect(): remove unneeded initializations to NULL

2016-05-24T00:04:14+00:00

iaddr_array is unconditionally initialized to NULL in
befs_find_brun_dblindirect().

Link: http://lkml.kernel.org/r/940def273e30ef37957fba9da6981a10fb3c9741.1462649034.git.salah.triki@acm.org
Signed-off-by: Salah Triki 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

fs/befs/datastream.c:befs_read_lsymlink(): remove unneeded initialization to NULL

2016-05-24T00:04:14+00:00

bh is reinitialized by befs_read_datastream() so no need to init it
with NULL in the beginning of befs_read_lsymlink().

Link: http://lkml.kernel.org/r/e22f279bceb8d026af048952e02ba98925b21c92.1462649034.git.salah.triki@acm.org
Signed-off-by: Salah Triki 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds