linux-toradex.git/fs/bfs, branch v2.6.27.24

bfs: fix Lockdep warning

2008-09-13T21:41:51+00:00

This fixes:

  =============================================
  [ INFO: possible recursive locking detected ]
  2.6.27-rc5-00283-g70bb089 #68
  ---------------------------------------------
  touch/6855 is trying to acquire lock:
   (&info->bfs_lock){--..}, at: [] bfs_delete_inode+0x9e/0x18c

  but task is already holding lock:
   (&info->bfs_lock){--..}, at: [] bfs_create+0x45/0x187

  other info that might help us debug this:
  2 locks held by touch/6855:
   #0:  (&type->i_mutex_dir_key#5){--..}, at: [] do_filp_open+0x10b/0x62f
   #1:  (&info->bfs_lock){--..}, at: [] bfs_create+0x45/0x187

  stack backtrace:
  Pid: 6855, comm: touch Not tainted 2.6.27-rc5-00283-g70bb089 #68
   [] validate_chain+0x458/0x9f4
   [] ? trace_hardirqs_off+0xb/0xd
   [] __lock_acquire+0x666/0x6e0
   [] lock_acquire+0x5b/0x77
   [] ? bfs_delete_inode+0x9e/0x18c
   [] mutex_lock_nested+0xbc/0x234
   [] ? bfs_delete_inode+0x9e/0x18c
   [] ? bfs_delete_inode+0x9e/0x18c
   [] bfs_delete_inode+0x9e/0x18c
   [] ? bfs_delete_inode+0x0/0x18c
   [] generic_delete_inode+0x94/0xfe
   [] generic_drop_inode+0x12/0x12f
   [] iput+0x4b/0x4e
   [] bfs_create+0x163/0x187
   [] vfs_create+0xa6/0x114
   [] do_filp_open+0x1ad/0x62f
   [] ? native_sched_clock+0x82/0x96
   [] ? _spin_unlock+0x27/0x3c
   [] ? alloc_fd+0xbf/0xc9
   [] ? sub_preempt_count+0x9d/0xab
   [] ? alloc_fd+0xbf/0xc9
   [] do_sys_open+0x42/0xb8
   [] ? trace_hardirqs_on_thunk+0xc/0x10
   [] sys_open+0x1e/0x26
   [] sysenter_do_call+0x12/0x31
   =======================

The problem is that we don't unlock the bfs->lock mutex before calling
iput (we do in the other cases).

Signed-off-by: Eric Sesterhenn 
Cc: Tigran Aivazian 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

SL*B: drop kmem cache argument from constructor

2008-07-26T19:00:07+00:00

Kmem cache passed to constructor is only needed for constructors that are
themselves multiplexeres.  Nobody uses this "feature", nor does anybody uses
passed kmem cache in non-trivial way, so pass only pointer to object.

Non-trivial places are:
	arch/powerpc/mm/init_64.c
	arch/powerpc/mm/hugetlbpage.c

This is flag day, yes.

Signed-off-by: Alexey Dobriyan 
Acked-by: Pekka Enberg 
Acked-by: Christoph Lameter 
Cc: Jon Tollefson 
Cc: Nick Piggin 
Cc: Matt Mackall 
[akpm@linux-foundation.org: fix arch/powerpc/mm/hugetlbpage.c]
[akpm@linux-foundation.org: fix mm/slab.c]
[akpm@linux-foundation.org: fix ubifs]
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

bfs: kill BKL

2008-07-26T19:00:03+00:00

Replace the BKL-based locking scheme used in the bfs driver by a private
filesystem-wide mutex.

Signed-off-by: Dmitri Vorobiev 
Cc: Tigran Aivazian 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

bfs: assorted cleanups

2008-07-26T19:00:03+00:00

This patch makes the following cleanups:

	o removing an unused variable from bfs_fill_super();
	o removing unneeded blank spaces from pointer
	  definitions.

Signed-off-by: Dmitri Vorobiev 
Cc: Tigran Aivazian 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

fs: replace remaining FUNCTION occurrences

2008-04-30T15:29:54+00:00

__FUNCTION__ is gcc-specific, use __func__

Signed-off-by: Harvey Harrison 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

iget: stop BFS from using iget() and read_inode()

2008-02-07T16:42:27+00:00

Stop the BFS filesystem from using iget() and read_inode().  Replace
bfs_read_inode() with bfs_iget(), and call that instead of iget().  bfs_iget()
then uses iget_locked() directly and returns a proper error code instead of an
inode in the event of an error.

bfs_fill_super() returns any error incurred when getting the root inode
instead of EINVAL.

[kamalesh@linux.vnet.ibm.com: build fix]
Signed-off-by: David Howells 
Acked-by: Christoph Hellwig 
Signed-off-by: Kamalesh Babulal 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

regression: bfs endianness bug

2007-12-05T17:25:20+00:00

BFS_FILEBLOCKS() expects struct bfs_inode * (on-disk data, with little-
endian fields), not struct bfs_inode_info * (in-core stuff, with host-
endian ones).

It's a macro and fields with the right names are present in
bfs_inode_info, so it compiles, but on big-endian host it gives bogus
results.

Introduced in commit f433dc56344cb72cc3de5ba0819021cec3aef807 ("Fixes to
the BFS filesystem driver").

Signed-off-by: Al Viro 
Signed-off-by: Linus Torvalds

Fixes to the BFS filesystem driver

2007-11-15T02:45:40+00:00

I found a few bugs in the BFS driver.  Detailed description of the bugs as
well as the steps to reproduce the errors are given in the kernel bugzilla.
 Please follow these links for more information:

http://bugzilla.kernel.org/show_bug.cgi?id=9363
http://bugzilla.kernel.org/show_bug.cgi?id=9364
http://bugzilla.kernel.org/show_bug.cgi?id=9365
http://bugzilla.kernel.org/show_bug.cgi?id=9366

This patch fixes the bugs described above.  Besides, the patch introduces
coding style changes to make the BFS driver conform to the requirements
specified for Linux kernel code.  Finally, I made a few cosmetic changes
such as removal of trivial debug output.

Also, the patch removes the fields `si_lf_ioff' and `si_lf_sblk' of the
in-core superblock structure.  These fields are initialized but never
actually used.

If you are wondering why I need BFS, here is the answer: I am using this
driver in the context of Linux kernel classes I am teaching in the Moscow
State University and in the International Institute of Information
Technology in Pune, India.

Signed-off-by: Dmitri Vorobiev 
Cc: Tigran Aivazian 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

Slab API: remove useless ctor parameter and reorder parameters

2007-10-17T15:42:45+00:00

Slab constructors currently have a flags parameter that is never used.  And
the order of the arguments is opposite to other slab functions.  The object
pointer is placed before the kmem_cache pointer.

Convert

        ctor(void *object, struct kmem_cache *s, unsigned long flags)

to

        ctor(struct kmem_cache *s, void *object)

throughout the kernel

[akpm@linux-foundation.org: coupla fixes]
Signed-off-by: Christoph Lameter 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

bfs: convert to new aops

2007-10-16T16:42:56+00:00

Signed-off-by: Nick Piggin 
Cc: Tigran Aivazian 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds