linux-toradex.git/fs/btrfs/acl.c, branch v2.6.32.26

Btrfs: fix a memory leak in btrfs_init_acl

2010-08-13T20:20:06+00:00

commit f858153c367a397235d3e81136741e40e44faf1d upstream.

In btrfs_init_acl() cloned acl is not released

Signed-off-by: Yang Hongyang 
Signed-off-by: Chris Mason 
Acked-by: Jeff Mahoney 
Signed-off-by: Greg Kroah-Hartman

Btrfs: deal with NULL acl sent to btrfs_set_acl

2010-08-13T20:20:04+00:00

commit a9cc71a60c29a09174bee2fcef8f924c529fd4b7 upstream.

It is legal for btrfs_set_acl to be sent a NULL acl.  This
makes sure we don't dereference it.  A similar patch was sent by
Johannes Hirte 

Signed-off-by: Chris Mason 
Acked-by: Jeff Mahoney 
Signed-off-by: Greg Kroah-Hartman

Btrfs: Pass transaction handle to security and ACL initialization functions

2010-08-13T20:19:56+00:00

commit f34f57a3ab4e73304d78c125682f1a53cd3975f2 upstream.

Pass transaction handle down to security and ACL initialization
functions, so we can avoid starting nested transactions

Signed-off-by: Yan Zheng 
Signed-off-by: Chris Mason 
Acked-by: Jeff Mahoney 
Signed-off-by: Greg Kroah-Hartman

Btrfs: should add a permission check for setfacl

2010-07-05T18:11:15+00:00

commit 2f26afba46f0ebf155cf9be746496a0304a5b7cf upstream.

On btrfs, do the following
------------------
# su user1
# cd btrfs-part/
# touch aaa
# getfacl aaa
  # file: aaa
  # owner: user1
  # group: user1
  user::rw-
  group::rw-
  other::r--
# su user2
# cd btrfs-part/
# setfacl -m u::rwx aaa
# getfacl aaa
  # file: aaa
  # owner: user1
  # group: user1
  user::rwx           <- successed to setfacl
  group::rw-
  other::r--
------------------
but we should prohibit it that user2 changing user1's acl.
In fact, on ext3 and other fs, a message occurs:
  setfacl: aaa: Operation not permitted

This patch fixed it.

Signed-off-by: Shi Weihua 
Signed-off-by: Chris Mason 
Signed-off-by: Greg Kroah-Hartman

Btrfs: fix btrfs acl #ifdef checks

2009-10-13T17:51:39+00:00

The btrfs acl code was #ifdefing for a define
that didn't exist.  This correctly matches it
to the values used by the Kconfig file.

Signed-off-by: Chris Mason

Btrfs: Use CONFIG_BTRFS_POSIX_ACL to enable ACL code

2009-09-29T17:51:05+00:00

We've already defined CONFIG_BTRFS_POSIX_ACL in Kconfig, but we're
currently not using it and are testing CONFIG_FS_POSIX_ACL instead.
CONFIG_FS_POSIX_ACL states "Never use this symbol for ifdefs".

Signed-off-by: Chris Ball 
Signed-off-by: Chris Mason

helpers for acl caching + switch to those

2009-06-24T12:17:07+00:00

helpers: get_cached_acl(inode, type), set_cached_acl(inode, type, acl),
forget_cached_acl(inode, type).

ubifs/xattr.c needed includes reordered, the rest is a plain switchover.

Signed-off-by: Al Viro

switch btrfs to inode->i_acl

2009-06-24T12:17:05+00:00

Signed-off-by: Al Viro

Fix btrfs when ACLs are configured out

2009-06-10T15:36:43+00:00

... otherwise generic_permission() will allow *anything* for all
files you don't own and that have some group permissions.

Signed-off-by: Al Viro 
Signed-off-by: Chris Mason

Btrfs: fix acl caching

2009-04-27T17:18:26+00:00

Linus noticed the btrfs code to cache acls wasn't properly caching
a NULL acl when the inode didn't have any acls.  This meant the common
case of no acls resulted in expensive btree searches every time the
kernel checked permissions (which is quite often).

This is a modified version of Linus' original patch:

Properly set initial acl fields to BTRFS_ACL_NOT_CACHED in the inode.
This forces an acl lookup when permission checks are done.

Fix btrfs_get_acl to avoid lookups and locking when the inode acls fields
are set to null.

Fix btrfs_get_acl to use the right return value from __btrfs_getxattr
when deciding to cache a NULL acl.  It was storing a NULL acl when
__btrfs_getxattr return -ENOENT, but __btrfs_getxattr was actually returning
-ENODATA for this case.

Signed-off-by: Chris Mason