linux-toradex.git/fs/btrfs/ctree.c, branch v4.9.21

Btrfs: remove unnecessary btrfs_mark_buffer_dirty in split_leaf

2016-09-26T17:50:44+00:00

When we're not able to get enough space through splitting leaf,
we'd create a new sibling leaf instead, and it's possible that we return
 a zero-nritem sibling leaf and mark it dirty before it's in a consistent
state.  With CONFIG_BTRFS_FS_CHECK_INTEGRITY=y, the integrity check of
check_leaf will report panic due to this zero-nritem non-root leaf.

This removes the unnecessary btrfs_mark_buffer_dirty.

Reported-by: Filipe Manana 
Signed-off-by: Liu Bo 
Signed-off-by: David Sterba

Btrfs: memset to avoid stale content in btree leaf

2016-09-26T17:37:06+00:00

This is an additional patch to
"Btrfs: memset to avoid stale content in btree node block".

This uses memset to initialize the unused space in a leaf to avoid
potential stale content, which may be incurred by pushing items
between sibling leaves.

Signed-off-by: Liu Bo 
Reviewed-by: David Sterba 
Signed-off-by: David Sterba

btrfs: parent_start initialization cleanup

2016-09-26T17:37:06+00:00

Code cleanup. parent_start is initialized multiple times when it is
not necessary to do so.

Signed-off-by: Goldwyn Rodrigues 
Reviewed-by: David Sterba 
Signed-off-by: David Sterba

btrfs: convert printk(KERN_* to use pr_* calls

2016-09-26T16:08:44+00:00

This patch converts printk(KERN_* style messages to use the pr_* versions.

One side effect is that anything that was KERN_DEBUG is now automatically
a dynamic debug message.

Signed-off-by: Jeff Mahoney 
Signed-off-by: David Sterba

btrfs: unsplit printed strings

2016-09-26T16:08:44+00:00

CodingStyle chapter 2:
"[...] never break user-visible strings such as printk messages,
because that breaks the ability to grep for them."

This patch unsplits user-visible strings.

Signed-off-by: Jeff Mahoney 
Signed-off-by: David Sterba

btrfs: squash lines for simple wrapper functions

2016-09-26T16:08:38+00:00

Remove unneeded variables and assignments.

Signed-off-by: Masahiro Yamada 
Reviewed-by: David Sterba 
Signed-off-by: David Sterba

btrfs: Fix warning "variable ‘gen’ set but not used"

2016-09-26T15:59:49+00:00

Variable 'gen' in reada_for_search() is not used since commit 58dc4ce43251
("btrfs: remove unused parameter from readahead_tree_block").  This patch
simply removes this variable.

Signed-off-by: Luis Henriques 
Reviewed-by: David Sterba 
Signed-off-by: David Sterba

btrfs: btrfs_abort_transaction, drop root parameter

2016-07-26T11:54:26+00:00

__btrfs_abort_transaction doesn't use its root parameter except to
obtain an fs_info pointer.  We can obtain that from trans->root->fs_info
for now and from trans->fs_info in a later patch.

Signed-off-by: Jeff Mahoney 
Signed-off-by: David Sterba

btrfs: tests, use BTRFS_FS_STATE_DUMMY_FS_INFO instead of dummy root

2016-07-26T11:54:19+00:00

Now that we have a dummy fs_info associated with each test that
uses a root, we don't need the DUMMY_ROOT bit anymore.  This lets
us make choices without needing an actual root like in e.g.
btrfs_find_create_tree_block.

Signed-off-by: Jeff Mahoney 
Signed-off-by: David Sterba

Btrfs: fix read_node_slot to return errors

2016-07-26T11:52:25+00:00

We use read_node_slot() to read btree node and it has two cases,
a) slot is out of range, which means 'no such entry'
b) we fail to read the block, due to checksum fails or corrupted
   content or not with uptodate flag.
But we're returning NULL in both cases, this makes it return -ENOENT
in case a) and return -EIO in case b), and this fixes its callers
as well as btrfs_search_forward() 's caller to catch the new errors.

The problem is reported by Peter Becker, and I can manage to
hit the same BUG_ON by mounting my fuzz image.

Reported-by: Peter Becker 
Signed-off-by: Liu Bo 
Reviewed-by: David Sterba 
Signed-off-by: David Sterba