linux-toradex.git/fs/btrfs/dev-replace.c, branch v3.15.10

Btrfs: don't flush all delalloc inodes when we doesn't get s_umount lock

2014-03-10T19:17:27+00:00

We needn't flush all delalloc inodes when we doesn't get s_umount lock,
or we would make the tasks wait for a long time.

Signed-off-by: Miao Xie 
Signed-off-by: Josef Bacik

Btrfs: fix use-after-free in the finishing procedure of the device replace

2014-03-10T19:15:39+00:00

During device replace test, we hit a null pointer deference (It was very easy
to reproduce it by running xfstests' btrfs/011 on the devices with the virtio
scsi driver). There were two bugs that caused this problem:
- We might allocate new chunks on the replaced device after we updated
  the mapping tree. And we forgot to replace the source device in those
  mapping of the new chunks.
- We might get the mapping information which including the source device
  before the mapping information update. And then submit the bio which was
  based on that mapping information after we freed the source device.

For the first bug, we can fix it by doing mapping tree update and source
device remove in the same context of the chunk mutex. The chunk mutex is
used to protect the allocable device list, the above method can avoid
the new chunk allocation, and after we remove the source device, all
the new chunks will be allocated on the new device. So it can fix
the first bug.

For the second bug, we need make sure all flighting bios are finished and
no new bios are produced during we are removing the source device. To fix
this problem, we introduced a global @bio_counter, we not only inc/dec
@bio_counter outsize of map_blocks, but also inc it before submitting bio
and dec @bio_counter when ending bios.

Since Raid56 is a little different and device replace dosen't support raid56
yet, it is not addressed in the patch and I add comments to make sure we will
fix it in the future.

Reported-by: Qu Wenruo 
Signed-off-by: Wang Shilong 
Signed-off-by: Miao Xie 
Signed-off-by: Josef Bacik

Btrfs: fix unprotected alloc list insertion during the finishing procedure of replace

2014-03-10T19:15:38+00:00

the alloc list of the filesystem is protected by ->chunk_mutex, we need
get that mutex when we insert the new device into the list.

Signed-off-by: Miao Xie 
Signed-off-by: Josef Bacik

Btrfs: convert printk to btrfs_ and fix BTRFS prefix

2014-01-28T21:20:05+00:00

Convert all applicable cases of printk and pr_* to the btrfs_* macros.

Fix all uses of the BTRFS prefix.

Signed-off-by: Frank Holton 
Signed-off-by: Josef Bacik 
Signed-off-by: Chris Mason

btrfs: fix typo in the log message

2013-11-21T01:44:47+00:00

Signed-off-by: Anand Jain 
Signed-off-by: Josef Bacik 
Signed-off-by: Chris Mason

Btrfs: rename btrfs_start_all_delalloc_inodes

2013-11-12T03:13:58+00:00

rename the function -- btrfs_start_all_delalloc_inodes(), and make its
name be compatible to btrfs_wait_ordered_roots(), since they are always
used at the same place.

Signed-off-by: Miao Xie 
Signed-off-by: Josef Bacik 
Signed-off-by: Chris Mason

Btrfs: don't wait for the completion of all the ordered extents

2013-11-12T03:13:44+00:00

It is very likely that there are lots of ordered extents in the filesytem,
if we wait for the completion of all of them when we want to reclaim some
space for the metadata space reservation, we would be blocked for a long
time. The performance would drop down suddenly for a long time.

Signed-off-by: Miao Xie 
Signed-off-by: Josef Bacik 
Signed-off-by: Chris Mason

btrfs: remove fs/btrfs/compat.h

2013-11-12T03:03:19+00:00

fs/btrfs/compat.h only contained trivial macro wrappers of drop_nlink()
and inc_nlink().  This doesn't belong in mainline.

Signed-off-by: Zach Brown 
Signed-off-by: Josef Bacik 
Signed-off-by: Chris Mason

btrfs: use get_seconds() instead of btrfs wrapper

2013-11-12T03:03:00+00:00

Signed-off-by: Zach Brown 
Signed-off-by: Josef Bacik 
Signed-off-by: Chris Mason

Btrfs: disallow 'btrfs {balance,replace} cancel' on ro mounts

2013-11-12T03:00:50+00:00

For both balance and replace, cancelling involves changing the on-disk
state and committing a transaction, which is not a good thing to do on
read-only filesystems.

Cc: Stefan Behrens 
Signed-off-by: Ilya Dryomov 
Signed-off-by: Josef Bacik 
Signed-off-by: Chris Mason