linux-toradex.git/fs/btrfs/dir-item.c, branch v5.15

btrfs: unify lookup return value when dir entry is missing

2021-10-07T20:06:32+00:00

btrfs_lookup_dir_index_item() and btrfs_lookup_dir_item() lookup for dir
entries and both are used during log replay or when updating a log tree
during an unlink.

However when the dir item does not exists, btrfs_lookup_dir_item() returns
NULL while btrfs_lookup_dir_index_item() returns PTR_ERR(-ENOENT), and if
the dir item exists but there is no matching entry for a given name or
index, both return NULL. This makes the call sites during log replay to
be more verbose than necessary and it makes it easy to miss this slight
difference. Since we don't need to distinguish between those two cases,
make btrfs_lookup_dir_index_item() always return NULL when there is no
matching directory entry - either because there isn't any dir entry or
because there is one but it does not match the given name and index.

Also rename the argument 'objectid' of btrfs_lookup_dir_index_item() to
'index' since it is supposed to match an index number, and the name
'objectid' is not very good because it can easily be confused with an
inode number (like the inode number a dir entry points to).

CC: stable@vger.kernel.org # 4.14+
Signed-off-by: Filipe Manana 
Reviewed-by: David Sterba 
Signed-off-by: David Sterba

btrfs: introduce btrfs_lookup_match_dir

2021-08-23T11:19:02+00:00

btrfs_search_slot is called in multiple places in dir-item.c to search
for a dir entry, and then calling btrfs_match_dir_name to return a
btrfs_dir_item.

In order to reduce the number of callers of btrfs_search_slot, create a
common function that looks for the dir key, and if found call
btrfs_match_dir_item_name.

Signed-off-by: Marcos Paulo de Souza 
Reviewed-by: David Sterba 
Signed-off-by: David Sterba

btrfs: locking: rip out path->leave_spinning

2020-12-08T14:54:02+00:00

We no longer distinguish between blocking and spinning, so rip out all
this code.

Signed-off-by: Josef Bacik 
Reviewed-by: David Sterba 
Signed-off-by: David Sterba

btrfs: remove unused parameter fs_info from btrfs_extend_item

2019-04-29T17:02:50+00:00

Signed-off-by: David Sterba

btrfs: remove unused parameter fs_info from btrfs_truncate_item

2019-04-29T17:02:50+00:00

Signed-off-by: David Sterba

btrfs: Remove root parameter from btrfs_insert_dir_item

2018-10-15T15:23:25+00:00

All callers pass the root tree of dir, we can push that down to the
function itself.

Signed-off-by: Lu Fengqi 
Reviewed-by: David Sterba 
Signed-off-by: David Sterba

btrfs: Remove fs_info from btrfs_insert_delayed_dir_index

2018-08-06T11:13:00+00:00

It can be referenced from the passed transaction handle.

Signed-off-by: Lu Fengqi 
Signed-off-by: David Sterba

btrfs: replace GPL boilerplate by SPDX -- sources

2018-04-12T14:29:51+00:00

Remove GPL boilerplate text (long, short, one-line) and keep the rest,
ie. personal, company or original source copyright statements. Add the
SPDX header.

Signed-off-by: David Sterba

btrfs: Remove custom crc32c init code

2018-03-26T13:09:39+00:00

The custom crc32 init code was introduced in
14a958e678cd ("Btrfs: fix btrfs boot when compiled as built-in") to
enable using btrfs as a built-in. However, later as pointed out by
60efa5eb2e88 ("Btrfs: use late_initcall instead of module_init") this
wasn't enough and finally btrfs was switched to late_initcall which
comes after the generic crc32c implementation is initiliased. The
latter commit superseeded the former. Now that we don't have to
maintain our own code let's just remove it and switch to using the
generic implementation.

Despite touching a lot of files the patch is really simple. Here is the gist of
the changes:

1. Select LIBCRC32C rather than the low-level modules.
2. s/btrfs_crc32c/crc32c/g
3. replace hash.h with linux/crc32c.h
4. Move the btrfs namehash funcs to ctree.h and change the tree accordingly.

I've tested this with btrfs being both a module and a built-in and xfstest
doesn't complain.

Does seem to fix the longstanding problem of not automatically selectiong
the crc32c module when btrfs is used. Possibly there is a workaround in
dracut.

The modinfo confirms that now all the module dependencies are there:

before:
depends:        zstd_compress,zstd_decompress,raid6_pq,xor,zlib_deflate

after:
depends:        libcrc32c,zstd_compress,zstd_decompress,raid6_pq,xor,zlib_deflate

Signed-off-by: Nikolay Borisov 
Reviewed-by: David Sterba 
[ add more info to changelog from mails ]
Signed-off-by: David Sterba

btrfs: Cleanup existing name_len checks

2018-01-22T15:08:12+00:00

Since tree-checker has verified leaf when reading from disk, we don't
need the existing verify_dir_item() or btrfs_is_name_len_valid() checks.

Signed-off-by: Qu Wenruo 
Reviewed-by: Nikolay Borisov 
Reviewed-by: David Sterba 
Signed-off-by: David Sterba