linux-toradex.git/fs/btrfs/extent-tree.c, branch v4.9.21

btrfs: fix error handling when run_delayed_extent_op fails

2017-01-19T19:18:05+00:00

commit aa7c8da35d1905d80e840d075f07d26ec90144b5 upstream.

In __btrfs_run_delayed_refs, the error path when run_delayed_extent_op
fails sets locked_ref->processing = 0 but doesn't re-increment
delayed_refs->num_heads_ready.  As a result, we end up triggering
the WARN_ON in btrfs_select_ref_head.

Fixes: d7df2c796d7 (Btrfs: attach delayed ref updates to delayed ref heads)
Reported-by: Jon Nelson 
Signed-off-by: Jeff Mahoney 
Reviewed-by: Liu Bo 
Signed-off-by: David Sterba 
Signed-off-by: Greg Kroah-Hartman

btrfs: fix locking when we put back a delayed ref that's too new

2017-01-19T19:18:05+00:00

commit d0280996437081dd12ed1e982ac8aeaa62835ec4 upstream.

In __btrfs_run_delayed_refs, when we put back a delayed ref that's too
new, we have already dropped the lock on locked_ref when we set
->processing = 0.

This patch keeps the lock to cover that assignment.

Fixes: d7df2c796d7 (Btrfs: attach delayed ref updates to delayed ref heads)
Signed-off-by: Jeff Mahoney 
Reviewed-by: Liu Bo 
Signed-off-by: David Sterba 
Signed-off-by: Greg Kroah-Hartman

btrfs: fix WARNING in btrfs_select_ref_head()

2016-10-24T16:20:29+00:00

This issue was found when testing in-band dedupe enospc behaviour,
sometimes run_one_delayed_ref() may fail for enospc reason, then
__btrfs_run_delayed_refs（）will return, but forget to add num_heads_read
back, which will trigger "WARN_ON(delayed_refs->num_heads_ready == 0)" in
btrfs_select_ref_head().

Signed-off-by: Wang Xiaoguang 
Signed-off-by: David Sterba

Revert "btrfs: let btrfs_delete_unused_bgs() to clean relocated bgs"

2016-10-10T20:43:31+00:00

This reverts commit 5d8eb6fe517583f9c6d5b94faf2254a0207a45c9.

When we remove devices, we free the device structures.  Delaying
btfs_remove_chunk() ends up hitting a use-after-free on them.

Signed-off-by: Chris Mason

Btrfs: don't BUG() during drop snapshot

2016-09-26T17:37:06+00:00

Really there's lots of things that can go wrong here, kill all the
BUG_ON()'s and replace the logic ones with ASSERT()'s and return EIO
instead.

Signed-off-by: Josef Bacik 
[ switched to btrfs_err, errors go to common label ]
Reviewed-by: Liu Bo 
Signed-off-by: David Sterba

btrfs: Remove already completed TODO comment

2016-09-26T17:37:06+00:00

Fixes: 7cf5b97650f2 ("btrfs: qgroup: Cleanup old inaccurate facilities")
Signed-off-by: Goldwyn Rodrigues 
Signed-off-by: David Sterba

btrfs: Do not reassign count in btrfs_run_delayed_refs

2016-09-26T17:37:06+00:00

Code cleanup. count is already (unsgined long)-1. That is the reason
run_all was set. Do not reassign it (unsigned long)-1.

Signed-off-by: Goldwyn Rodrigues 
Reviewed-by: David Sterba 
Signed-off-by: David Sterba

Btrfs: fix memory leak in do_walk_down

2016-09-26T17:37:06+00:00

The extent buffer 'next' needs to be free'd conditionally.

Signed-off-by: Liu Bo 
Reviewed-by: David Sterba 
Signed-off-by: David Sterba

btrfs: convert pr_* to btrfs_* where possible

2016-09-26T17:37:04+00:00

For many printks, we want to know which file system issued the message.

This patch converts most pr_* calls to use the btrfs_* versions instead.
In some cases, this means adding plumbing to allow call sites access to
an fs_info pointer.

fs/btrfs/check-integrity.c is left alone for another day.

Signed-off-by: Jeff Mahoney 
Reviewed-by: David Sterba 
Signed-off-by: David Sterba

btrfs: convert printk(KERN_* to use pr_* calls

2016-09-26T16:08:44+00:00

This patch converts printk(KERN_* style messages to use the pr_* versions.

One side effect is that anything that was KERN_DEBUG is now automatically
a dynamic debug message.

Signed-off-by: Jeff Mahoney 
Signed-off-by: David Sterba