linux-toradex.git/fs/btrfs/inode.c, branch v2.6.32.26

Btrfs: apply updated fallocate i_size fix

2010-08-13T20:20:12+00:00

commit 23b5c50945f2294add0137799400329c0ebba290 upstream.

This version of the i_size fix for fallocate makes sure we only update
the i_size when the current fallocate is really operating outside of
i_size.

Signed-off-by: Chris Mason 
Acked-by: Jeff Mahoney 
Signed-off-by: Greg Kroah-Hartman

Btrfs: do not try and lookup the file extent when finishing ordered io

2010-08-13T20:20:11+00:00

commit efd049fb26a162c3830fd3cb1001fdc09b147f3b upstream.

When running the following fio job

[torrent]
filename=torrent-test
rw=randwrite
size=4g
filesize=4g
bs=4k
ioengine=sync

you would see long stalls where no work was being done.  That is because we were
doing all this extra work to read in the file extent outside of the transaction,
however in the random io case this ends up hurting us because the file extents
are not there to begin with.  So axe this logic, since we end up reading in the
file extent when we go to update it anyway.  This took the fio job from 11 mb/s
with several ~10 second stalls to 24 mb/s to a couple of 1-2 second stalls.

Signed-off-by: Josef Bacik 
Signed-off-by: Chris Mason 
Acked-by: Jeff Mahoney 
Signed-off-by: Greg Kroah-Hartman

Btrfs: run orphan cleanup on default fs root

2010-08-13T20:20:07+00:00

commit e3acc2a6850efff647f1c5458524eb3a8bcba20a upstream.

This patch revert's commit

6c090a11e1c403b727a6a8eff0b97d5fb9e95cb5

Since it introduces this problem where we can run orphan cleanup on a
volume that can have orphan entries re-added.  Instead of my original
fix, Yan Zheng pointed out that we can just revert my original fix and
then run the orphan cleanup in open_ctree after we look up the fs_root.
I have tested this with all the tests that gave me problems and this
patch fixes both problems.  Thanks,

Signed-off-by: Josef Bacik 
Signed-off-by: Chris Mason 
Acked-by: Jeff Mahoney 
Signed-off-by: Greg Kroah-Hartman

Btrfs: Use correct values when updating inode i_size on fallocate

2010-08-13T20:20:05+00:00

commit d1ea6a61454e7d7ff0873d0ad1ae27d5807da0d3 upstream.

commit f2bc9dd07e3424c4ec5f3949961fe053d47bc825
Author: Aneesh Kumar K.V 
Date:   Wed Jan 20 12:57:53 2010 +0530

    Btrfs: Use correct values when updating inode i_size on fallocate

    Even though we allocate more, we should be updating inode i_size
    as per the arguments passed

    Signed-off-by: Aneesh Kumar K.V 

Signed-off-by: Chris Mason 
Acked-by: Jeff Mahoney 
Signed-off-by: Greg Kroah-Hartman

Btrfs: fix regression in orphan cleanup

2010-08-13T20:20:04+00:00

commit 6c090a11e1c403b727a6a8eff0b97d5fb9e95cb5 upstream.

Currently orphan cleanup only ever gets triggered if we cross subvolumes during
a lookup, which means that if we just mount a plain jane fs that has orphans in
it, they will never get cleaned up.  This results in panic's like these

http://www.kerneloops.org/oops.php?number=1109085

where adding an orphan entry results in -EEXIST being returned and we panic.  In
order to fix this, we check to see on lookup if our root has had the orphan
cleanup done, and if not go ahead and do it.  This is easily reproduceable by
running this testcase

#include 
#include 
#include 
#include 
#include 
#include 

int main(int argc, char **argv)
{
	char data[4096];
	char newdata[4096];
	int fd1, fd2;

	memset(data, 'a', 4096);
	memset(newdata, 'b', 4096);

	while (1) {
		int i;

		fd1 = creat("file1", 0666);
		if (fd1 < 0)
			break;

		for (i = 0; i < 512; i++)
			write(fd1, data, 4096);

		fsync(fd1);
		close(fd1);

		fd2 = creat("file2", 0666);
		if (fd2 < 0)
			break;

		ftruncate(fd2, 4096 * 512);

		for (i = 0; i < 512; i++)
			write(fd2, newdata, 4096);
		close(fd2);

		i = rename("file2", "file1");
		unlink("file1");
	}

	return 0;
}

and then pulling the power on the box, and then trying to run that test again
when the box comes back up.  I've tested this locally and it fixes the problem.
Thanks to Tomas Carnecky for helping me track this down initially.

Signed-off-by: Josef Bacik 
Signed-off-by: Chris Mason 
Acked-by: Jeff Mahoney 
Signed-off-by: Greg Kroah-Hartman

btrfs: fix missing last-entry in readdir(3)

2010-08-13T20:20:01+00:00

commit 406266ab9ac8ed8b085c58aacd9e3161480dc5d5 upstream.

parent 49313cdac7b34c9f7ecbb1780cfc648b1c082cd7 (v2.6.32-1-g49313cd)
commit ff48c08e1c05c67e8348ab6f8a24de8034e0e34d
Author: Jan Engelhardt 
Date:   Wed Dec 9 22:57:36 2009 +0100

Btrfs: fix missing last-entry in readdir(3)

When one does a 32-bit readdir(3), the last entry of a directory is
missing. This is however not due to passing a large value to filldir,
but it seems to have to do with glibc doing telldir or something
quirky. In any case, this patch fixes it in practice.

Signed-off-by: Jan Engelhardt 
Signed-off-by: Chris Mason 
Acked-by: Jeff Mahoney 
Signed-off-by: Greg Kroah-Hartman

Btrfs: make sure fallocate properly starts a transaction

2010-08-13T20:20:00+00:00

commit 3a1abec9f6880cf406593c392636199ea1c6c917 upstream.

The recent patch to make fallocate enospc friendly would send
down a NULL trans handle to the allocator.  This moves the
transaction start to properly fix things.

Signed-off-by: Chris Mason 
Acked-by: Jeff Mahoney 
Signed-off-by: Greg Kroah-Hartman

Btrfs: deny sys_link across subvolumes.

2010-08-13T20:19:59+00:00

commit 4a8be425a8fb8fbb5d881eb55fa6634c3463b9c9 upstream.

I rebased Christian Parpart's patch to deny hard link across
subvolumes. Original patch modifies also btrfs_rename, but
I excluded it because we can move across subvolumes now and
it make no problem.
-----------------

Hard link across subvolumes should not allowed in Btrfs.
btrfs_link checks root of 'to' directory is same as root
of 'from' file. If not same, btrfs_link returns -EPERM.

Signed-off-by: TARUISI Hiroaki 
Signed-off-by: Chris Mason 
Acked-by: Jeff Mahoney 
Signed-off-by: Greg Kroah-Hartman

Btrfs: Add delayed iput

2010-08-13T20:19:57+00:00

commit 24bbcf0442ee04660a5a030efdbb6d03f1c275cb upstream.

iput() can trigger new transactions if we are dropping the
final reference, so calling it in btrfs_commit_transaction
may end up deadlock. This patch adds delayed iput to avoid
the issue.

Signed-off-by: Yan Zheng 
Signed-off-by: Chris Mason 
Acked-by: Jeff Mahoney 
Signed-off-by: Greg Kroah-Hartman

Btrfs: Pass transaction handle to security and ACL initialization functions

2010-08-13T20:19:56+00:00

commit f34f57a3ab4e73304d78c125682f1a53cd3975f2 upstream.

Pass transaction handle down to security and ACL initialization
functions, so we can avoid starting nested transactions

Signed-off-by: Yan Zheng 
Signed-off-by: Chris Mason 
Acked-by: Jeff Mahoney 
Signed-off-by: Greg Kroah-Hartman