linux-toradex.git/fs/btrfs/relocation.c, branch v3.14.2

Btrfs: fix an oops when we fail to relocate tree blocks

2014-01-28T21:20:14+00:00

During balance test, we hit an oops:
[ 2013.841551] kernel BUG at fs/btrfs/relocation.c:1174!

The problem is that if we fail to relocate tree blocks, we should
update backref cache, otherwise, some pending nodes are not updated
while snapshot check @cache->last_trans is within one transaction
and won't update it and then oops happen.

Signed-off-by: Wang Shilong 
Signed-off-by: Josef Bacik 
Signed-off-by: Chris Mason

Btrfs: fix an oops when we fail to merge reloc roots

2014-01-28T21:20:13+00:00

Previously, we will free reloc root memory and then force filesystem
to be readonly. The problem is that there may be another thread commiting
transaction which will try to access freed reloc root during merging reloc
roots process.

To keep consistency snapshots shared space, we should allow snapshot
finished if possible, so here we don't free reloc root memory.

signed-off-by: Wang Shilong 

Signed-off-by: Josef Bacik 
Signed-off-by: Chris Mason

Btrfs: remove unused argument from select_reloc_root()

2014-01-28T21:20:12+00:00

@nr is no longer used, remove it from select_reloc_root()

Signed-off-by: Wang Shilong 
Signed-off-by: Josef Bacik 
Signed-off-by: Chris Mason

Btrfs: convert printk to btrfs_ and fix BTRFS prefix

2014-01-28T21:20:05+00:00

Convert all applicable cases of printk and pr_* to the btrfs_* macros.

Fix all uses of the BTRFS prefix.

Signed-off-by: Frank Holton 
Signed-off-by: Josef Bacik 
Signed-off-by: Chris Mason

Btrfs: remove unnecessary filemap writting and waiting after block group relocation

2014-01-28T21:19:57+00:00

We have commited transaction before, remove redundant filemap writting and
waiting here, it can speed up balance relocation process.

Signed-off-by: Wang Shilong 
Signed-off-by: Josef Bacik 
Signed-off-by: Chris Mason

Btrfs: improve forever loop when doing balance relocation

2014-01-28T21:19:43+00:00

We hit a forever loop when doing balance relocation,the reason
is that we firstly reserve 4M(node size is 16k).and within transaction
we will try to add extra reservation for snapshot roots,this will
return -EAGAIN if there has been a thread flushing space to reserve
space.We will do this again and again with filesystem becoming nearly
full.

If the above '-EAGAIN' case happens, we try to refill reservation more
outsize of transaction, and this will return eariler in enospc case,however,
this dosen't really hurt because it makes no sense doing balance relocation
with the filesystem nearly full.

Miao Xie helped a lot to track this issue, thanks.

Signed-off-by: Wang Shilong 
Signed-off-by: Miao Xie 
Signed-off-by: Josef Bacik 
Signed-off-by: Chris Mason

Btrfs: make sure we cleanup all reloc roots if error happens

2013-12-12T15:12:51+00:00

I hit an oops when merging reloc roots fails, the reason is that
new reloc roots may be added and we should make sure we cleanup
all reloc roots.

Signed-off-by: Wang Shilong 
Signed-off-by: Chris Mason

Btrfs: skip building backref tree for uuid and quota tree when doing balance relocation

2013-12-12T15:12:36+00:00

Quota tree and UUID Tree is only cowed, they can not be snapshoted.

Signed-off-by: Wang Shilong 
Signed-off-by: Chris Mason

Btrfs: fix an oops when doing balance relocation

2013-12-12T15:12:20+00:00

I hit an oops when inserting reloc root into @reloc_root_tree(it can be
easily triggered when forcing cow for relocation root)

[  866.494539]  [] btrfs_init_reloc_root+0x79/0xb0 [btrfs]
[  866.495321]  [] record_root_in_trans+0xb0/0x110 [btrfs]
[  866.496109]  [] btrfs_record_root_in_trans+0x48/0x80 [btrfs]
[  866.496908]  [] select_reloc_root+0xa8/0x210 [btrfs]
[  866.497703]  [] do_relocation+0x16a/0x540 [btrfs]

This is because reloc root inserted into @reloc_root_tree is not within one
transaction,reloc root may be cowed and root block bytenr will be reused then
oops happens.We should update reloc root in @reloc_root_tree when cow reloc
root node, fix it.

Signed-off-by: Wang Shilong 
Reviewed-by: Miao Xie 
Signed-off-by: Chris Mason

Btrfs: rename btrfs_start_all_delalloc_inodes

2013-11-12T03:13:58+00:00

rename the function -- btrfs_start_all_delalloc_inodes(), and make its
name be compatible to btrfs_wait_ordered_roots(), since they are always
used at the same place.

Signed-off-by: Miao Xie 
Signed-off-by: Josef Bacik 
Signed-off-by: Chris Mason