linux-toradex.git/fs/ceph/addr.c, branch v3.2.55 Linux kernel for Apalis and Colibri modules ceph: use i_ceph_lock instead of i_lock 2011-12-07T18:46:44+00:00 Sage Weil sage@newdream.net 2011-11-30T17:47:09+00:00 be655596b3de5873f994ddbe205751a5ffb4de39 We have been using i_lock to protect all kinds of data structures in the ceph_inode_info struct, including lists of inodes that we need to iterate over while avoiding races with inode destruction. That requires grabbing a reference to the inode with the list lock protected, but igrab() now takes i_lock to check the inode flags. Changing the list lock ordering would be a painful process. However, using a ceph-specific i_ceph_lock in the ceph inode instead of i_lock is a simple mechanical change and avoids the ordering constraints imposed by igrab(). Reported-by: Amon Ott <a.ott@m-privacy.de> Signed-off-by: Sage Weil <sage@newdream.net> 
We have been using i_lock to protect all kinds of data structures in the
ceph_inode_info struct, including lists of inodes that we need to iterate
over while avoiding races with inode destruction.  That requires grabbing
a reference to the inode with the list lock protected, but igrab() now
takes i_lock to check the inode flags.

Changing the list lock ordering would be a painful process.

However, using a ceph-specific i_ceph_lock in the ceph inode instead of
i_lock is a simple mechanical change and avoids the ordering constraints
imposed by igrab().

Reported-by: Amon Ott <a.ott@m-privacy.de>
Signed-off-by: Sage Weil <sage@newdream.net>
libceph: fix double-free of page vector 2011-10-25T23:10:17+00:00 Sage Weil sage@newdream.net 2011-10-24T16:05:47+00:00 339573406737461cfb17bebabf7ba536a302d841 ceph_release_page_vector() kfrees the vector; we shouldn't do it here too. Reported-by: Jeff Wu <cpwu@tnsoft.com.cn> Signed-off-by: Sage Weil <sage@newdream.net> 
ceph_release_page_vector() kfrees the vector; we shouldn't do it here too.

Reported-by: Jeff Wu <cpwu@tnsoft.com.cn>
Signed-off-by: Sage Weil <sage@newdream.net>
ceph: implement (optional) max read size 2011-10-25T23:10:15+00:00 Sage Weil sage@newdream.net 2011-08-04T15:21:30+00:00 0d66a487c120012f33fbcd6af5cbf0a0cad71557 The 'rsize' mount option limits the maximum size of an individual read(ahead) operation that is sent off to an OSD. This is distinct from 'rasize', which controls the size of the readahead window. Signed-off-by: Sage Weil <sage@newdream.net> 
The 'rsize' mount option limits the maximum size of an individual
read(ahead) operation that is sent off to an OSD.  This is distinct from
'rasize', which controls the size of the readahead window.

Signed-off-by: Sage Weil <sage@newdream.net>
ceph: make readpages fully async 2011-10-25T23:10:14+00:00 Sage Weil sage@newdream.net 2011-08-03T16:58:09+00:00 7c272194e66e91830b90f6202e61c69f8590f1eb When we get a ->readpages() aop, submit async reads for all page ranges in the provided page list. Lock the pages immediately, so that VFS/MM will block until the reads complete. Signed-off-by: Sage Weil <sage@newdream.net> 
When we get a ->readpages() aop, submit async reads for all page ranges
in the provided page list.  Lock the pages immediately, so that VFS/MM
will block until the reads complete.

Signed-off-by: Sage Weil <sage@newdream.net>
ceph: use ihold when we already have an inode ref 2011-06-08T04:34:11+00:00 Sage Weil sage@newdream.net 2011-05-27T16:24:26+00:00 70b666c3b4cb2b96098d80e6f515e4bc6d37db5a We should use ihold whenever we already have a stable inode ref, even when we aren't holding i_lock. This avoids adding new and unnecessary locking dependencies. Signed-off-by: Sage Weil <sage@newdream.net> 
We should use ihold whenever we already have a stable inode ref, even
when we aren't holding i_lock.  This avoids adding new and unnecessary
locking dependencies.

Signed-off-by: Sage Weil <sage@newdream.net>
ceph: check return value for start_request in writepages 2011-05-19T18:25:05+00:00 Sage Weil sage@newdream.net 2011-05-12T22:48:16+00:00 9d6fcb081a4770c3772c51c59c7251c22716d7bb Since we pass the nofail arg, we should never get an error; BUG if we do. (And fix the function to not return an error if __map_request fails.) Signed-off-by: Sage Weil <sage@newdream.net> 
Since we pass the nofail arg, we should never get an error; BUG if we do.
(And fix the function to not return an error if __map_request fails.)

Signed-off-by: Sage Weil <sage@newdream.net>
ceph: remove useless check 2011-05-19T18:25:05+00:00 Sage Weil sage@newdream.net 2011-05-12T22:43:48+00:00 6b4a3b517a767c483d16a200730b2967e0e23b83 rc is only ever 0 or negative in this method. Signed-off-by: Sage Weil <sage@newdream.net> 
rc is only ever 0 or negative in this method.

Signed-off-by: Sage Weil <sage@newdream.net>
ceph: handle ceph_osdc_new_request failure in ceph_writepages_start 2011-05-03T16:28:12+00:00 Henry C Chang henry.cy.chang@gmail.com 2011-05-03T09:45:16+00:00 8c71897be2ddfd84969412635ca42fa9e137f7b6 We should unlock the page and return -ENOMEM if ceph_osdc_new_request failed. Signed-off-by: Henry C Chang <henry_c_chang@tcloudcomputing.com> Signed-off-by: Sage Weil <sage@newdream.net> 
We should unlock the page and return -ENOMEM if ceph_osdc_new_request
failed.

Signed-off-by: Henry C Chang <henry_c_chang@tcloudcomputing.com>
Signed-off-by: Sage Weil <sage@newdream.net>
Fix common misspellings 2011-03-31T14:26:23+00:00 Lucas De Marchi lucas.demarchi@profusion.mobi 2011-03-31T01:57:33+00:00 25985edcedea6396277003854657b5f3cb31a628 Fixes generated by 'codespell' and manually reviewed. Signed-off-by: Lucas De Marchi <lucas.demarchi@profusion.mobi> 
Fixes generated by 'codespell' and manually reviewed.

Signed-off-by: Lucas De Marchi <lucas.demarchi@profusion.mobi>
fs: don't use igrab() while holding i_lock 2011-03-29T14:50:34+00:00 Dave Chinner dchinner@redhat.com 2011-03-29T07:08:50+00:00 0444d76ae64fffc7851797fc1b6ebdbb44ac504a Fix the incorrect use of igrab() inside the i_lock in NFS and Ceph‥ If we are already holding the i_lock, we have a reference to the inode so we can safely use ihold() to gain an extra reference. This avoids hangs due to lock recursion on the i_lock now that the inode_lock is gone and igrab() uses the i_lock itself. Signed-off-by: Dave Chinner <dchinner@redhat.com> Cc: Al Viro <viro@zeniv.linux.org.uk> Cc: linux-fsdevel@vger.kernel.org Cc: Ryan Mallon <ryan@bluewatersys.com> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org> 
Fix the incorrect use of igrab() inside the i_lock in NFS and Ceph‥

If we are already holding the i_lock, we have a reference to the
inode so we can safely use ihold() to gain an extra reference. This
avoids hangs due to lock recursion on the i_lock now that the
inode_lock is gone and igrab() uses the i_lock itself.

Signed-off-by: Dave Chinner <dchinner@redhat.com>
Cc: Al Viro <viro@zeniv.linux.org.uk>
Cc: linux-fsdevel@vger.kernel.org
Cc: Ryan Mallon <ryan@bluewatersys.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>