linux-toradex.git/fs/ceph/dir.c, branch v3.16.2

ceph: clear directory's completeness when creating file

2014-04-28T19:54:44+00:00

When creating a file, ceph_set_dentry_offset() puts the new dentry
at the end of directory's d_subdirs, then set the dentry's offset
based on directory's max offset. The offset does not reflect the
real postion of the dentry in directory. Later readdir reply from
MDS may change the dentry's position/offset. This inconsistency
can cause missing/duplicate entries in readdir result if readdir
is partly satisfied by dcache_readdir().

The fix is clear directory's completeness after creating/renaming
file. It prevents later readdir from using dcache_readdir().

Fixes: http://tracker.ceph.com/issues/8025
Signed-off-by: Yan, Zheng 
Reviewed-by: Sage Weil

ceph: use fpos_cmp() to compare dentry positions

2014-04-28T19:53:52+00:00

Signed-off-by: Yan, Zheng 
Reviewed-by: Sage Weil

ceph: check directory's completeness before emitting directory entry

2014-04-28T19:53:43+00:00

Signed-off-by: Yan, Zheng 
Reviewed-by: Sage Weil

ceph: skip invalid dentry during dcache readdir

2014-04-06T16:13:14+00:00

skip dentries that were added before MDS issued FILE_SHARED to
client.

Signed-off-by: Yan, Zheng 
Reviewed-by: Sage Weil

ceph: preallocate buffer for readdir reply

2014-04-05T04:08:22+00:00

Preallocate buffer for readdir reply. Limit number of entries in
readdir reply according to the buffer size.

Signed-off-by: Yan, Zheng

ceph: do not set r_old_dentry_dir on link()

2014-04-03T02:33:53+00:00

This is racy--we do not know whather d_parent has changed out from
underneath us because i_mutex is not held on the source inode's directory.

Also, taking this reference is useless.

Reported-by: Al Viro 
Signed-off-by: Sage Weil 
Reviewed-by: Yan, Zheng

ceph: avoid useless ceph_get_dentry_parent_inode() in ceph_rename()

2014-04-03T02:33:52+00:00

This is just old_dir; no reason to abuse the dcache pointers.

Reported-by: Al Viro 
Signed-off-by: Sage Weil 
Reviewed-by: Yan, Zheng

ceph: let MDS adjust readdir 'frag'

2014-04-03T02:33:52+00:00

If readdir 'frag' is adjusted, readdir 'offset' should be reset.
Otherwise some dentries may be lost when readdir and fragmenting
directory happen at the some.

Another way to fix this issue is let MDS adjust readdir 'frag'.
The code that handles MDS reply reset the readdir 'offset' if
the readdir reply is different than the requested one.

Signed-off-by: Yan, Zheng

ceph: fix reset_readdir()

2014-04-03T02:33:52+00:00

When changing readdir postion, fi->next_offset should be set to 0
if the new postion is not in the first dirfrag.

Signed-off-by: Yan, Zheng 
Reviewed-by: Alex Elder

ceph: fix ceph_dir_llseek()

2014-04-03T02:33:52+00:00

Comparing offset with inode->i_sb->s_maxbytes doesn't make sense for
directory. For a fragmented directory, offset (frag_t, off) can be
larger than inode->i_sb->s_maxbytes.

At the very beginning of ceph_dir_llseek(), local variable old_offset
is initialized to parameter offset. This doesn't make sense neither.
Old_offset should be ceph_make_fpos(fi->frag, fi->next_offset).

Signed-off-by: Yan, Zheng 
Reviewed-by: Alex Elder