linux-toradex.git/fs/ceph/ioctl.c, branch v3.7.2

ceph: return EIO on invalid layout on GET_DATALOC ioctl

2012-10-03T15:51:17+00:00

If the user calls GET_DATALOC on a file with an invalid (e.g.,
zeroed) layout, return EIO to userland.

Signed-off-by: Sage Weil 
Reviewed-by: Alex Elder

ceph: avoid divide by zero in __validate_layout()

2012-08-21T22:55:28+00:00

If "l->stripe_unit" is zero the the mod on the next line will cause a
divide by zero bug.  This comes from the copy_from_user() in
ceph_ioctl_set_layout_policy().  Passing 0 is valid, though (it means
"do not change") so avoid the % check in that case.

Reported-by: Dan Carpenter 
Signed-off-by: Sage Weil 
Reviewed-by: Alex Elder

ceph: ignore preferred_osd field

2012-05-16T19:28:28+00:00

Old users may not expect EINVAL, and there is no clear user-visibile
behavior change now that we ignore it.

Signed-off-by: Sage Weil 
Reviewed-by: Alex Elder

ceph: fully initialize new layout

2012-05-16T19:28:27+00:00

When we are setting a new layout, fully initialize the structure:
 - zero it out
 - always set preferred_osd to -1

Signed-off-by: Sage Weil 
Reviewed-by: Alex Elder

ceph: refactor SETLAYOUT and SETDIRLAYOUT ioctl checks into common helper

2012-05-07T22:34:35+00:00

Both of these methods perform similar checks; move that code to a helper
so that we can ensure the checks are consistent.

Reviewed-by: Alex Elder 
Signed-off-by: Sage Weil

ceph: drop support for preferred_osd pgs

2012-05-07T22:33:36+00:00

This was an ill-conceived feature that has been removed from Ceph.  Do
this gracefully:

 - reject attempts to specify a preferred_osd via the ioctl
 - stop exposing this information via virtual xattrs
 - always fill in -1 for requests, in case we talk to an older server
 - don't calculate preferred_osd placements/pgids

Reviewed-by: Alex Elder 
Signed-off-by: Sage Weil

ceph: use i_ceph_lock instead of i_lock

2011-12-07T18:46:44+00:00

We have been using i_lock to protect all kinds of data structures in the
ceph_inode_info struct, including lists of inodes that we need to iterate
over while avoiding races with inode destruction.  That requires grabbing
a reference to the inode with the list lock protected, but igrab() now
takes i_lock to check the inode flags.

Changing the list lock ordering would be a painful process.

However, using a ceph-specific i_ceph_lock in the ceph inode instead of
i_lock is a simple mechanical change and avoids the ordering constraints
imposed by igrab().

Reported-by: Amon Ott 
Signed-off-by: Sage Weil

ceph: let the set_layout ioctl set single traits

2011-10-25T23:10:16+00:00

Previously we were validating the passed-in stripe unit, object size,
and stripe count against each other (and not testing most other stuff).
Instead, make sure that the composed previous layout and new values are valid,
and only send the new values to the MDS. This lets users change the
pool without setting the whole layout, for instance.

Signed-off-by: Greg Farnum

ceph: protect access to d_parent

2011-07-26T18:30:29+00:00

d_parent is protected by d_lock: use it when looking up a dentry's parent
directory inode.  Also take a reference and drop it in the caller to avoid
a use-after-free.

Reported-by: Al Viro 
Reviewed-by: Yehuda Sadeh 
Signed-off-by: Sage Weil

ceph: add F_SYNC file flag to force sync (non-O_DIRECT) io

2011-07-26T18:26:07+00:00

This allows us to force IO through the sync path which you normally only
get when multiple clients are reading/writing to the same file or by
mounting with -o sync.  Among other things, this lets test programs verify
correctness with a single mount.

Reviewed-by: Yehuda Sadeh 
Signed-off-by: Sage Weil