linux-toradex.git/fs/ceph/mds_client.c, branch v3.13.3 Linux kernel for Apalis and Colibri modules ceph: wake up 'safe' waiters when unregistering request 2013-11-23T19:01:05+00:00 Yan, Zheng zheng.z.yan@intel.com 2013-10-31T01:10:47+00:00 fc55d2c9448b34218ca58733a6f51fbede09575b We also need to wake up 'safe' waiters if error occurs or request aborted. Otherwise sync(2)/fsync(2) may hang forever. Signed-off-by: Yan, Zheng <zheng.z.yan@intel.com> Signed-off-by: Sage Weil <sage@inktank.com> 
We also need to wake up 'safe' waiters if error occurs or request
aborted. Otherwise sync(2)/fsync(2) may hang forever.

Signed-off-by: Yan, Zheng <zheng.z.yan@intel.com>
Signed-off-by: Sage Weil <sage@inktank.com>
ceph: cleanup aborted requests when re-sending requests. 2013-11-23T19:01:04+00:00 Yan, Zheng zheng.z.yan@intel.com 2013-09-26T06:25:36+00:00 eb1b8af33c2e42a9a57fc0a7588f4a7b255d2e79 Aborted requests usually get cleared when the reply is received. If MDS crashes, no reply will be received. So we need to cleanup aborted requests when re-sending requests. Signed-off-by: Yan, Zheng <zheng.z.yan@intel.com> Reviewed-by: Greg Farnum <greg@inktank.com> Signed-off-by: Sage Weil <sage@inktank.com> 
Aborted requests usually get cleared when the reply is received.
If MDS crashes, no reply will be received. So we need to cleanup
aborted requests when re-sending requests.

Signed-off-by: Yan, Zheng <zheng.z.yan@intel.com>
Reviewed-by: Greg Farnum <greg@inktank.com>
Signed-off-by: Sage Weil <sage@inktank.com>
ceph: handle race between cap reconnect and cap release 2013-11-23T19:01:02+00:00 Yan, Zheng zheng.z.yan@intel.com 2013-09-22T03:08:14+00:00 99a9c273b94a087f8feaec6c5ffbe3205a2dbe51 When a cap get released while composing the cap reconnect message. We should skip queuing the release message if the cap hasn't been added to the cap reconnect message. Signed-off-by: Yan, Zheng <zheng.z.yan@intel.com> Reviewed-by: Sage Weil <sage@inktank.com> 
When a cap get released while composing the cap reconnect message.
We should skip queuing the release message if the cap hasn't been
added to the cap reconnect message.

Signed-off-by: Yan, Zheng <zheng.z.yan@intel.com>
Reviewed-by: Sage Weil <sage@inktank.com>
ceph: set caps count after composing cap reconnect message 2013-11-23T19:01:01+00:00 Yan, Zheng zheng.z.yan@intel.com 2013-09-22T02:28:10+00:00 44c99757fae80e9db058e1f1d7419cf6472e9af1 It's possible that some caps get released while composing the cap reconnect message. Signed-off-by: Yan, Zheng <zheng.z.yan@intel.com> Reviewed-by: Sage Weil <sage@inktank.com> 
It's possible that some caps get released while composing the cap
reconnect message.

Signed-off-by: Yan, Zheng <zheng.z.yan@intel.com>
Reviewed-by: Sage Weil <sage@inktank.com>
ceph: queue cap release in __ceph_remove_cap() 2013-11-23T19:00:59+00:00 Yan, Zheng zheng.z.yan@intel.com 2013-09-22T02:15:58+00:00 a096b09aeec6ff99edfdfd8cee24d6f25377d585 call __queue_cap_release() in __ceph_remove_cap(), this avoids acquiring s_cap_lock twice. Signed-off-by: Yan, Zheng <zheng.z.yan@intel.com> Reviewed-by: Sage Weil <sage@inktank.com> 
call __queue_cap_release() in __ceph_remove_cap(), this avoids
acquiring s_cap_lock twice.

Signed-off-by: Yan, Zheng <zheng.z.yan@intel.com>
Reviewed-by: Sage Weil <sage@inktank.com>
ceph: handle frag mismatch between readdir request and reply 2013-09-30T21:49:53+00:00 Yan, Zheng zheng.z.yan@intel.com 2013-09-18T01:44:13+00:00 81c6aea5275eae453719d7f3924da07e668265c5 If client has outdated directory fragments information, it may request readdir an non-existent directory fragment. In this case, the MDS finds an approximate directory fragment and sends its contents back to the client. When receiving a reply with fragment that is different than the requested one, the client need to reset the 'readdir offset'. Signed-off-by: Yan, Zheng <zheng.z.yan@intel.com> Reviewed-by: Sage Weil <sage@inktank.com> 
If client has outdated directory fragments information, it may request
readdir an non-existent directory fragment. In this case, the MDS finds
an approximate directory fragment and sends its contents back to the
client. When receiving a reply with fragment that is different than the
requested one, the client need to reset the 'readdir offset'.

Signed-off-by: Yan, Zheng <zheng.z.yan@intel.com>
Reviewed-by: Sage Weil <sage@inktank.com>
ceph: remove ceph_lookup_inode() 2013-09-06T19:55:09+00:00 Yan, Zheng zheng.z.yan@intel.com 2013-09-02T07:19:53+00:00 ed284c49f61165c3ba1b4e6969d1cc30a769c31b commit 6f60f889 (ceph: fix freeing inode vs removing session caps race) introduced ceph_lookup_inode(). But there is already a ceph_find_inode() which provides similar function. So remove ceph_lookup_inode(), use ceph_find_inode() instead. Signed-off-by: Yan, Zheng <zheng.z.yan@intel.com> Reviewed-by: Alex Elder <alex.elder@linary.org> Reviewed-by: Sage Weil <sage@inktank.com> 
commit 6f60f889 (ceph: fix freeing inode vs removing session caps race)
introduced ceph_lookup_inode(). But there is already a ceph_find_inode()
which provides similar function. So remove ceph_lookup_inode(), use
ceph_find_inode() instead.

Signed-off-by: Yan, Zheng <zheng.z.yan@intel.com>
Reviewed-by: Alex Elder <alex.elder@linary.org>
Reviewed-by: Sage Weil <sage@inktank.com>
Merge remote-tracking branch 'linus/master' into testing 2013-08-15T18:11:45+00:00 Sage Weil sage@inktank.com 2013-08-15T18:11:45+00:00 ee3e542fec6e69bc9fb668698889a37d93950ddf 






ceph: fix freeing inode vs removing session caps race
2013-08-10T00:55:32+00:00

Yan, Zheng
zheng.z.yan@intel.com

2013-07-24T04:22:11+00:00

6f60f889470aecf747610279545c054a99aadca3

remove_session_caps() uses iterate_session_caps() to remove caps,
but iterate_session_caps() skips inodes that are being deleted.
So session->s_nr_caps can be non-zero after iterate_session_caps()
return.

We can fix the issue by waiting until deletions are complete.
__wait_on_freeing_inode() is designed for the job, but it is not
exported, so we use lookup inode function to access it.

Signed-off-by: Yan, Zheng <zheng.z.yan@intel.com>





remove_session_caps() uses iterate_session_caps() to remove caps,
but iterate_session_caps() skips inodes that are being deleted.
So session->s_nr_caps can be non-zero after iterate_session_caps()
return.

We can fix the issue by waiting until deletions are complete.
__wait_on_freeing_inode() is designed for the job, but it is not
exported, so we use lookup inode function to access it.

Signed-off-by: Yan, Zheng <zheng.z.yan@intel.com>







ceph: fix null pointer dereference
2013-08-10T00:52:58+00:00

Nathaniel Yazdani
n1ght.4nd.d4y@gmail.com

2013-08-05T04:04:30+00:00

c338c07c51e3106711fad5eb599e375eadb6855d

When register_session() is given an out-of-range argument for mds,
ceph_mdsmap_get_addr() will return a null pointer, which would be given to
ceph_con_open() & be dereferenced, causing a kernel oops. This fixes bug #4685
in the Ceph bug tracker <http://tracker.ceph.com/issues/4685>.

Signed-off-by: Nathaniel Yazdani <n1ght.4nd.d4y@gmail.com>
Reviewed-by: Sage Weil <sage@inktank.com>





When register_session() is given an out-of-range argument for mds,
ceph_mdsmap_get_addr() will return a null pointer, which would be given to
ceph_con_open() & be dereferenced, causing a kernel oops. This fixes bug #4685
in the Ceph bug tracker <http://tracker.ceph.com/issues/4685>.

Signed-off-by: Nathaniel Yazdani <n1ght.4nd.d4y@gmail.com>
Reviewed-by: Sage Weil <sage@inktank.com>