linux-toradex.git/fs/ceph/quota.c, branch v7.0-rc2

Convert 'alloc_obj' family to use the new default GFP_KERNEL argument

2026-02-22T01:09:51+00:00

This was done entirely with mindless brute force, using

    git grep -l '\

treewide: Replace kmalloc with kmalloc_obj for non-scalar types

2026-02-21T09:02:28+00:00

This is the result of running the Coccinelle script from
scripts/coccinelle/api/kmalloc_objs.cocci. The script is designed to
avoid scalar types (which need careful case-by-case checking), and
instead replace kmalloc-family calls that allocate struct or union
object instances:

Single allocations:	kmalloc(sizeof(TYPE), ...)
are replaced with:	kmalloc_obj(TYPE, ...)

Array allocations:	kmalloc_array(COUNT, sizeof(TYPE), ...)
are replaced with:	kmalloc_objs(TYPE, COUNT, ...)

Flex array allocations:	kmalloc(struct_size(PTR, FAM, COUNT), ...)
are replaced with:	kmalloc_flex(*PTR, FAM, COUNT, ...)

(where TYPE may also be *VAR)

The resulting allocations no longer return "void *", instead returning
"TYPE *".

Signed-off-by: Kees Cook

ceph: convert timeouts to secs_to_jiffies()

2025-01-13T04:21:04+00:00

Commit b35108a51cf7 ("jiffies: Define secs_to_jiffies()") introduced
secs_to_jiffies().  As the value here is a multiple of 1000, use
secs_to_jiffies() instead of msecs_to_jiffies to avoid the multiplication.

This is converted using scripts/coccinelle/misc/secs_to_jiffies.cocci with
the following Coccinelle rules:

@@ constant C; @@

- msecs_to_jiffies(C * 1000)
+ secs_to_jiffies(C)

@@ constant C; @@

- msecs_to_jiffies(C * MSEC_PER_SEC)
+ secs_to_jiffies(C)

Link: https://lkml.kernel.org/r/20241210-converge-secs-to-jiffies-v3-17-ddfefd7e9f2a@linux.microsoft.com
Signed-off-by: Easwar Hariharan 
Cc: Alexander Gordeev 
Cc: Andrew Lunn 
Cc: Anna-Maria Behnsen 
Cc: Catalin Marinas 
Cc: Christian Borntraeger 
Cc: Christophe Leroy 
Cc: Daniel Mack 
Cc: David Airlie 
Cc: David S. Miller 
Cc: Dick Kennedy 
Cc: Eric Dumazet 
Cc: Florian Fainelli 
Cc: Greg Kroah-Hartman 
Cc: Haojian Zhuang 
Cc: Heiko Carstens 
Cc: Ilya Dryomov 
Cc: Jack Wang 
Cc: Jakub Kicinski 
Cc: James Bottomley 
Cc: James Smart 
Cc: Jaroslav Kysela 
Cc: Jeff Johnson 
Cc: Jeff Johnson 
Cc: Jens Axboe 
Cc: Jeroen de Borst 
Cc: Jiri Kosina 
Cc: Joe Lawrence 
Cc: Johan Hedberg 
Cc: Josh Poimboeuf 
Cc: Jozsef Kadlecsik 
Cc: Julia Lawall 
Cc: Kalle Valo 
Cc: Louis Peens 
Cc: Lucas De Marchi 
Cc: Luiz Augusto von Dentz 
Cc: Maarten Lankhorst 
Cc: Madhavan Srinivasan 
Cc: Marcel Holtmann 
Cc: Martin K. Petersen 
Cc: Maxime Ripard 
Cc: Michael Ellerman 
Cc: Miroslav Benes 
Cc: Naveen N Rao 
Cc: Nicholas Piggin 
Cc: Nicolas Palix 
Cc: Oded Gabbay 
Cc: Ofir Bitton 
Cc: Pablo Neira Ayuso 
Cc: Paolo Abeni 
Cc: Petr Mladek 
Cc: Praveen Kaligineedi 
Cc: Ray Jui 
Cc: Robert Jarzmik 
Cc: Rodrigo Vivi 
Cc: Roger Pau Monné 
Cc: Russell King 
Cc: Scott Branden 
Cc: Shailend Chand 
Cc: Simona Vetter 
Cc: Simon Horman 
Cc: Sven Schnelle 
Cc: Takashi Iwai 
Cc: Thomas Hellström 
Cc: Thomas Zimmermann 
Cc: Vasily Gorbik 
Cc: Xiubo Li 
Signed-off-by: Andrew Morton

ceph: fix invalid pointer access if get_quota_realm return ERR_PTR

2024-01-15T14:40:51+00:00

This issue is reported by smatch that get_quota_realm() might return
ERR_PTR but we did not handle it. It's not a immediate bug, while we
still should address it to avoid potential bugs if get_quota_realm()
is changed to return other ERR_PTR in future.

Set ceph_snap_realm's pointer in get_quota_realm()'s to address this
issue, the pointer would be set to NULL if get_quota_realm() failed
to get struct ceph_snap_realm, so no ERR_PTR would happen any more.

[ xiubli: minor code style clean up ]

Signed-off-by: Wenchao Hao 
Reviewed-by: Xiubo Li 
Signed-off-by: Ilya Dryomov

ceph: print cluster fsid and client global_id in all debug logs

2023-11-03T22:28:33+00:00

Multiple CephFS mounts on a host is increasingly common so
disambiguating messages like this is necessary and will make it easier
to debug issues.

At the same this will improve the debug logs to make them easier to
troubleshooting issues, such as print the ino# instead only printing
the memory addresses of the corresponding inodes and print the dentry
names instead of the corresponding memory addresses for the dentry,etc.

Link: https://tracker.ceph.com/issues/61590
Signed-off-by: Xiubo Li 
Reviewed-by: Patrick Donnelly 
Reviewed-by: Milind Changire 
Signed-off-by: Ilya Dryomov

ceph: drop messages from MDS when unmounting

2023-08-24T09:24:36+00:00

When unmounting all the dirty buffers will be flushed and after
the last osd request is finished the last reference of the i_count
will be released. Then it will flush the dirty cap/snap to MDSs,
and the unmounting won't wait the possible acks, which will ihold
the inodes when updating the metadata locally but makes no sense
any more, of this. This will make the evict_inodes() to skip these
inodes.

If encrypt is enabled the kernel generate a warning when removing
the encrypt keys when the skipped inodes still hold the keyring:

WARNING: CPU: 4 PID: 168846 at fs/crypto/keyring.c:242 fscrypt_destroy_keyring+0x7e/0xd0
CPU: 4 PID: 168846 Comm: umount Tainted: G S  6.1.0-rc5-ceph-g72ead199864c #1
Hardware name: Supermicro SYS-5018R-WR/X10SRW-F, BIOS 2.0 12/17/2015
RIP: 0010:fscrypt_destroy_keyring+0x7e/0xd0
RSP: 0018:ffffc9000b277e28 EFLAGS: 00010202
RAX: 0000000000000002 RBX: ffff88810d52ac00 RCX: ffff88810b56aa00
RDX: 0000000080000000 RSI: ffffffff822f3a09 RDI: ffff888108f59000
RBP: ffff8881d394fb88 R08: 0000000000000028 R09: 0000000000000000
R10: 0000000000000001 R11: 11ff4fe6834fcd91 R12: ffff8881d394fc40
R13: ffff888108f59000 R14: ffff8881d394f800 R15: 0000000000000000
FS:  00007fd83f6f1080(0000) GS:ffff88885fd00000(0000) knlGS:0000000000000000
CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 00007f918d417000 CR3: 000000017f89a005 CR4: 00000000003706e0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
Call Trace:

generic_shutdown_super+0x47/0x120
kill_anon_super+0x14/0x30
ceph_kill_sb+0x36/0x90 [ceph]
deactivate_locked_super+0x29/0x60
cleanup_mnt+0xb8/0x140
task_work_run+0x67/0xb0
exit_to_user_mode_prepare+0x23d/0x240
syscall_exit_to_user_mode+0x25/0x60
do_syscall_64+0x40/0x80
entry_SYSCALL_64_after_hwframe+0x63/0xcd
RIP: 0033:0x7fd83dc39e9b

Later the kernel will crash when iput() the inodes and dereferencing
the "sb->s_master_keys", which has been released by the
generic_shutdown_super().

Link: https://tracker.ceph.com/issues/59162
Signed-off-by: Xiubo Li 
Reviewed-and-tested-by: Luís Henriques 
Reviewed-by: Milind Changire 
Signed-off-by: Ilya Dryomov

ceph: fix statfs for subdir mounts

2022-05-25T18:45:14+00:00

When doing a mount using as base a directory that has 'max_bytes' quotas
statfs uses that value as the total; if a subdirectory is used instead,
the same 'max_bytes' too in statfs, unless there is another quota set.

Unfortunately, if this subdirectory only has the 'max_files' quota set,
then statfs uses the filesystem total.  Fix this by making sure we only
lookup realms that contain the 'max_bytes' quota.

Cc: Ryan Taylor 
URL: https://tracker.ceph.com/issues/55090
Signed-off-by: Luís Henriques 
Reviewed-by: Jeff Layton 
Reviewed-by: Xiubo Li 
Signed-off-by: Ilya Dryomov

ceph: don't check for quotas on MDS stray dirs

2022-01-13T12:40:07+00:00

玮文 胡 reported seeing the WARN_RATELIMIT pop when writing to an
inode that had been transplanted into the stray dir. The client was
trying to look up the quotarealm info from the parent and that tripped
the warning.

Change the ceph_vino_is_reserved helper to not throw a warning for
MDS stray directories (0x100 - 0x1ff), only for reserved dirs that
are not in that range.

Also, fix ceph_has_realms_with_quotas to return false when encountering
a reserved inode.

URL: https://tracker.ceph.com/issues/53180
Reported-by: Hu Weiwen 
Signed-off-by: Jeff Layton 
Reviewed-by: Luis Henriques 
Reviewed-by: Xiubo Li 
Signed-off-by: Ilya Dryomov

ceph: Fix incorrect statfs report for small quota

2022-01-13T12:40:06+00:00

Problem:
The statfs reports incorrect free/available space for quota less then
CEPH_BLOCK size (4M).

Solution:
For quota less than CEPH_BLOCK size, smaller block size of 4K is used.
But if quota is less than 4K, it is decided to go with binary use/free
of 4K block. For quota size less than 4K size, report the
total=used=4K,free=0 when quota is full and total=free=4K,used=0
otherwise.

Signed-off-by: Kotresh HR 
Reviewed-by: Jeff Layton 
Signed-off-by: Ilya Dryomov

ceph: eliminate ceph_async_iput()

2021-06-28T22:15:52+00:00

Now that we don't need to hold session->s_mutex or the snap_rwsem when
calling ceph_check_caps, we can eliminate ceph_async_iput and just use
normal iput calls.

Signed-off-by: Jeff Layton 
Signed-off-by: Ilya Dryomov