linux-toradex.git/fs/ceph, branch v3.14.25 Linux kernel for Apalis and Colibri modules ceph: clear directory's completeness when creating file 2014-06-07T17:28:20+00:00 Yan, Zheng zheng.z.yan@intel.com 2014-04-14T05:13:02+00:00 600d8cbcd0f10b6535429a21bfb6cf2369155759 commit 0a8a70f96fe1bd3e07c15bb86fd247e76102398a upstream. When creating a file, ceph_set_dentry_offset() puts the new dentry at the end of directory's d_subdirs, then set the dentry's offset based on directory's max offset. The offset does not reflect the real postion of the dentry in directory. Later readdir reply from MDS may change the dentry's position/offset. This inconsistency can cause missing/duplicate entries in readdir result if readdir is partly satisfied by dcache_readdir(). The fix is clear directory's completeness after creating/renaming file. It prevents later readdir from using dcache_readdir(). Fixes: http://tracker.ceph.com/issues/8025 Signed-off-by: Yan, Zheng <zheng.z.yan@intel.com> Reviewed-by: Sage Weil <sage@inktank.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> 
commit 0a8a70f96fe1bd3e07c15bb86fd247e76102398a upstream.

When creating a file, ceph_set_dentry_offset() puts the new dentry
at the end of directory's d_subdirs, then set the dentry's offset
based on directory's max offset. The offset does not reflect the
real postion of the dentry in directory. Later readdir reply from
MDS may change the dentry's position/offset. This inconsistency
can cause missing/duplicate entries in readdir result if readdir
is partly satisfied by dcache_readdir().

The fix is clear directory's completeness after creating/renaming
file. It prevents later readdir from using dcache_readdir().

Fixes: http://tracker.ceph.com/issues/8025
Signed-off-by: Yan, Zheng <zheng.z.yan@intel.com>
Reviewed-by: Sage Weil <sage@inktank.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
ceph: fix __dcache_readdir() 2014-02-17T20:37:13+00:00 Yan, Zheng zheng.z.yan@intel.com 2014-02-13T11:40:26+00:00 4d5f5df673ee673851986b5a492a9752fbb39dc5 If directory is fragmented, readdir() read its dirfrags one by one. After reading all dirfrags, the corresponding dentries are sorted in (frag_t, off) order in the dcache. If dentries of a directory are all cached, __dcache_readdir() can use the cached dentries to satisfy readdir syscall. But when checking if a given dentry is after the position of readdir, __dcache_readdir() compares numerical value of frag_t directly. This is wrong, it should use ceph_frag_compare(). Signed-off-by: Yan, Zheng <zheng.z.yan@intel.com> 
If directory is fragmented, readdir() read its dirfrags one by one.
After reading all dirfrags, the corresponding dentries are sorted in
(frag_t, off) order in the dcache. If dentries of a directory are all
cached, __dcache_readdir() can use the cached dentries to satisfy
readdir syscall. But when checking if a given dentry is after the
position of readdir, __dcache_readdir() compares numerical value of
frag_t directly. This is wrong, it should use ceph_frag_compare().

Signed-off-by: Yan, Zheng <zheng.z.yan@intel.com>
ceph: add acl, noacl options for cephfs mount 2014-02-17T20:37:12+00:00 Sage Weil sage@inktank.com 2014-02-16T18:05:29+00:00 45195e42c78ea91135108207dbcaf75e5556a309 Make the 'acl' option dependent on having ACL support compiled in. Make the 'noacl' option work even without it so that one can always ask it to be off and not error out on mount when it is not supported. Signed-off-by: Guangliang Zhao <lucienchao@gmail.com> Signed-off-by: Sage Weil <sage@inktank.com> 
Make the 'acl' option dependent on having ACL support compiled in.  Make
the 'noacl' option work even without it so that one can always ask it to
be off and not error out on mount when it is not supported.

Signed-off-by: Guangliang Zhao <lucienchao@gmail.com>
Signed-off-by: Sage Weil <sage@inktank.com>
ceph: make ceph_forget_all_cached_acls() static inline 2014-02-17T20:37:12+00:00 Guangliang Zhao lucienchao@gmail.com 2014-02-16T16:35:52+00:00 c969d9bf91e1868d823351993216cd64dfab6a4c Signed-off-by: Guangliang Zhao <lucienchao@gmail.com> Reviewed-by: Alex Elder <elder@linaro.org> Signed-off-by: Sage Weil <sage@inktank.com> 
Signed-off-by: Guangliang Zhao <lucienchao@gmail.com>
Reviewed-by: Alex Elder <elder@linaro.org>
Signed-off-by: Sage Weil <sage@inktank.com>
ceph: add missing init_acl() for mkdir() and atomic_open() 2014-02-17T20:37:11+00:00 Yan, Zheng zheng.z.yan@intel.com 2014-02-11T04:55:05+00:00 b20a95a0dd47c56c5d20e1c9e260293d0b87abe0 Signed-off-by: Yan, Zheng <zheng.z.yan@intel.com> 
Signed-off-by: Yan, Zheng <zheng.z.yan@intel.com>
ceph: fix ceph_set_acl() 2014-02-17T20:37:11+00:00 Yan, Zheng zheng.z.yan@intel.com 2014-02-11T05:08:51+00:00 7a92d64760541e66bf5d1131f029b82773ce3922 If acl is equivalent to file mode permission bits, ceph_set_acl() needs to remove any existing acl xattr. Use __ceph_setxattr() to handle both setting and removing acl xattr cases, it doesn't return -ENODATA when there is no acl xattr. Signed-off-by: Yan, Zheng <zheng.z.yan@intel.com> 
If acl is equivalent to file mode permission bits, ceph_set_acl()
needs to remove any existing acl xattr. Use __ceph_setxattr() to
handle both setting and removing acl xattr cases, it doesn't return
-ENODATA when there is no acl xattr.

Signed-off-by: Yan, Zheng <zheng.z.yan@intel.com>
ceph: fix ceph_removexattr() 2014-02-17T20:37:10+00:00 Yan, Zheng zheng.z.yan@intel.com 2014-02-11T05:23:09+00:00 524186ace6c4dcc83975b858622a66888b018fd0 Signed-off-by: Yan, Zheng <zheng.z.yan@intel.com> 
Signed-off-by: Yan, Zheng <zheng.z.yan@intel.com>
ceph: remove xattr when null value is given to setxattr() 2014-02-17T20:37:09+00:00 Yan, Zheng zheng.z.yan@intel.com 2014-02-11T05:04:19+00:00 bcdfeb2eb4e42b811950b9cd226109291051732a For the setxattr request, introduce a new flag CEPH_XATTR_REMOVE to distinguish null value case from the zero-length value case. Signed-off-by: Yan, Zheng <zheng.z.yan@intel.com> 
For the setxattr request, introduce a new flag CEPH_XATTR_REMOVE
to distinguish null value case from the zero-length value case.

Signed-off-by: Yan, Zheng <zheng.z.yan@intel.com>
ceph: properly handle XATTR_CREATE and XATTR_REPLACE 2014-02-17T20:37:05+00:00 Yan, Zheng zheng.z.yan@intel.com 2014-02-11T05:01:19+00:00 fbc0b970ddfab4b35dad27ebaae712af680bdc7e return -EEXIST if XATTR_CREATE is set and xattr alread exists. return -ENODATA if XATTR_REPLACE is set but xattr does not exist. Signed-off-by: Yan, Zheng <zheng.z.yan@intel.com> 
return -EEXIST if XATTR_CREATE is set and xattr alread exists.
return -ENODATA if XATTR_REPLACE is set but xattr does not exist.

Signed-off-by: Yan, Zheng <zheng.z.yan@intel.com>
ceph: fix missing dput in ceph_set_acl 2014-01-31T16:14:06+00:00 Sage Weil sage@inktank.com 2014-01-31T15:25:25+00:00 77516dc92a14bb3853df959c0cb3ef51e659f5af Add matching dput() for d_find_alias(). Move d_find_alias() down a bit at Julia's suggestion. [ Introduced by commit 72466d0b92e0: "ceph: fix posix ACL hooks" ] Reported-by: Fengguang Wu <fengguang.wu@intel.com> Reported-by: Julia Lawall <julia.lawall@lip6.fr> Signed-off-by: Sage Weil <sage@inktank.com> Reviewed-by: Ilya Dryomov <ilya.dryomov@inktank.com> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org> 
Add matching dput() for d_find_alias().  Move d_find_alias() down a bit
at Julia's suggestion.

[ Introduced by commit 72466d0b92e0: "ceph: fix posix ACL hooks" ]

Reported-by: Fengguang Wu <fengguang.wu@intel.com>
Reported-by: Julia Lawall <julia.lawall@lip6.fr>
Signed-off-by: Sage Weil <sage@inktank.com>
Reviewed-by: Ilya Dryomov <ilya.dryomov@inktank.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>