linux-toradex.git/fs/cifs/cifs_debug.c, branch v4.4.136

Display number of credits available

2016-10-28T07:01:32+00:00

commit 9742805d6b1bfb45d7f267648c34fb5bcd347397 upstream.

In debugging smb3, it is useful to display the number
of credits available, so we can see when the server has not granted
sufficient operations for the client to make progress, or alternatively
the client has requested too many credits (as we saw in a recent bug)
so we can compare with the number of credits the server thinks
we have.

Add a /proc/fs/cifs/DebugData line to display the client view
on how many credits are available.

Signed-off-by: Steve French 
Reported-by: Germano Percossi 
Signed-off-by: Greg Kroah-Hartman

lib: update single-char callers of strtobool()

2016-10-28T07:01:30+00:00

commit 1404297ebf76fd91a41de215fc8c94c2619e5fdb upstream.

Some callers of strtobool() were passing a pointer to unterminated
strings.  In preparation of adding multi-character processing to
kstrtobool(), update the callers to not pass single-character pointers,
and switch to using the new kstrtobool_from_user() helper where
possible.

Signed-off-by: Kees Cook 
Cc: Amitkumar Karwar 
Cc: Nishant Sarmukadam 
Cc: Kalle Valo 
Cc: Steve French 
Cc: Andy Shevchenko 
Cc: Daniel Borkmann 
Cc: Heiko Carstens 
Cc: Joe Perches 
Cc: Kees Cook 
Cc: Martin Schwidefsky 
Cc: Michael Ellerman 
Cc: Rasmus Villemoes 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds 
[removed mwifiex driver change as it was correct and not needed for 4.4.y]
Signed-off-by: Greg Kroah-Hartman

cifs: Ratelimit kernel log messages

2016-02-25T20:01:17+00:00

commit ec7147a99e33a9e4abad6fc6e1b40d15df045d53 upstream.

Under some conditions, CIFS can repeatedly call the cifs_dbg() logging
wrapper. If done rapidly enough, the console framebuffer can softlockup
or "rcu_sched self-detected stall". Apply the built-in log ratelimiters
to prevent such hangs.

Signed-off-by: Jamie Bainbridge 
Signed-off-by: Steve French 
Signed-off-by: Greg Kroah-Hartman

cifs: fix MUST SecurityFlags filtering

2015-01-27T01:38:26+00:00

If CONFIG_CIFS_WEAK_PW_HASH is not set, CIFSSEC_MUST_LANMAN
and CIFSSEC_MUST_PLNTXT is defined as 0.

When setting new SecurityFlags without any MUST flags,
your flags would be overwritten with CIFSSEC_MUST_LANMAN (0).

Signed-off-by: Niklas Cassel 
Signed-off-by: Steve French

cifs: convert printk(LEVEL...) to pr_

2014-12-08T04:48:07+00:00

The useful macros embed message level in the name. Thus, it cleans up the code
a bit. In cases when it was plain printk() the conversion was done to info
level.

Signed-off-by: Andy Shevchenko 
Signed-off-by: Steve French

cifs: convert to print_hex_dump() instead of custom implementation

2014-12-08T04:48:01+00:00

This patch converts custom dumper to use native print_hex_dump() instead. The
cifs_dump_mem() will have an offsets per each line which differs it from the
original code.

In the dump_smb() we may use native print_hex_dump() as well. It will show
slightly different output in ASCII part when character is unprintable,
otherwise it keeps same structure.

Signed-off-by: Andy Shevchenko 
Signed-off-by: Steve French

cifs: call strtobool instead of custom implementation

2014-12-08T04:47:58+00:00

Meanwhile it cleans up the code, the behaviour is slightly changed. In case of
providing non-boolean value it will fails with corresponding error. In the
original code the attempt of an update was just ignored in such case.

Signed-off-by: Andy Shevchenko 
Acked-by: Jeff Layton 
Reviewed-by: Alexander Bokovoy 
Signed-off-by: Steve French

[CIFS] Fix incorrect hex vs. decimal in some debug print statements

2014-08-03T02:16:48+00:00

Joe Perches and Hans Wennborg noticed that various places in the
kernel were printing decimal numbers with 0x prefix.
    printk("0x%d") or equivalent
This fixes the instances of this in the cifs driver.

CC: Hans Wennborg 
CC: Joe Perches 
Signed-off-by: Steve French

cifs: try to handle the MUST SecurityFlags sanely

2013-06-26T22:31:55+00:00

The cifs.ko SecurityFlags interface wins my award for worst-designed
interface ever, but we're sort of stuck with it since it's documented
and people do use it (even if it doesn't work correctly).

Case in point -- you can specify multiple sets of "MUST" flags. It makes
absolutely no sense, but you can do it.

What should the effect be in such a case? No one knows or seems to have
considered this so far, so let's define it now. If you try to specify
multiple MUST flags, clear any other MAY or MUST bits except for the
ones that involve signing.

Signed-off-by: Jeff Layton 
Reviewed-by: Pavel Shilovsky 
Signed-off-by: Steve French

Add ability to dipslay SMB3 share flags and capabilities for debugging

2013-06-24T06:56:46+00:00

SMB3 protocol adds various optional per-share capabilities (and
SMB3.02 adds one more beyond that).  Add ability to dump
(/proc/fs/cifs/DebugData) the share capabilities and share flags to
improve debugging.

Signed-off-by: Steve French 
Acked-by: Jeff Layton