linux-toradex.git/fs/cifs/cifs_debug.h, branch v3.14.35

[CIFS] cifs: Rename cERROR and cFYI to cifs_dbg

2013-05-05T03:17:23+00:00

It's not obvious from reading the macro names that these macros
are for debugging.  Convert the names to a single more typical
kernel style cifs_dbg macro.

	cERROR(1, ...)   -> cifs_dbg(VFS, ...)
	cFYI(1, ...)     -> cifs_dbg(FYI, ...)
	cFYI(DBG2, ...)  -> cifs_dbg(NOISY, ...)

Move the terminating format newline from the macro to the call site.

Add CONFIG_CIFS_DEBUG function cifs_vfs_err to emit the
"CIFS VFS: " prefix for VFS messages.

Size is reduced ~ 1% when CONFIG_CIFS_DEBUG is set (default y)

$ size fs/cifs/cifs.ko*
   text    data     bss     dec     hex filename
 265245	   2525	    132	 267902	  4167e	fs/cifs/cifs.ko.new
 268359    2525     132  271016   422a8 fs/cifs/cifs.ko.old

Other miscellaneous changes around these conversions:

o Miscellaneous typo fixes
o Add terminating \n's to almost all formats and remove them
  from the macros to be more kernel style like.  A few formats
  previously had defective \n's
o Remove unnecessary OOM messages as kmalloc() calls dump_stack
o Coalesce formats to make grep easier,
  added missing spaces when coalescing formats
o Use %s, __func__ instead of embedded function name
o Removed unnecessary "cifs: " prefixes
o Convert kzalloc with multiply to kcalloc
o Remove unused cifswarn macro

Signed-off-by: Joe Perches 
Signed-off-by: Jeff Layton 
Signed-off-by: Steve French

cifs: eliminate cifsERROR variable

2012-12-20T17:27:17+00:00

It's always set to "1" and there's no way to change it to anything else.

Signed-off-by: Jeff Layton 
Signed-off-by: Steve French

cifs: Add CONFIG_CIFS_DEBUG and rename use of CIFS_DEBUG

2012-12-05T20:58:36+00:00

This can reduce the size of the module by ~120KB which
could be useful for embedded systems.

$ size fs/cifs/built-in.o*
   text	   data	    bss	    dec	    hex	filename
 388567	  34459	 100440	 523466	  7fcca	fs/cifs/built-in.o.new
 495970	  34599	 117904	 648473	  9e519	fs/cifs/built-in.o.old

Signed-off-by: Joe Perches 
Reviewed-by: Jeff Layton

cifs: Make CIFS_DEBUG possible to undefine

2012-12-05T20:58:09+00:00

Make the compilation work again when CIFS_DEBUG is not #define'd.

Add format and argument verification for the various macros when
CIFS_DEBUG is not #define'd.

Signed-off-by: Joe Perches 
Reviewed-by: Jeff Layton

cifs: Remove unused cEVENT macro

2012-12-05T19:27:31+00:00

It uses an undefined KERN_EVENT and is itself unused.

Signed-off-by: Joe Perches 
Reviewed-by: Jeff Layton 
Signed-off-by: Steve French 
Signed-off-by: Steve French

CIFS: Move protocol specific demultiplex thread calls to ops struct

2012-05-23T08:33:11+00:00

Acked-by: Shirish Pargaonkar 
Signed-off-by: Pavel Shilovsky 
Signed-off-by: Steve French

CIFS: Separate protocol-specific code from demultiplex code

2012-03-23T18:28:02+00:00

Signed-off-by: Pavel Shilovsky

CIFS: Separate protocol-specific code from transport routines

2012-03-23T18:28:02+00:00

that lets us use this functions for SMB2.

Signed-off-by: Pavel Shilovsky

[CIFS] Various small checkpatch cleanups

2010-10-07T18:46:32+00:00

Signed-off-by: Steve French

[CIFS] Neaten cERROR and cFYI macros, reduce text space

2010-04-21T03:50:45+00:00

Neaten cERROR and cFYI macros, reduce text space
~2.5K

Convert '__FILE__ ": " fmt' to '"%s: " fmt', __FILE__' to save text space
Surround macros with do {} while
Add parentheses to macros
Make statement expression macro from macro with assign
Remove now unnecessary parentheses from cFYI and cERROR uses

defconfig with CIFS support old
$ size fs/cifs/built-in.o
   text	   data	    bss	    dec	    hex	filename
 156012	   1760	    148	 157920	  268e0	fs/cifs/built-in.o

defconfig with CIFS support old
$ size fs/cifs/built-in.o
   text	   data	    bss	    dec	    hex	filename
 153508	   1760	    148	 155416	  25f18	fs/cifs/built-in.o

allyesconfig old:
$ size fs/cifs/built-in.o
   text	   data	    bss	    dec	    hex	filename
 309138	   3864	  74824	 387826	  5eaf2	fs/cifs/built-in.o

allyesconfig new
$ size fs/cifs/built-in.o
   text	   data	    bss	    dec	    hex	filename
 305655	   3864	  74824	 384343	  5dd57	fs/cifs/built-in.o

Signed-off-by: Joe Perches 
Signed-off-by: Steve French