linux-toradex.git/fs/cifs/cifs_debug.h, branch v4.5

cifs: Ratelimit kernel log messages

2016-01-14T19:39:02+00:00

Under some conditions, CIFS can repeatedly call the cifs_dbg() logging
wrapper. If done rapidly enough, the console framebuffer can softlockup
or "rcu_sched self-detected stall". Apply the built-in log ratelimiters
to prevent such hangs.

Signed-off-by: Jamie Bainbridge 
Signed-off-by: Steve French 
CC: Stable

cifs: convert printk(LEVEL...) to pr_

2014-12-08T04:48:07+00:00

The useful macros embed message level in the name. Thus, it cleans up the code
a bit. In cases when it was plain printk() the conversion was done to info
level.

Signed-off-by: Andy Shevchenko 
Signed-off-by: Steve French

[CIFS] cifs: Rename cERROR and cFYI to cifs_dbg

2013-05-05T03:17:23+00:00

It's not obvious from reading the macro names that these macros
are for debugging.  Convert the names to a single more typical
kernel style cifs_dbg macro.

	cERROR(1, ...)   -> cifs_dbg(VFS, ...)
	cFYI(1, ...)     -> cifs_dbg(FYI, ...)
	cFYI(DBG2, ...)  -> cifs_dbg(NOISY, ...)

Move the terminating format newline from the macro to the call site.

Add CONFIG_CIFS_DEBUG function cifs_vfs_err to emit the
"CIFS VFS: " prefix for VFS messages.

Size is reduced ~ 1% when CONFIG_CIFS_DEBUG is set (default y)

$ size fs/cifs/cifs.ko*
   text    data     bss     dec     hex filename
 265245	   2525	    132	 267902	  4167e	fs/cifs/cifs.ko.new
 268359    2525     132  271016   422a8 fs/cifs/cifs.ko.old

Other miscellaneous changes around these conversions:

o Miscellaneous typo fixes
o Add terminating \n's to almost all formats and remove them
  from the macros to be more kernel style like.  A few formats
  previously had defective \n's
o Remove unnecessary OOM messages as kmalloc() calls dump_stack
o Coalesce formats to make grep easier,
  added missing spaces when coalescing formats
o Use %s, __func__ instead of embedded function name
o Removed unnecessary "cifs: " prefixes
o Convert kzalloc with multiply to kcalloc
o Remove unused cifswarn macro

Signed-off-by: Joe Perches 
Signed-off-by: Jeff Layton 
Signed-off-by: Steve French

cifs: eliminate cifsERROR variable

2012-12-20T17:27:17+00:00

It's always set to "1" and there's no way to change it to anything else.

Signed-off-by: Jeff Layton 
Signed-off-by: Steve French

cifs: Add CONFIG_CIFS_DEBUG and rename use of CIFS_DEBUG

2012-12-05T20:58:36+00:00

This can reduce the size of the module by ~120KB which
could be useful for embedded systems.

$ size fs/cifs/built-in.o*
   text	   data	    bss	    dec	    hex	filename
 388567	  34459	 100440	 523466	  7fcca	fs/cifs/built-in.o.new
 495970	  34599	 117904	 648473	  9e519	fs/cifs/built-in.o.old

Signed-off-by: Joe Perches 
Reviewed-by: Jeff Layton

cifs: Make CIFS_DEBUG possible to undefine

2012-12-05T20:58:09+00:00

Make the compilation work again when CIFS_DEBUG is not #define'd.

Add format and argument verification for the various macros when
CIFS_DEBUG is not #define'd.

Signed-off-by: Joe Perches 
Reviewed-by: Jeff Layton

cifs: Remove unused cEVENT macro

2012-12-05T19:27:31+00:00

It uses an undefined KERN_EVENT and is itself unused.

Signed-off-by: Joe Perches 
Reviewed-by: Jeff Layton 
Signed-off-by: Steve French 
Signed-off-by: Steve French

CIFS: Move protocol specific demultiplex thread calls to ops struct

2012-05-23T08:33:11+00:00

Acked-by: Shirish Pargaonkar 
Signed-off-by: Pavel Shilovsky 
Signed-off-by: Steve French

CIFS: Separate protocol-specific code from demultiplex code

2012-03-23T18:28:02+00:00

Signed-off-by: Pavel Shilovsky

CIFS: Separate protocol-specific code from transport routines

2012-03-23T18:28:02+00:00

that lets us use this functions for SMB2.

Signed-off-by: Pavel Shilovsky