linux-toradex.git/fs/cifs/dir.c, branch v3.11.4

cifs: fix filp leak in cifs_atomic_open()

2013-10-01T16:40:58+00:00

commit dfb1d61b0e9f9e2c542e9adc8d970689f4114ff6 upstream.

If an error occurs after having called finish_open() then fput() needs to
be called on the already opened file.

Signed-off-by: Miklos Szeredi 
Cc: Steve French 
Signed-off-by: Al Viro 
Signed-off-by: Greg Kroah-Hartman

CIFS: Reconnect durable handles for SMB2

2013-07-10T18:08:40+00:00

On reconnects, we need to reopen file and then obtain all byte-range
locks held by the client. SMB2 protocol provides feature to make
this process atomic by reconnecting to the same file handle
with all it's byte-range locks. This patch adds this capability
for SMB2 shares.

Signed-off-by: Pavel Shilovsky 
Signed-off-by: Steven French

CIFS: Introduce cifs_open_parms struct

2013-07-10T18:08:40+00:00

and pass it to the open() call.

Signed-off-by: Pavel Shilovsky 
Signed-off-by: Steven French

Don't pass inode to ->d_hash() and ->d_compare()

2013-06-29T08:57:36+00:00

Instances either don't look at it at all (the majority of cases) or
only want it to find the superblock (which can be had as dentry->d_sb).
A few cases that want more are actually safe with dentry->d_inode -
the only precaution needed is the check that it hadn't been replaced with
NULL by rmdir() or by overwriting rename(), which case should be simply
treated as cache miss.

Signed-off-by: Linus Torvalds 
Signed-off-by: Al Viro

CIFS: fix error return code in cifs_atomic_open()

2013-05-05T03:18:06+00:00

Fix to return a negative error code from the error handling
case instead of 0, as returned elsewhere in this function.

Signed-off-by: Wei Yongjun 
Reviewed-by: Jeff Layton 
Signed-off-by: Steve French 
Signed-off-by: Steve French

[CIFS] cifs: Rename cERROR and cFYI to cifs_dbg

2013-05-05T03:17:23+00:00

It's not obvious from reading the macro names that these macros
are for debugging.  Convert the names to a single more typical
kernel style cifs_dbg macro.

	cERROR(1, ...)   -> cifs_dbg(VFS, ...)
	cFYI(1, ...)     -> cifs_dbg(FYI, ...)
	cFYI(DBG2, ...)  -> cifs_dbg(NOISY, ...)

Move the terminating format newline from the macro to the call site.

Add CONFIG_CIFS_DEBUG function cifs_vfs_err to emit the
"CIFS VFS: " prefix for VFS messages.

Size is reduced ~ 1% when CONFIG_CIFS_DEBUG is set (default y)

$ size fs/cifs/cifs.ko*
   text    data     bss     dec     hex filename
 265245	   2525	    132	 267902	  4167e	fs/cifs/cifs.ko.new
 268359    2525     132  271016   422a8 fs/cifs/cifs.ko.old

Other miscellaneous changes around these conversions:

o Miscellaneous typo fixes
o Add terminating \n's to almost all formats and remove them
  from the macros to be more kernel style like.  A few formats
  previously had defective \n's
o Remove unnecessary OOM messages as kmalloc() calls dump_stack
o Coalesce formats to make grep easier,
  added missing spaces when coalescing formats
o Use %s, __func__ instead of embedded function name
o Removed unnecessary "cifs: " prefixes
o Convert kzalloc with multiply to kcalloc
o Remove unused cifswarn macro

Signed-off-by: Joe Perches 
Signed-off-by: Jeff Layton 
Signed-off-by: Steve French

cifs: Modify struct cifs_unix_set_info_args to hold a kuid_t and a kgid_t

2013-02-13T15:28:49+00:00

Use INVALID_UID and INVALID_GID instead of NO_CHANGE_64 to indicate
the value should not be changed.

In cifs_fill_unix_set_info convert from kuids and kgids into uids and
gids that will fit in FILE_UNIX_BASIC_INFO.

Cc: Steve French 
Signed-off-by: "Eric W. Biederman"

cifs: fix up handling of prefixpath= option

2012-12-11T17:48:49+00:00

Currently the code takes care to ensure that the prefixpath has a
leading '/' delimiter. What if someone passes us a prefixpath with a
leading '\\' instead? The code doesn't properly handle that currently
AFAICS.

Let's just change the code to skip over any leading delimiter character
when copying the prepath. Then, fix up the users of the prepath option
to prefix it with the correct delimiter when they use it.

Also, there's no need to limit the length of the prefixpath to 1k. If
the server can handle it, why bother forbidding it?

Pavel Shilovsky 
Signed-off-by: Jeff Layton 
Signed-off-by: Steve French

CIFS: Make use of common cifs_build_path_to_root for CIFS and SMB2

2012-12-05T19:27:28+00:00

because the is no difference here. This also adds support of prefixpath
mount option for SMB2.

Signed-off-by: Pavel Shilovsky 
Reviewed-by: Jeff Layton 
Signed-off-by: Steve French

cifs: Do not lookup hashed negative dentry in cifs_atomic_open

2012-11-05T11:45:54+00:00

We do not need to lookup a hashed negative directory since we have
already revalidated it before and have found it to be fine.

This also prevents a crash in cifs_lookup() when it attempts to rehash
the already hashed negative lookup dentry.

The patch has been tested using the reproducer at
https://bugzilla.redhat.com/show_bug.cgi?id=867344#c28

Cc:  # 3.6.x
Reported-by: Vit Zahradka 
Signed-off-by: Sachin Prabhu