linux-toradex.git/fs/cifs/netmisc.c, branch v3.4.16

cifs: writing past end of struct in cifs_convert_address()

2012-03-31T22:32:18+00:00

"s6->sin6_scope_id" is an int bits but strict_strtoul() writes a long
so this can corrupt memory on 64 bit systems.

Signed-off-by: Dan Carpenter 
Reviewed-by: Jeff Layton 
Signed-off-by: Steve French

CIFS: Separate protocol-specific code from cifs_readv_receive code

2012-03-23T18:28:03+00:00

Signed-off-by: Pavel Shilovsky

cifs: consolidate SendReceive response checks

2011-05-23T02:58:24+00:00

Further consolidate the SendReceive code by moving the checks run over
the packet into a separate function that all the SendReceive variants
can call.

We can also eliminate the check for a receive_len that's too big or too
small. cifs_demultiplex_thread already checks that and disconnects the
socket if that occurs, while setting the midStatus to MALFORMED. It'll
never call this code if that's the case.

Finally do a little cleanup. Use "goto out" on errors so that the flow
of code in the normal case is more evident. Also switch the logErr
variable in map_smb_to_linux_error to a bool.

Reviewed-by: Pavel Shilovsky 
Signed-off-by: Jeff Layton 
Signed-off-by: Steve French

cifs: keep BCC in little-endian format

2011-05-19T14:10:53+00:00

This is the same patch as originally posted, just with some merge
conflicts fixed up...

Currently, the ByteCount is usually converted to host-endian on receive.
This is confusing however, as we need to keep two sets of routines for
accessing it, and keep track of when to use each routine. Munging
received packets like this also limits when the signature can be
calulated.

Simplify the code by keeping the received ByteCount in little-endian
format. This allows us to eliminate a set of routines for accessing it
and we can now drop the *_le suffixes from the accessor functions since
that's now implied.

While we're at it, switch all of the places that read the ByteCount
directly to use the get_bcc inline which should also clean up some
unaligned accesses.

Signed-off-by: Jeff Layton 
Signed-off-by: Steve French

cifs: fix handling of scopeid in cifs_convert_address

2011-02-17T05:35:33+00:00

The code finds, the '%' sign in an ipv6 address and copies that to a
buffer allocated on the stack. It then ignores that buffer, and passes
'pct' to simple_strtoul(), which doesn't work right because we're
comparing 'endp' against a completely different string.

Fix it by passing the correct pointer. While we're at it, this is a
good candidate for conversion to strict_strtoul as well.

Cc: stable@kernel.org
Cc: David Howells 
Reported-by: BjÃ¶rn JACKE 
Signed-off-by: Jeff Layton 
Signed-off-by: Steve French

cifs: use get/put_unaligned functions to access ByteCount

2011-01-20T21:46:29+00:00

It's possible that when we access the ByteCount that the alignment
will be off. Most CPUs deal with that transparently, but there's
usually some performance impact. Some CPUs raise an exception on
unaligned accesses.

Fix this by accessing the byte count using the get_unaligned and
put_unaligned inlined functions. While we're at it, fix the types
of some of the variables that end up getting returns from these
functions.

Acked-by: Pavel Shilovsky 
Signed-off-by: Jeff Layton 
Signed-off-by: Steve French

cifs: cFYI the entire error code in map_smb_to_linux_error

2011-01-14T18:51:11+00:00

We currently only print the DOS error part.

Signed-off-by: Jeff Layton 
Signed-off-by: Steve French

cifs: prevent possible memory corruption in cifs_demultiplex_thread

2010-09-08T21:22:35+00:00

cifs_demultiplex_thread sets the addr.sockAddr.sin_port without any
regard for the socket family. While it may be that the error in question
here never occurs on an IPv6 socket, it's probably best to be safe and
set the port properly if it ever does.

Break the port setting code out of cifs_fill_sockaddr and into a new
function, and call that from cifs_demultiplex_thread.

Signed-off-by: Jeff Layton 
Signed-off-by: Steve French

CIFS: Make cifs_convert_address() take a const src pointer and a length

2010-08-05T17:17:50+00:00

Make cifs_convert_address() take a const src pointer and a length so that all
the strlen() calls in their can be cut out and to make it unnecessary to modify
the src string.

Also return the data length from dns_resolve_server_name_to_ip() so that a
strlen() can be cut out of cifs_compose_mount_options() too.

Acked-by: Jeff Layton 
Signed-off-by: David Howells 
Signed-off-by: Steve French

cifs: map NT_STATUS_ERROR_WRITE_PROTECTED to -EROFS

2010-08-02T12:40:40+00:00

Seems like a more sensible mapping than -EIO.

Signed-off-by: Jeff Layton 
Signed-off-by: Steve French