linux-toradex.git/fs/cifs/readdir.c, branch v3.3.6

CIFS: Rename UCS functions to UTF16

2012-01-19T04:32:33+00:00

to reflect the unicode encoding used by CIFS protocol.

Signed-off-by: Pavel Shilovsky 
Acked-by: Jeff Layton 
Reviewed-by: Shirish Pargaonkar

cifs: check for NULL last_entry before calling cifs_save_resume_key

2011-12-09T04:04:47+00:00

Prior to commit eaf35b1, cifs_save_resume_key had some NULL pointer
checks at the top. It turns out that at least one of those NULL
pointer checks is needed after all.

When the LastNameOffset in a FIND reply appears to be beyond the end of
the buffer, CIFSFindFirst and CIFSFindNext will set srch_inf.last_entry
to NULL. Since eaf35b1, the code will now oops in this situation.

Fix this by having the callers check for a NULL last entry pointer
before calling cifs_save_resume_key. No change is needed for the
call site in cifs_readdir as it's not reachable with a NULL
current_entry pointer.

This should fix:

    https://bugzilla.redhat.com/show_bug.cgi?id=750247

Cc: stable@vger.kernel.org
Cc: Christoph Hellwig 
Reported-by: Adam G. Metzler 
Signed-off-by: Jeff Layton 
Signed-off-by: Steve French

Merge git://git.kernel.org/pub/scm/linux/kernel/git/sfrench/cifs-2.6

2011-07-26T18:11:28+00:00

* git://git.kernel.org/pub/scm/linux/kernel/git/sfrench/cifs-2.6:
  cifs: Cleanup: check return codes of crypto api calls
  CIFS: Fix oops while mounting with prefixpath
  [CIFS] Redundant null check after dereference
  cifs: use cifs_dirent in cifs_save_resume_key
  cifs: use cifs_dirent to replace cifs_get_name_from_search_buf
  cifs: introduce cifs_dirent
  cifs: cleanup cifs_filldir

cifs: use cifs_dirent in cifs_save_resume_key

2011-07-25T21:43:14+00:00

Signed-off-by: Christoph Hellwig 
Reviewed-by: Jeff Layton 
Signed-off-by: Steve French

cifs: use cifs_dirent to replace cifs_get_name_from_search_buf

2011-07-25T21:40:53+00:00

This allows us to parse the on the wire structures only once in
cifs_filldir.

Signed-off-by: Christoph Hellwig 
Reviewed-by: Jeff Layton 
Signed-off-by: Steve French

cifs: introduce cifs_dirent

2011-07-25T21:36:44+00:00

Introduce a generic directory entry structure, and factor the parsing
of the various on the wire structures that can represent one into
a common helper.  Switch cifs_entry_is_dot over to use it as a start.

Signed-off-by: Christoph Hellwig 
Reviewed-by: Jeff Layton 
Signed-off-by: Steve French

cifs: cleanup cifs_filldir

2011-07-25T21:05:10+00:00

Use sensible variable names and formatting and remove some superflous
checks on entry.

Signed-off-by: Christoph Hellwig 
Reviewed-by: Jeff Layton 
Signed-off-by: Steve French

don't open-code parent_ino() in assorted ->readdir()

2011-07-21T00:47:54+00:00

Signed-off-by: Al Viro

[CIFS] Rename three structures to avoid camel case

2011-05-27T04:34:02+00:00

secMode to sec_mode
and
cifsTconInfo to cifs_tcon
and
cifsSesInfo to cifs_ses

Signed-off-by: Steve French

cifs: clean up some compiler warnings

2011-01-31T15:39:10+00:00

New compiler warnings that I noticed when building a patchset based
on recent Fedora kernel:

fs/cifs/cifssmb.c: In function 'CIFSSMBSetFileSize':
fs/cifs/cifssmb.c:4813:8: warning: variable 'data_offset' set but not used
[-Wunused-but-set-variable]

fs/cifs/file.c: In function 'cifs_open':
fs/cifs/file.c:349:24: warning: variable 'pCifsInode' set but not used
[-Wunused-but-set-variable]
fs/cifs/file.c: In function 'cifs_partialpagewrite':
fs/cifs/file.c:1149:23: warning: variable 'cifs_sb' set but not used
[-Wunused-but-set-variable]
fs/cifs/file.c: In function 'cifs_iovec_write':
fs/cifs/file.c:1740:9: warning: passing argument 6 of 'CIFSSMBWrite2' from
incompatible pointer type [enabled by default]
fs/cifs/cifsproto.h:337:12: note: expected 'unsigned int *' but argument is
of type 'size_t *'

fs/cifs/readdir.c: In function 'cifs_readdir':
fs/cifs/readdir.c:767:23: warning: variable 'cifs_sb' set but not used
[-Wunused-but-set-variable]

fs/cifs/cifs_dfs_ref.c: In function 'cifs_dfs_d_automount':
fs/cifs/cifs_dfs_ref.c:342:2: warning: 'rc' may be used uninitialized in
this function [-Wuninitialized]
fs/cifs/cifs_dfs_ref.c:278:6: note: 'rc' was declared here

Signed-off-by: Jeff Layton 
Reviewed-by: Pavel Shilovsky 
Signed-off-by: Steve French