linux-toradex.git/fs/cifs, branch v2.6.30-rc7

[CIFS] Avoid open on possible directories since Samba now rejects them

2009-05-23T18:57:25+00:00

Small change (mostly formatting) to limit lookup based open calls to
file create only.

After discussion yesteday on samba-technical about the posix lookup
regression,  and looking at a problem with cifs posix open to one
particular Samba version, Jeff and JRA realized that Samba server's
behavior changed in this area (posix open behavior on files vs.
directories).   To make this behavior consistent, JRA just made a
fix to Samba server to alter how it handles open of directories (now
returning the equivalent of EISDIR instead of success). Since we don't
know at lookup time whether the inode is a directory or file (and
thus whether posix open will succeed with most current Samba server),
this change avoids the posix open code on lookup open (just issues
posix open on creates).    This gets the semantic benefits we want
(atomicity, posix byte range locks, improved write semantics on newly
created files) and file create still is fast, and we avoid the problem
that Jeff noticed yesterday with "openat" (and some open directory
calls) of non-cached directories to one version of Samba server, and
will work with future Samba versions (which include the fix jra just
pushed into Samba server).  I confirmed this approach with jra
yesterday and with Shirish today.

Posix open is only called (at lookup time) for file create now.
For opens (rather than creates), because we do not know if it
is a file or directory yet, and current Samba no longer allows
us to do posix open on dirs, we could end up wasting an open call
on what turns out to be a dir. For file opens, we wait to call posix
open till cifs_open.  It could be added here (lookup) in the future
but the performance tradeoff of the extra network request when EISDIR
or EACCES is returned would have to be weighed against the 50%
reduction in network traffic in the other paths.

Reviewed-by: Shirish Pargaonkar 
Tested-by: Jeff Layton 
CC: Jeremy Allison 
Signed-off-by: Steve French

[CIFS] fix posix open regression

2009-05-21T22:38:08+00:00

Posix open code was not properly adding the file to the
list of open files.  Fix  allocating cifsFileInfo
more than once, and adding twice to flist and tlist.
Also fix mode setting to be done in one place in these
paths.

Signed-off-by: Steve French 
Reviewed-by: Shirish Pargaonkar 
Tested-by: Jeff Layton 
Tested-by: Luca Tettamanti

cifs: fix pointer initialization and checks in cifs_follow_symlink (try #4)

2009-05-19T15:31:20+00:00

This is the third respin of the patch posted yesterday to fix the error
handling in cifs_follow_symlink. It also includes a fix for a bogus NULL
pointer check in CIFSSMBQueryUnixSymLink that Jeff Moyer spotted.

It's possible for CIFSSMBQueryUnixSymLink to return without setting
target_path to a valid pointer. If that happens then the current value
to which we're initializing this pointer could cause an oops when it's
kfree'd.

This patch is a little more comprehensive than the last patches. It
reorganizes cifs_follow_link a bit for (hopefully) better readability.
It should also eliminate the uneeded allocation of full_path on servers
without unix extensions (assuming they can get to this point anyway, of
which I'm not convinced).

On a side note, I'm not sure I agree with the logic of enabling this
query even when unix extensions are disabled on the client. It seems
like that should disable this as well. But, changing that is outside the
scope of this fix, so I've left it alone for now.

Reported-by: Jeff Moyer 
Signed-off-by: Jeff Layton 
Reviewed-by: Jeff Moyer 
Reviewed-by: Christoph Hellwig 
Signed-off-by: Steve French

cifs: fix error handling in parse_DFS_referrals

2009-05-14T13:55:32+00:00

cifs_strndup_from_ucs returns NULL on error, not an ERR_PTR

Signed-off-by: Jeff Layton 
Signed-off-by: Steve French

Convert obvious places to deactivate_locked_super()

2009-05-09T14:49:40+00:00

Signed-off-by: Al Viro

vfs: umount_begin BKL pushdown

2009-05-09T14:49:38+00:00

Push BKL down into ->umount_begin()

Signed-off-by: Alessio Igor Bogani 
Signed-off-by: Al Viro

[CIFS] Fix double list addition in cifs posix open code

2009-05-08T03:04:30+00:00

Remove adding open file entry twice to lists in the file
Do not fill file info twice in case of posix opens and creates

Signed-off-by: Shirish Pargaonkar 
Signed-off-by: Steve French

[CIFS] Allow raw ntlmssp code to be enabled with sec=ntlmssp

2009-05-06T04:16:04+00:00

On mount, "sec=ntlmssp" can now be specified to allow
"rawntlmssp" security to be enabled during
CIFS session establishment/authentication (ntlmssp used to
require specifying krb5 which was counterintuitive).

Signed-off-by: Steve French

[CIFS] Fix SMB uid in NTLMSSP authenticate request

2009-05-06T00:48:30+00:00

We were not setting the SMB uid in NTLMSSP authenticate
request which could lead to INVALID_PARAMETER error
on 2nd session setup.

Signed-off-by: Steve French

[CIFS] NTLMSSP reenabled after move from connect.c to sess.c

2009-05-04T08:37:12+00:00

The NTLMSSP code was removed from fs/cifs/connect.c and merged
(75% smaller, cleaner) into fs/cifs/sess.c

As with the old code it requires that cifs be built with
CONFIG_CIFS_EXPERIMENTAL, the /proc/fs/cifs/Experimental flag
must be set to 2, and mount must turn on extended security
(e.g. with sec=krb5).

Although NTLMSSP encapsulated in SPNEGO is not enabled yet,
"raw" ntlmssp is common and useful in some cases since it
offers more complete security negotiation, and is the
default way of negotiating security for many Windows systems.
SPNEGO encapsulated NTLMSSP will be able to reuse the same
code.

Signed-off-by: Steve French