linux-toradex.git/fs/cifs, branch v5.0 Linux kernel for Apalis and Colibri modules cifs: update internal module version number 2019-01-31T13:05:06+00:00 Steve French stfrench@microsoft.com 2019-01-29T23:27:33+00:00 b9b9378b49030d1aeca2387660fcd1ac1f306cad To 2.17 Signed-off-by: Steve French <stfrench@microsoft.com> 
To 2.17

Signed-off-by: Steve French <stfrench@microsoft.com>
CIFS: fix use-after-free of the lease keys 2019-01-31T13:03:20+00:00 Aurelien Aptel aaptel@suse.com 2019-01-31T12:46:07+00:00 d339adc12a4f885b572c5412e4869af8939db854 The request buffers are freed right before copying the pointers. Use the func args instead which are identical and still valid. Simple reproducer (requires KASAN enabled) on a cifs mount: echo foo > foo ; tail -f foo & rm foo Cc: <stable@vger.kernel.org> # 4.20 Fixes: 179e44d49c2f ("smb3: add tracepoint for sending lease break responses to server") Signed-off-by: Aurelien Aptel <aaptel@suse.com> Signed-off-by: Steve French <stfrench@microsoft.com> Reviewed-by: Paulo Alcantara <palcantara@suse.de> 
The request buffers are freed right before copying the pointers.
Use the func args instead which are identical and still valid.

Simple reproducer (requires KASAN enabled) on a cifs mount:

echo foo > foo ; tail -f foo & rm foo

Cc: <stable@vger.kernel.org> # 4.20
Fixes: 179e44d49c2f ("smb3: add tracepoint for sending lease break responses to server")
Signed-off-by: Aurelien Aptel <aaptel@suse.com>
Signed-off-by: Steve French <stfrench@microsoft.com>
Reviewed-by: Paulo Alcantara <palcantara@suse.de>
CIFS: Do not consider -ENODATA as stat failure for reads 2019-01-29T23:27:16+00:00 Pavel Shilovsky pshilov@microsoft.com 2019-01-18T23:54:34+00:00 082aaa8700415f6471ec9c5ef0c8307ca214989a When doing reads beyound the end of a file the server returns error STATUS_END_OF_FILE error which is mapped to -ENODATA. Currently we report it as a failure which confuses read stats. Change it to not consider -ENODATA as failure for stat purposes. Signed-off-by: Pavel Shilovsky <pshilov@microsoft.com> Signed-off-by: Steve French <stfrench@microsoft.com> CC: Stable <stable@vger.kernel.org> 
When doing reads beyound the end of a file the server returns
error STATUS_END_OF_FILE error which is mapped to -ENODATA.
Currently we report it as a failure which confuses read stats.
Change it to not consider -ENODATA as failure for stat purposes.

Signed-off-by: Pavel Shilovsky <pshilov@microsoft.com>
Signed-off-by: Steve French <stfrench@microsoft.com>
CC: Stable <stable@vger.kernel.org>
CIFS: Do not count -ENODATA as failure for query directory 2019-01-29T23:24:53+00:00 Pavel Shilovsky pshilov@microsoft.com 2019-01-26T20:21:32+00:00 8e6e72aeceaaed5aeeb1cb43d3085de7ceb14f79 Signed-off-by: Pavel Shilovsky <pshilov@microsoft.com> Signed-off-by: Steve French <stfrench@microsoft.com> CC: Stable <stable@vger.kernel.org> 
Signed-off-by: Pavel Shilovsky <pshilov@microsoft.com>
Signed-off-by: Steve French <stfrench@microsoft.com>
CC: Stable <stable@vger.kernel.org>
CIFS: Fix trace command logging for SMB2 reads and writes 2019-01-29T23:19:56+00:00 Pavel Shilovsky pshilov@microsoft.com 2019-01-25T19:38:53+00:00 7d42e72fe8ee5ab70b1af843dd7d8615e6fb0abe Currently we log success once we send an async IO request to the server. Instead we need to analyse a response and then log success or failure for a particular command. Also fix argument list for read logging. Cc: <stable@vger.kernel.org> # 4.18 Signed-off-by: Pavel Shilovsky <pshilov@microsoft.com> Signed-off-by: Steve French <stfrench@microsoft.com> 
Currently we log success once we send an async IO request to
the server. Instead we need to analyse a response and then log
success or failure for a particular command. Also fix argument
list for read logging.

Cc: <stable@vger.kernel.org> # 4.18
Signed-off-by: Pavel Shilovsky <pshilov@microsoft.com>
Signed-off-by: Steve French <stfrench@microsoft.com>
CIFS: Fix possible oops and memory leaks in async IO 2019-01-29T23:19:47+00:00 Pavel Shilovsky pshilov@microsoft.com 2019-01-24T01:12:09+00:00 9bda8723da2d55b1de833b98cf802b88006e5b69 Allocation of a page array for non-cached IO was separated from allocation of rdata and wdata structures and this introduced memory leaks and a possible null pointer dereference. This patch fixes these problems. Cc: <stable@vger.kernel.org> Signed-off-by: Pavel Shilovsky <pshilov@microsoft.com> Signed-off-by: Steve French <stfrench@microsoft.com> 
Allocation of a page array for non-cached IO was separated from
allocation of rdata and wdata structures and this introduced memory
leaks and a possible null pointer dereference. This patch fixes
these problems.

Cc: <stable@vger.kernel.org>
Signed-off-by: Pavel Shilovsky <pshilov@microsoft.com>
Signed-off-by: Steve French <stfrench@microsoft.com>
cifs: limit amount of data we request for xattrs to CIFSMaxBufSize 2019-01-29T22:17:25+00:00 Ronnie Sahlberg lsahlber@redhat.com 2019-01-29T02:46:17+00:00 c4627e66f73a28c5515b908c90c2bf7120086497 minus the various headers and blobs that will be part of the reply. or else we might trigger a session reconnect. Signed-off-by: Ronnie Sahlberg <lsahlber@redhat.com> Signed-off-by: Steve French <stfrench@microsoft.com> Reviewed-by: Pavel Shilovsky <pshilov@microsoft.com> 
minus the various headers and blobs that will be part of the reply.

or else we might trigger a session reconnect.

Signed-off-by: Ronnie Sahlberg <lsahlber@redhat.com>
Signed-off-by: Steve French <stfrench@microsoft.com>
Reviewed-by: Pavel Shilovsky <pshilov@microsoft.com>
cifs: fix computation for MAX_SMB2_HDR_SIZE 2019-01-29T22:15:08+00:00 Ronnie Sahlberg lsahlber@redhat.com 2019-01-29T02:46:16+00:00 58d15ed1203f4d858c339ea4d7dafa94bd2a56d3 The size of the fixed part of the create response is 88 bytes not 56. Signed-off-by: Ronnie Sahlberg <lsahlber@redhat.com> Signed-off-by: Steve French <stfrench@microsoft.com> Reviewed-by: Pavel Shilovsky <pshilov@microsoft.com> 
The size of the fixed part of the create response is 88 bytes not 56.

Signed-off-by: Ronnie Sahlberg <lsahlber@redhat.com>
Signed-off-by: Steve French <stfrench@microsoft.com>
Reviewed-by: Pavel Shilovsky <pshilov@microsoft.com>
cifs: print CIFSMaxBufSize as part of /proc/fs/cifs/DebugData 2019-01-24T20:52:06+00:00 Ronnie Sahlberg lsahlber@redhat.com 2019-01-24T06:19:31+00:00 a5f1a81f701c594194eb70c679785882ab15f138 Was helpful in debug for some recent problems. Signed-off-by: Ronnie Sahlberg <lsahlber@redhat.com> Signed-off-by: Steve French <stfrench@microsoft.com> 
Was helpful in debug for some recent problems.

Signed-off-by: Ronnie Sahlberg <lsahlber@redhat.com>
Signed-off-by: Steve French <stfrench@microsoft.com>
smb3: add credits we receive from oplock/break PDUs 2019-01-24T20:52:06+00:00 Ronnie Sahlberg lsahlber@redhat.com 2019-01-23T06:20:38+00:00 2e5700bdde438ed708b36d8acd0398dc73cbf759 Otherwise we gradually leak credits leading to potential hung session. Signed-off-by: Ronnie Sahlberg <lsahlber@redhat.com> CC: Stable <stable@vger.kernel.org> Reviewed-by: Pavel Shilovsky <pshilov@microsoft.com> Signed-off-by: Steve French <stfrench@microsoft.com> 
Otherwise we gradually leak credits leading to potential
hung session.

Signed-off-by: Ronnie Sahlberg <lsahlber@redhat.com>
CC: Stable <stable@vger.kernel.org>
Reviewed-by: Pavel Shilovsky <pshilov@microsoft.com>
Signed-off-by: Steve French <stfrench@microsoft.com>