<feed xmlns='http://www.w3.org/2005/Atom'>
<title>linux-toradex.git/fs/configfs/file.c, branch imx-android-r13.2</title>
<subtitle>Linux kernel for Apalis and Colibri modules</subtitle>
<link rel='alternate' type='text/html' href='https://git.toradex.cn/cgit/linux-toradex.git/'/>
<entry>
<title>fs: replace remaining __FUNCTION__ occurrences</title>
<updated>2008-04-30T15:29:54+00:00</updated>
<author>
<name>Harvey Harrison</name>
<email>harvey.harrison@gmail.com</email>
</author>
<published>2008-04-30T07:55:09+00:00</published>
<link rel='alternate' type='text/html' href='https://git.toradex.cn/cgit/linux-toradex.git/commit/?id=8e24eea728068bbeb6a3c500b848f883a20bf225'/>
<id>8e24eea728068bbeb6a3c500b848f883a20bf225</id>
<content type='text'>
__FUNCTION__ is gcc-specific, use __func__

Signed-off-by: Harvey Harrison &lt;harvey.harrison@gmail.com&gt;
Signed-off-by: Andrew Morton &lt;akpm@linux-foundation.org&gt;
Signed-off-by: Linus Torvalds &lt;torvalds@linux-foundation.org&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
__FUNCTION__ is gcc-specific, use __func__

Signed-off-by: Harvey Harrison &lt;harvey.harrison@gmail.com&gt;
Signed-off-by: Andrew Morton &lt;akpm@linux-foundation.org&gt;
Signed-off-by: Linus Torvalds &lt;torvalds@linux-foundation.org&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>configfs: file.c fix possible recursive locking</title>
<updated>2008-01-25T23:05:47+00:00</updated>
<author>
<name>Joonwoo Park</name>
<email>joonwpark81@gmail.com</email>
</author>
<published>2007-12-26T03:09:57+00:00</published>
<link rel='alternate' type='text/html' href='https://git.toradex.cn/cgit/linux-toradex.git/commit/?id=116ba5d5ea1a5789a8c14b1087014007cada363b'/>
<id>116ba5d5ea1a5789a8c14b1087014007cada363b</id>
<content type='text'>
configfs_register_subsystem() with default_groups triggers recursive locking.
it seems that mutex_lock_nested is needed.

=============================================
[ INFO: possible recursive locking detected ]
2.6.24-rc6 #145
---------------------------------------------
swapper/1 is trying to acquire lock:
 (&amp;sb-&gt;s_type-&gt;i_mutex_key#3){--..}, at: [&lt;c40c9a9e&gt;] configfs_add_file+0x2e/0x70

but task is already holding lock:
 (&amp;sb-&gt;s_type-&gt;i_mutex_key#3){--..}, at: [&lt;c40ca985&gt;] configfs_register_subsystem+0x55/0x130

other info that might help us debug this:
1 lock held by swapper/1:
 #0:  (&amp;sb-&gt;s_type-&gt;i_mutex_key#3){--..}, at: [&lt;c40ca985&gt;] configfs_register_subsystem+0x55/0x130

stack backtrace:
Pid: 1, comm: swapper Not tainted 2.6.24-rc6 #145
 [&lt;c40053ba&gt;] show_trace_log_lvl+0x1a/0x30
 [&lt;c4005e82&gt;] show_trace+0x12/0x20
 [&lt;c400687e&gt;] dump_stack+0x6e/0x80
 [&lt;c404ec72&gt;] __lock_acquire+0xe62/0x1120
 [&lt;c404efb2&gt;] lock_acquire+0x82/0xa0
 [&lt;c43fda88&gt;] mutex_lock_nested+0x98/0x2e0
 [&lt;c40c9a9e&gt;] configfs_add_file+0x2e/0x70
 [&lt;c40c9b0c&gt;] configfs_create_file+0x2c/0x40
 [&lt;c40ca639&gt;] configfs_attach_item+0x139/0x220
 [&lt;c40ca734&gt;] configfs_attach_group+0x14/0x140
 [&lt;c40ca7e9&gt;] configfs_attach_group+0xc9/0x140
 [&lt;c40ca9f6&gt;] configfs_register_subsystem+0xc6/0x130
 [&lt;c45c8186&gt;] init_netconsole+0x2b6/0x300
 [&lt;c45a75f2&gt;] kernel_init+0x142/0x320
 [&lt;c4004fb3&gt;] kernel_thread_helper+0x7/0x14
 =======================

Signed-off-by: Joonwoo Park &lt;joonwpark81@gmail.com&gt;
Signed-off-by: Joel Becker &lt;joel.becker@oracle.com&gt;
Signed-off-by: Mark Fasheh &lt;mark.fasheh@oracle.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
configfs_register_subsystem() with default_groups triggers recursive locking.
it seems that mutex_lock_nested is needed.

=============================================
[ INFO: possible recursive locking detected ]
2.6.24-rc6 #145
---------------------------------------------
swapper/1 is trying to acquire lock:
 (&amp;sb-&gt;s_type-&gt;i_mutex_key#3){--..}, at: [&lt;c40c9a9e&gt;] configfs_add_file+0x2e/0x70

but task is already holding lock:
 (&amp;sb-&gt;s_type-&gt;i_mutex_key#3){--..}, at: [&lt;c40ca985&gt;] configfs_register_subsystem+0x55/0x130

other info that might help us debug this:
1 lock held by swapper/1:
 #0:  (&amp;sb-&gt;s_type-&gt;i_mutex_key#3){--..}, at: [&lt;c40ca985&gt;] configfs_register_subsystem+0x55/0x130

stack backtrace:
Pid: 1, comm: swapper Not tainted 2.6.24-rc6 #145
 [&lt;c40053ba&gt;] show_trace_log_lvl+0x1a/0x30
 [&lt;c4005e82&gt;] show_trace+0x12/0x20
 [&lt;c400687e&gt;] dump_stack+0x6e/0x80
 [&lt;c404ec72&gt;] __lock_acquire+0xe62/0x1120
 [&lt;c404efb2&gt;] lock_acquire+0x82/0xa0
 [&lt;c43fda88&gt;] mutex_lock_nested+0x98/0x2e0
 [&lt;c40c9a9e&gt;] configfs_add_file+0x2e/0x70
 [&lt;c40c9b0c&gt;] configfs_create_file+0x2c/0x40
 [&lt;c40ca639&gt;] configfs_attach_item+0x139/0x220
 [&lt;c40ca734&gt;] configfs_attach_group+0x14/0x140
 [&lt;c40ca7e9&gt;] configfs_attach_group+0xc9/0x140
 [&lt;c40ca9f6&gt;] configfs_register_subsystem+0xc6/0x130
 [&lt;c45c8186&gt;] init_netconsole+0x2b6/0x300
 [&lt;c45a75f2&gt;] kernel_init+0x142/0x320
 [&lt;c4004fb3&gt;] kernel_thread_helper+0x7/0x14
 =======================

Signed-off-by: Joonwoo Park &lt;joonwpark81@gmail.com&gt;
Signed-off-by: Joel Becker &lt;joel.becker@oracle.com&gt;
Signed-off-by: Mark Fasheh &lt;mark.fasheh@oracle.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>[PATCH] configsfs buffer: use mutex</title>
<updated>2007-07-11T00:10:58+00:00</updated>
<author>
<name>Johannes Berg</name>
<email>johannes@sipsolutions.net</email>
</author>
<published>2007-06-22T09:20:00+00:00</published>
<link rel='alternate' type='text/html' href='https://git.toradex.cn/cgit/linux-toradex.git/commit/?id=6d748924b753d63a57dad130fdf11f64c27ff54b'/>
<id>6d748924b753d63a57dad130fdf11f64c27ff54b</id>
<content type='text'>
Seems copied from sysfs, but I don't see a reason here nor there to use
a semaphore instead of a mutex. Convert.

Signed-off-by: Johannes Berg &lt;johannes@sipsolutions.net&gt;
Signed-off-by: Joel Becker &lt;joel.becker@oracle.com&gt;
Signed-off-by: Mark Fasheh &lt;mark.fasheh@oracle.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Seems copied from sysfs, but I don't see a reason here nor there to use
a semaphore instead of a mutex. Convert.

Signed-off-by: Johannes Berg &lt;johannes@sipsolutions.net&gt;
Signed-off-by: Joel Becker &lt;joel.becker@oracle.com&gt;
Signed-off-by: Mark Fasheh &lt;mark.fasheh@oracle.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>configfs: consistent attribute size</title>
<updated>2007-07-10T23:52:22+00:00</updated>
<author>
<name>Joel Becker</name>
<email>joel.becker@oracle.com</email>
</author>
<published>2007-06-22T20:07:02+00:00</published>
<link rel='alternate' type='text/html' href='https://git.toradex.cn/cgit/linux-toradex.git/commit/?id=b23cdde4c6240d70bb3d2e3c4046b60d6f6c8451'/>
<id>b23cdde4c6240d70bb3d2e3c4046b60d6f6c8451</id>
<content type='text'>
The attribute store/show code currently limits attributes at PAGE_SIZE.
This code comes from sysfs, where it still works that way.

However, PAGE_SIZE is not constant.  A 16k attribute string works on
ia64 but not on x86.  Really a subsystem shouldn't allow different
attribute sizes based on platform.

As such, limit all simple attributes to 4k.  This works on all
platforms, and is consistent with all current code.

Signed-off-by: Joel Becker &lt;joel.becker@oracle.com&gt;
Signed-off-by: Mark Fasheh &lt;mark.fasheh@oracle.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
The attribute store/show code currently limits attributes at PAGE_SIZE.
This code comes from sysfs, where it still works that way.

However, PAGE_SIZE is not constant.  A 16k attribute string works on
ia64 but not on x86.  Really a subsystem shouldn't allow different
attribute sizes based on platform.

As such, limit all simple attributes to 4k.  This works on all
platforms, and is consistent with all current code.

Signed-off-by: Joel Becker &lt;joel.becker@oracle.com&gt;
Signed-off-by: Mark Fasheh &lt;mark.fasheh@oracle.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>use simple_read_from_buffer() in fs/</title>
<updated>2007-05-09T19:30:49+00:00</updated>
<author>
<name>Akinobu Mita</name>
<email>akinobu.mita@gmail.com</email>
</author>
<published>2007-05-09T09:33:32+00:00</published>
<link rel='alternate' type='text/html' href='https://git.toradex.cn/cgit/linux-toradex.git/commit/?id=92f4c701aad794de9e4cf7341d0a486aed027c46'/>
<id>92f4c701aad794de9e4cf7341d0a486aed027c46</id>
<content type='text'>
Cleanup using simple_read_from_buffer() in binfmt_misc, configfs, and sysfs.

Cc: Greg Kroah-Hartman &lt;gregkh@suse.de&gt;
Cc: Joel Becker &lt;joel.becker@oracle.com&gt;
Signed-off-by: Akinobu Mita &lt;akinobu.mita@gmail.com&gt;
Signed-off-by: Andrew Morton &lt;akpm@linux-foundation.org&gt;
Signed-off-by: Linus Torvalds &lt;torvalds@linux-foundation.org&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Cleanup using simple_read_from_buffer() in binfmt_misc, configfs, and sysfs.

Cc: Greg Kroah-Hartman &lt;gregkh@suse.de&gt;
Cc: Joel Becker &lt;joel.becker@oracle.com&gt;
Signed-off-by: Akinobu Mita &lt;akinobu.mita@gmail.com&gt;
Signed-off-by: Andrew Morton &lt;akpm@linux-foundation.org&gt;
Signed-off-by: Linus Torvalds &lt;torvalds@linux-foundation.org&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>configfs: Zero terminate data in configfs attribute writes.</title>
<updated>2007-02-07T20:17:08+00:00</updated>
<author>
<name>Joel Becker</name>
<email>joel.becker@oracle.com</email>
</author>
<published>2007-01-24T01:00:45+00:00</published>
<link rel='alternate' type='text/html' href='https://git.toradex.cn/cgit/linux-toradex.git/commit/?id=ff05d1c4643dd4260eb699396043d7e8009c0de4'/>
<id>ff05d1c4643dd4260eb699396043d7e8009c0de4</id>
<content type='text'>
Attributes in configfs are text files.  As such, most handlers expect to be
able to call functions like simple_strtoul() without checking the bounds
of the buffer.  Change the call to zero terminate the buffer before calling
the client's -&gt;store() method.  This does reduce the attribute size from
PAGE_SIZE to PAGE_SIZE-1.

Also, change get_zeroed_page() to alloc_page(), as we are handling the
termination.

Signed-off-by: Joel Becker &lt;joel.becker@oracle.com&gt;
Signed-off-by: Mark Fasheh &lt;mark.fasheh@oracle.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Attributes in configfs are text files.  As such, most handlers expect to be
able to call functions like simple_strtoul() without checking the bounds
of the buffer.  Change the call to zero terminate the buffer before calling
the client's -&gt;store() method.  This does reduce the attribute size from
PAGE_SIZE to PAGE_SIZE-1.

Also, change get_zeroed_page() to alloc_page(), as we are handling the
termination.

Signed-off-by: Joel Becker &lt;joel.becker@oracle.com&gt;
Signed-off-by: Mark Fasheh &lt;mark.fasheh@oracle.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>[PATCH] configfs: change uses of f_{dentry, vfsmnt} to use f_path</title>
<updated>2006-12-08T16:28:43+00:00</updated>
<author>
<name>Josef "Jeff" Sipek</name>
<email>jsipek@cs.sunysb.edu</email>
</author>
<published>2006-12-08T10:36:47+00:00</published>
<link rel='alternate' type='text/html' href='https://git.toradex.cn/cgit/linux-toradex.git/commit/?id=867fa491a2722cee6964a30dfda86e0e02dcb400'/>
<id>867fa491a2722cee6964a30dfda86e0e02dcb400</id>
<content type='text'>
Change all the uses of f_{dentry,vfsmnt} to f_path.{dentry,mnt} in the
configfs filesystem.

Signed-off-by: Josef "Jeff" Sipek &lt;jsipek@cs.sunysb.edu&gt;
Signed-off-by: Andrew Morton &lt;akpm@osdl.org&gt;
Signed-off-by: Linus Torvalds &lt;torvalds@osdl.org&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Change all the uses of f_{dentry,vfsmnt} to f_path.{dentry,mnt} in the
configfs filesystem.

Signed-off-by: Josef "Jeff" Sipek &lt;jsipek@cs.sunysb.edu&gt;
Signed-off-by: Andrew Morton &lt;akpm@osdl.org&gt;
Signed-off-by: Linus Torvalds &lt;torvalds@osdl.org&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>configfs: handle kzalloc() failure in check_perm()</title>
<updated>2006-10-20T22:29:00+00:00</updated>
<author>
<name>Chandra Seetharaman</name>
<email>sekharan@us.ibm.com</email>
</author>
<published>2006-10-10T22:15:55+00:00</published>
<link rel='alternate' type='text/html' href='https://git.toradex.cn/cgit/linux-toradex.git/commit/?id=559c9ac391c046710bdeee5581dc5d9dda794881'/>
<id>559c9ac391c046710bdeee5581dc5d9dda794881</id>
<content type='text'>
check_perm() does not drop the reference to the module when kzalloc()
failure occurs.

Signed-Off-By: Chandra Seetharaman &lt;sekharan@us.ibm.com&gt;
Signed-off-by: Joel Becker &lt;joel.becker@oracle.com&gt;
Signed-off-by: Mark Fasheh &lt;mark.fasheh@oracle.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
check_perm() does not drop the reference to the module when kzalloc()
failure occurs.

Signed-Off-By: Chandra Seetharaman &lt;sekharan@us.ibm.com&gt;
Signed-off-by: Joel Becker &lt;joel.becker@oracle.com&gt;
Signed-off-by: Mark Fasheh &lt;mark.fasheh@oracle.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>[PATCH] pr_debug: configfs: use size_t length modifier in pr_debug format argument</title>
<updated>2006-10-03T15:04:19+00:00</updated>
<author>
<name>Zach Brown</name>
<email>zach.brown@oracle.com</email>
</author>
<published>2006-10-03T08:16:05+00:00</published>
<link rel='alternate' type='text/html' href='https://git.toradex.cn/cgit/linux-toradex.git/commit/?id=4779efca147475a708e84d902e096bbd20e613b7'/>
<id>4779efca147475a708e84d902e096bbd20e613b7</id>
<content type='text'>
configfs: use size_t length modifier in pr_debug format argument

Signed-off-by: Zach Brown &lt;zach.brown@oracle.com&gt;
Acked-by: Joel Becker &lt;joel.becker@oracle.com&gt;
Signed-off-by: Andrew Morton &lt;akpm@osdl.org&gt;
Signed-off-by: Linus Torvalds &lt;torvalds@osdl.org&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
configfs: use size_t length modifier in pr_debug format argument

Signed-off-by: Zach Brown &lt;zach.brown@oracle.com&gt;
Acked-by: Joel Becker &lt;joel.becker@oracle.com&gt;
Signed-off-by: Andrew Morton &lt;akpm@osdl.org&gt;
Signed-off-by: Linus Torvalds &lt;torvalds@osdl.org&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>[PATCH] fs: Conversions from kmalloc+memset to k(z|c)alloc</title>
<updated>2006-09-27T15:26:10+00:00</updated>
<author>
<name>Panagiotis Issaris</name>
<email>takis@issaris.org</email>
</author>
<published>2006-09-27T08:49:37+00:00</published>
<link rel='alternate' type='text/html' href='https://git.toradex.cn/cgit/linux-toradex.git/commit/?id=f8314dc60ccba7e41f425048c4160dc7f63377d5'/>
<id>f8314dc60ccba7e41f425048c4160dc7f63377d5</id>
<content type='text'>
Conversions from kmalloc+memset to kzalloc.

Signed-off-by: Panagiotis Issaris &lt;takis@issaris.org&gt;
Jffs2-bit-acked-by: David Woodhouse &lt;dwmw2@infradead.org&gt;
Signed-off-by: Andrew Morton &lt;akpm@osdl.org&gt;
Signed-off-by: Linus Torvalds &lt;torvalds@osdl.org&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Conversions from kmalloc+memset to kzalloc.

Signed-off-by: Panagiotis Issaris &lt;takis@issaris.org&gt;
Jffs2-bit-acked-by: David Woodhouse &lt;dwmw2@infradead.org&gt;
Signed-off-by: Andrew Morton &lt;akpm@osdl.org&gt;
Signed-off-by: Linus Torvalds &lt;torvalds@osdl.org&gt;
</pre>
</div>
</content>
</entry>
</feed>
