linux-toradex.git/fs/devpts, branch v2.6.30-rc8

devpts: correctly set default options

2009-05-15T15:03:23+00:00

devpts_get_sb() calls memset(0) to clear mount options and calls
parse_mount_options() if user specified any mount options.

The memset(0) is bogus since the 'mode' and 'ptmxmode' options are
non-zero by default.  parse_mount_options() restores options to default
anyway and can properly deal with NULL mount options.

So in devpts_get_sb() remove memset(0) and call parse_mount_options() even
for NULL mount options.

Bug reported by Eric Paris: http://lkml.org/lkml/2009/5/7/448.

Signed-off-by: Sukadev Bhattiprolu 
Tested-by: Marc Dionne 
Reported-by: Eric Paris 
Cc: Christoph Hellwig 
Cc: Alan Cox 
Acked-by: Serge Hallyn 
Cc: Al Viro 
Cc: "Rafael J. Wysocki" 
Reviewed-by: "H. Peter Anvin" 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

Convert obvious places to deactivate_locked_super()

2009-05-09T14:49:40+00:00

Signed-off-by: Al Viro

Merge code for single and multiple-instance mounts

2009-03-27T18:44:04+00:00

new_pts_mount() (including the get_sb_nodev()), shares a lot of code
with init_pts_mount(). The only difference between them is the 'test-super'
function passed into sget().

Move all common code into devpts_get_sb() and remove the new_pts_mount() and
init_pts_mount() functions,

Changelog[v3]:
	[Serge Hallyn]: Remove unnecessary printk()s
Changelog[v2]:
	(Christoph Hellwig): Merge code in 'do_pts_mount()' into devpts_get_sb()

Signed-off-by: Sukadev Bhattiprolu 
Acked-by: Serge Hallyn 
Tested-by: Serge Hallyn 
Signed-off-by: Al Viro

Remove get_init_pts_sb()

2009-03-27T18:44:04+00:00

With mknod_ptmx() moved to devpts_get_sb(), init_pts_mount() becomes
a wrapper around get_init_pts_sb(). Remove get_init_pts_sb() and
fold code into init_pts_mount().

Signed-off-by: Sukadev Bhattiprolu 
Acked-by: Serge Hallyn 
Signed-off-by: Al Viro

Move common mknod_ptmx() calls into caller

2009-03-27T18:44:04+00:00

We create 'ptmx' node in both single-instance and multiple-instance
mounts. So devpts_get_sb() can call mknod_ptmx() once rather than
have both modes calling mknod_ptmx() separately.

Signed-off-by: Sukadev Bhattiprolu 
Acked-by: Serge Hallyn 
Signed-off-by: Al Viro

Parse mount options just once and copy them to super block

2009-03-27T18:44:04+00:00

Since all the mount option parsing is done in devpts, we could do it
just once and pass it around in devpts functions and eventually store
it in the super block.

Signed-off-by: Sukadev Bhattiprolu 
Signed-off-by: Al Viro

Unroll essentials of do_remount_sb() into devpts

2009-03-27T18:44:03+00:00

On remount, devpts fs only needs to parse the mount options. Users cannot
directly create/dirty files in /dev/pts so the MS_RDONLY flag and
shrinking the dcache does not really apply to devpts.

So effectively on remount, devpts only parses the mount options and updates
these options in its super block. As such, we could replace do_remount_sb()
call with a direct parse_mount_options().

Doing so enables subsequent patches to avoid parsing the mount options twice
and simplify the code.

Signed-off-by: Sukadev Bhattiprolu 
Acked-by: Serge Hallyn 
Signed-off-by: Al Viro

vfs: simple_set_mnt() should return void

2009-03-27T18:44:03+00:00

simple_set_mnt() is defined as returning 'int' but always returns 0.
Callers assume simple_set_mnt() never fails and don't properly cleanup if
it were to _ever_ fail.  For instance, get_sb_single() and get_sb_nodev()
should:

        up_write(sb->s_unmount);
        deactivate_super(sb);

if simple_set_mnt() fails.

Since simple_set_mnt() never fails, would be cleaner if it did not
return anything.

[akpm@linux-foundation.org: fix build]
Signed-off-by: Sukadev Bhattiprolu 
Acked-by: Serge Hallyn 
Cc: Al Viro 
Cc: Christoph Hellwig 
Signed-off-by: Andrew Morton 
Signed-off-by: Al Viro

devpts: Must release s_umount on error

2009-03-27T18:43:59+00:00

We should drop the ->s_umount mutex if an error occurs after the
sget()/grab_super() call. This was introduced when adding support
for multiple instances of devpts and noticed during a code review/reorg.

Signed-off-by: Sukadev Bhattiprolu 
Signed-off-by: Al Viro

devpts: remove graffiti

2009-03-10T22:55:11+00:00

Very annoying when working with containters.

Signed-off-by: Alexey Dobriyan 
Cc: Alan Cox 
Cc: "H. Peter Anvin" 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds