linux-toradex.git/fs/dlm/config.c, branch v3.16.2

fs/dlm/config.c: convert simple_str to kstr

2014-06-06T23:08:17+00:00

Replace obsolete functions

simple_strtoul/kstrtouint
simple_strtol/kstrtoint
(kstr __must_check requires the right function to be applied)

Signed-off-by: Fabian Frederick 
Cc: Christine Caulfield 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

dlm: config: using strlcpy instead of strncpy

2013-06-25T17:53:06+00:00

for NUL terminated string, need alway set '\0' in the end.

Signed-off-by: Zhao Hongjiang 
Signed-off-by: David Teigland

fs: change return values from -EACCES to -EPERM

2013-02-26T07:46:14+00:00

According to SUSv3:

[EACCES] Permission denied. An attempt was made to access a file in a way
forbidden by its file access permissions.

[EPERM] Operation not permitted. An attempt was made to perform an operation
limited to processes with appropriate privileges or to the owner of a file
or other resource.

So -EPERM should be returned if capability checks fails.

Strictly speaking this is an API change since the error code user sees is
altered.

Signed-off-by: Zhao Hongjiang 
Acked-by: Jan Kara 
Acked-by: Steven Whitehouse 
Acked-by: Ian Kent 
Cc: Al Viro 
Signed-off-by: Andrew Morton 
Signed-off-by: Al Viro

dlm: fix deadlock between dlm_send and dlm_controld

2012-08-08T16:33:35+00:00

A deadlock sometimes occurs between dlm_controld closing
a lowcomms connection through configfs and dlm_send looking
up the address for a new connection in configfs.

dlm_controld does a configfs rmdir which calls
dlm_lowcomms_close which waits for dlm_send to
cancel work on the workqueues.

The dlm_send workqueue thread has called
tcp_connect_to_sock which calls dlm_nodeid_to_addr
which does a configfs lookup and blocks on a lock
held by dlm_controld in the rmdir path.

The solution here is to save the node addresses within
the lowcomms code so that the lowcomms workqueue does
not need to step through configfs to get a node address.

dlm_controld:
wait_for_completion+0x1d/0x20
__cancel_work_timer+0x1b3/0x1e0
cancel_work_sync+0x10/0x20
dlm_lowcomms_close+0x4c/0xb0 [dlm]
drop_comm+0x22/0x60 [dlm]
client_drop_item+0x26/0x50 [configfs]
configfs_rmdir+0x180/0x230 [configfs]
vfs_rmdir+0xbd/0xf0
do_rmdir+0x103/0x120
sys_rmdir+0x16/0x20

dlm_send:
mutex_lock+0x2b/0x50
get_comm+0x34/0x140 [dlm]
dlm_nodeid_to_addr+0x18/0xd0 [dlm]
tcp_connect_to_sock+0xf4/0x2d0 [dlm]
process_send_sockets+0x1d2/0x260 [dlm]
worker_thread+0x170/0x2a0

Signed-off-by: David Teigland

dlm: use rsbtbl as resource directory

2012-07-16T19:16:19+00:00

Remove the dir hash table (dirtbl), and use
the rsb hash table (rsbtbl) as the resource
directory.  It has always been an unnecessary
duplication of information.

This improves efficiency by using a single rsbtbl
lookup in many cases where both rsbtbl and dirtbl
lookups were needed previously.

This eliminates the need to handle cases of rsbtbl
and dirtbl being out of sync.

In many cases there will be memory savings because
the dir hash table no longer exists.

Signed-off-by: David Teigland

dlm: add recovery callbacks

2012-01-04T14:56:31+00:00

These new callbacks notify the dlm user about lock recovery.
GFS2, and possibly others, need to be aware of when the dlm
will be doing lock recovery for a failed lockspace member.

In the past, this coordination has been done between dlm and
file system daemons in userspace, which then direct their
kernel counterparts.  These callbacks allow the same
coordination directly, and more simply.

Signed-off-by: David Teigland

dlm: improve rsb searches

2011-07-12T21:02:09+00:00

By pre-allocating rsb structs before searching the hash
table, they can be inserted immediately.  This avoids
always having to repeat the search when adding the struct
to hash list.

This also adds space to the rsb struct for a max resource
name, so an rsb allocation can be used by any request.
The constant size also allows us to finally use a slab
for the rsb structs.

Signed-off-by: David Teigland

dlm: keep lkbs in idr

2011-07-11T13:43:45+00:00

This is simpler and quicker than the hash table, and
avoids needing to search the hash list for every new
lkid to check if it's used.

Signed-off-by: David Teigland

dlm: show addresses in configfs

2011-06-30T19:45:28+00:00

Display all addresses the dlm is using for the local node
from the configfs file config/dlm//comms//addr_list
Also make the addr file write only.

Signed-off-by: Masatake YAMATO 
Signed-off-by: David Teigland

dlm: delayed reply message warning

2011-04-01T19:19:06+00:00

Add an option (disabled by default) to print a warning message
when a lock has been waiting a configurable amount of time for
a reply message from another node.  This is mainly for debugging.

Signed-off-by: David Teigland