linux-toradex.git/fs/dlm/lowcomms.c, branch v4.17-rc7

net: make getname() functions return length rather than use int* parameter

2018-02-12T19:15:04+00:00

Changes since v1:
Added changes in these files:
    drivers/infiniband/hw/usnic/usnic_transport.c
    drivers/staging/lustre/lnet/lnet/lib-socket.c
    drivers/target/iscsi/iscsi_target_login.c
    drivers/vhost/net.c
    fs/dlm/lowcomms.c
    fs/ocfs2/cluster/tcp.c
    security/tomoyo/network.c

Before:
All these functions either return a negative error indicator,
or store length of sockaddr into "int *socklen" parameter
and return zero on success.

"int *socklen" parameter is awkward. For example, if caller does not
care, it still needs to provide on-stack storage for the value
it does not need.

None of the many FOO_getname() functions of various protocols
ever used old value of *socklen. They always just overwrite it.

This change drops this parameter, and makes all these functions, on success,
return length of sockaddr. It's always >= 0 and can be differentiated
from an error.

Tests in callers are changed from "if (err)" to "if (err < 0)", where needed.

rpc_sockname() lost "int buflen" parameter, since its only use was
to be passed to kernel_getsockname() as &buflen and subsequently
not used in any way.

Userspace API is not changed.

    text    data     bss      dec     hex filename
30108430 2633624  873672 33615726 200ef6e vmlinux.before.o
30108109 2633612  873672 33615393 200ee21 vmlinux.o

Signed-off-by: Denys Vlasenko 
CC: David S. Miller 
CC: linux-kernel@vger.kernel.org
CC: netdev@vger.kernel.org
CC: linux-bluetooth@vger.kernel.org
CC: linux-decnet-user@lists.sourceforge.net
CC: linux-wireless@vger.kernel.org
CC: linux-rdma@vger.kernel.org
CC: linux-sctp@vger.kernel.org
CC: linux-nfs@vger.kernel.org
CC: linux-x25@vger.kernel.org
Signed-off-by: David S. Miller

dlm: switch to sock_recvmsg()

2017-12-03T01:37:47+00:00

Signed-off-by: Al Viro

DLM: fix NULL pointer dereference in send_to_sock()

2017-09-25T17:45:21+00:00

The writequeue and writequeue_lock member of othercon was not initialized.
If lowcomms_state_change() is called from network layer, othercon->swork
may be scheduled. In this case, send_to_sock() will generate a NULL pointer
reference. We avoid this problem by correctly initializing writequeue and
writequeue_lock member of othercon.

Signed-off-by: Tadashi Miyauchi 
Signed-off-by: Tsutomu Owa 
Signed-off-by: David Teigland

DLM: fix to reschedule rwork

2017-09-25T17:45:21+00:00

When an error occurs in kernel_recvmsg or kernel_sendpage and
close_connection is called and receive work is already scheduled,
receive work is canceled. In that case, the receive work will not
be scheduled forever after reconnection, because CF_READ_PENDING
flag is established.

Signed-off-by: Tadashi Miyauchi 
Signed-off-by: Tsutomu Owa 
Signed-off-by: David Teigland

DLM: fix to use sk_callback_lock correctly

2017-09-25T17:45:21+00:00

In the current implementation, we think that exclusion control between
processing to set the callback function to the connection structure and
processing to refer to the connection structure from the callback function
was not enough. We fix them.

Signed-off-by: Tadashi Miyauchi 
Signed-off-by: Tsutomu Owa 
Signed-off-by: David Teigland

DLM: fix memory leak in tcp_accept_from_sock()

2017-09-25T17:45:21+00:00

The sk member of the socket generated by sock_create_kern() is overwritten
by ops->accept(). So the previous sk will not be released.
We use kernel_accept() instead of sock_create_kern() and ops->accept().

Signed-off-by: Tadashi Miyauchi 
Signed-off-by: Tsutomu Owa 
Signed-off-by: David Teigland

DLM: use CF_CLOSE flag to stop dlm_send correctly

2017-09-25T17:45:21+00:00

If reconnection fails while executing dlm_lowcomms_stop,
dlm_send will not stop.

Signed-off-by: Tadashi Miyauchi 
Signed-off-by: Tsutomu Owa 
Signed-off-by: David Teigland

DLM: Reanimate CF_WRITE_PENDING flag

2017-09-25T17:45:21+00:00

CF_WRITE_PENDING flag has been reanimated to make dlm_send stop properly
when running dlm_lowcomms_stop.

Signed-off-by: Tadashi Miyauchi 
Signed-off-by: Tsutomu Owa 
Signed-off-by: David Teigland

DLM: close othercon at send/receive error

2017-09-25T17:45:21+00:00

If an error occurs in the sending / receiving process, if othercon
exists, sending / receiving processing using othercon may also result
in an error. We fix to pre-close othercon as well.

Signed-off-by: Tadashi Miyauchi 
Signed-off-by: Tsutomu Owa 
Signed-off-by: David Teigland

DLM: fix to use sock_mutex correctly in xxx_accept_from_sock

2017-09-25T17:45:21+00:00

In the current implementation, we think that exclusion control
for othercon in tcp_accept_from_sock() and sctp_accept_from_sock()
was not enough. We fix them.

Signed-off-by: Tadashi Miyauchi 
Signed-off-by: Tsutomu Owa 
Signed-off-by: David Teigland