linux-toradex.git/fs/dlm, branch v2.6.21

[DLM] fs/dlm/user.c should #include "user.h"

2007-03-07T18:58:21+00:00

Every file should include the headers containing the prototypes for
it's global functions.

Signed-off-by: Adrian Bunk 
Signed-off-by: Steven Whitehouse

[PATCH] mark struct file_operations const 6

2007-02-12T17:48:45+00:00

Many struct file_operations in the kernel can be "const".  Marking them const
moves these to the .rodata section, which avoids false sharing with potential
dirty data.  In addition it'll catch accidental writes at compile time to
these shared resources.

Signed-off-by: Arjan van de Ven 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

[PATCH] Transform kmem_cache_alloc()+memset(0) -> kmem_cache_zalloc().

2007-02-11T18:51:27+00:00

Replace appropriate pairs of "kmem_cache_alloc()" + "memset(0)" with the
corresponding "kmem_cache_zalloc()" call.

Signed-off-by: Robert P. J. Day 
Cc: "Luck, Tony" 
Cc: Andi Kleen 
Cc: Roland McGrath 
Cc: James Bottomley 
Cc: Greg KH 
Acked-by: Joel Becker 
Cc: Steven Whitehouse 
Cc: Jan Kara 
Cc: Michael Halcrow 
Cc: "David S. Miller" 
Cc: Stephen Smalley 
Cc: James Morris 
Cc: Chris Wright 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

[PATCH] dlm: use kern_recvmsg()

2007-02-09T17:14:06+00:00

Signed-off-by: Al Viro 
Signed-off-by: Linus Torvalds

[DLM] fix softlockup in dlm_recv

2007-02-05T18:38:27+00:00

This patch stops the dlm_recv workqueue from busy-waiting when a node
disconnects. This can cause soft lockup errors on debug systems and bad
performance generally.

Signed-Off-By: Patrick Caulfield 
Signed-off-by: Steven Whitehouse

[DLM] zero new user lvbs

2007-02-05T18:38:24+00:00

A new lvb for a userland lock wasn't being initialized to zero.

Signed-off-by: David Teigland 
Signed-off-by: Steven Whitehouse

[DLM/GFS2] indent help text

2007-02-05T18:38:20+00:00

Indent help text as expected.

Signed-off-by: Randy Dunlap 
Signed-off-by: Steven Whitehouse

[GFS2/DLM] fix GFS2 circular dependency

2007-02-05T18:38:08+00:00

On Sun, Jan 28, 2007 at 11:08:18AM +0100, Jiri Slaby wrote:
> Andrew Morton napsal(a):
> >Temporarily at
> >
> >	http://userweb.kernel.org/~akpm/2.6.20-rc6-mm1/
>
> Unable to select IPV6. Menuconfig doesn't offer it when INET is selected.
> When it's not it appears in the menu, but after state change it gets away.
> The same behaviour in xconfig, gconfig.
>
> $ mkdir ../a/tst
> $ make O=../a/tst menuconfig
>   HOSTCC  scripts/basic/fixdep
> [...]
>   HOSTLD  scripts/kconfig/mconf
> scripts/kconfig/mconf arch/i386/Kconfig
> Warning! Found recursive dependency: INET GFS2_FS_LOCKING_DLM SYSFS
> OCFS2_FS INET
>
> Maybe this is the problem?

Yes, patch below.

> regards,

cu
Adrian

<--  snip  -->

This patch fixes a circular dependency by letting GFS2_FS_LOCKING_DLM
and DLM depend on instead of select SYSFS.

Since SYSFS depends on EMBEDDED this change shouldn't cause any problems
for users.

Signed-off-by: Adrian Bunk 
Acked-by: Randy Dunlap 
Signed-off-by: Steven Whitehouse

[GFS2/DLM] use sysfs

2007-02-05T18:38:05+00:00

With CONFIG_DLM=m, CONFIG_PROC_FS=n, and CONFIG_SYSFS=n, kernel build
fails with:

WARNING: "kernel_subsys" [fs/gfs2/locking/dlm/lock_dlm.ko] undefined!
WARNING: "kernel_subsys" [fs/dlm/dlm.ko] undefined!
WARNING: "kernel_subsys" [fs/configfs/configfs.ko] undefined!
make[1]: *** [__modpost] Error 1
make: *** [modules] Error 2

Since fs/dlm/lockspace.c and fs/gfs2/locking/dlm/sysfs.c use
kernel_subsys, they should either DEPEND on it or SELECT it.

Signed-off-by: Randy Dunlap 
Signed-off-by: Steven Whitehouse

[DLM] can miss clearing resend flag

2007-02-05T18:37:50+00:00

A long, complicated sequence of events, beginning with the RESEND flag not
being cleared on an lkb, can result in an unlock never completing.

- lkb on waiters list for remote lookup
- the remote node is both the dir node and the master node, so
  it optimizes the lookup into a request and sends a request
  reply back
- the request reply is saved on the requestqueue to be processed
  after recovery
- recovery runs dlm_recover_waiters_pre() which sets RESEND flag
  so the lookup will be resent after recovery
- end of recovery: process_requestqueue takes saved request reply
  which removes the lkb off the waitesr list, _without_ clearing
  the RESEND flag
- end of recovery: dlm_recover_waiters_post() doesn't do anything
  with the now completed lookup lkb (would usually clear RESEND)
- later, the node unmounts, unlocks this lkb that still has RESEND
  flag set
- the lkb is on the waiters list again, now for unlock, when recovery
  occurs, dlm_recover_waiters_pre() shows the lkb for unlock with RESEND
  set, doesn't do anything since the master still exists
- end of recovery: dlm_recover_waiters_post() takes this lkb off
  the waiters list because it has the RESEND flag set, then reports
  an error because unlocks are never supposed to be handled in
  recover_waiters_post().
- later, the unlock reply is received, doesn't find the lkb on
  the waiters list because recover_waiters_post() has wrongly
  removed it.
- the unlock operation has been lost, and we're left with a
  stray granted lock
- unmount spins waiting for the unlock to complete

The visible evidence of this problem will be a node where gfs umount is
spinning, the dlm waiters list will be empty, and the dlm locks list will
show a granted lock.

The fix is simply to clear the RESEND flag when taking an lkb off the
waiters list.

Signed-off-by: David Teigland 
Signed-off-by: Steven Whitehouse