linux-toradex.git/fs/dlm, branch v3.11.4

dlm: kill the unnecessary and wrong device_close()->recalc_sigpending()

2013-08-09T17:48:20+00:00

device_close()->recalc_sigpending() is not needed, sigprocmask() takes
care of TIF_SIGPENDING correctly.

And without ->siglock it is racy and wrong, it can wrongly clear
TIF_SIGPENDING and miss a signal.

But even with this patch device_close() is still buggy:

  1. sigprocmask() should not be used, we have set_task_blocked(),
     but this is minor.

  2. We should never block SIGKILL or SIGSTOP, and this is what
     the code tries to do.

  3. This can't protect against SIGKILL or SIGSTOP anyway. Another
     thread can do signal_wake_up(), say, do_signal_stop() or
     complete_signal() or debugger.

  4. sigprocmask(SIG_BLOCK, allsigs) doesn't necessarily clears
     TIF_SIGPENDING, say, freezing() or ->jobctl.

  5. device_write() looks equally wrong by the same reason.

Looks like, this tries to protect some wait_event_interruptible() logic
from signals, it should be turned into uninterruptible wait.  Or we need
to implement something like signals_stop/start for such a use-case.

Signed-off-by: Oleg Nesterov 
Signed-off-by: Linus Torvalds

dlm: Avoid LVB truncation

2013-06-26T16:38:02+00:00

For lockspaces with an LVB length above 64 bytes, avoid truncating
the LVB while exchanging it with another node in the cluster.

Signed-off-by: Bart Van Assche 
Signed-off-by: David Teigland

dlm: log an error for unmanaged lockspaces

2013-06-25T17:53:20+00:00

Log an error message if the dlm user daemon exits
before all the lockspaces have been removed.

Signed-off-by: David Teigland

dlm: config: using strlcpy instead of strncpy

2013-06-25T17:53:06+00:00

for NUL terminated string, need alway set '\0' in the end.

Signed-off-by: Zhao Hongjiang 
Signed-off-by: David Teigland

dlm: remove duplicated include from lowcomms.c

2013-06-19T14:52:09+00:00

Remove duplicated include.

Signed-off-by: Wei Yongjun 
Signed-off-by: David Teigland

dlm: disable nagle for SCTP

2013-06-14T18:07:11+00:00

For TCP we disable Nagle and I cannot think of why it would be needed
for SCTP. When disabled it seems to improve dlm_lock operations like it
does for TCP.

Signed-off-by: Mike Christie 
Signed-off-by: David Teigland

dlm: retry failed SCTP sends

2013-06-14T18:07:11+00:00

Currently if a SCTP send fails, we lose the data we were trying
to send because the writequeue_entry is released when we do the send.
When this happens other nodes will then hang waiting for a reply.

This adds support for SCTP to retry the send operation.

I also removed the retry limit for SCTP use, because we want
to make sure we try every path during init time and for longer
failures we want to continually retry in case paths come back up
while trying other paths. We will do this until userspace tells us
to stop.

Signed-off-by: Mike Christie 
Signed-off-by: David Teigland

dlm: try other IPs when sctp init assoc fails

2013-06-14T18:07:11+00:00

Currently, if we cannot create a association to the first IP addr
that is added to DLM, the SCTP init assoc code will just retry
the same IP. This patch adds a simple failover schemes where we
will try one of the addresses that was passed into DLM.

Signed-off-by: Mike Christie 
Signed-off-by: David Teigland

dlm: clear correct bit during sctp init failure handling

2013-06-14T18:07:11+00:00

We should be testing and cleaing the init pending bit because later
when sctp_init_assoc is recalled it will be checking that it is not set
and set the bit.

We do not want to touch CF_CONNECT_PENDING here because we will queue
swork and process_send_sockets will then call the connect_action function.

Signed-off-by: Mike Christie 
Signed-off-by: David Teigland

dlm: set sctp assoc id during setup

2013-06-14T18:07:10+00:00

sctp_assoc was not getting set so later lookups failed.

Signed-off-by: Mike Christie 
Signed-off-by: David Teigland