linux-toradex.git/fs/ecryptfs/inode.c, branch v2.6.30.2

eCryptfs: Fix min function comparison warning

2009-04-27T18:31:12+00:00

This warning shows up on 64 bit builds:

fs/ecryptfs/inode.c:693: warning: comparison of distinct pointer types
lacks a cast

Signed-off-by: Tyler Hicks

ecryptfs: fix printk format warning

2009-04-27T18:10:06+00:00

fs/ecryptfs/inode.c:670: warning: format '%d' expects type 'int', but argument 3 has type 'size_t'

Signed-off-by: Randy Dunlap 
Signed-off-by: Tyler Hicks 
Cc: Dustin Kirkland 
Signed-off-by: Andrew Morton

eCryptfs: Larger buffer for encrypted symlink targets

2009-04-22T22:02:46+00:00

When using filename encryption with eCryptfs, the value of the symlink
in the lower filesystem is encrypted and stored as a Tag 70 packet.
This results in a longer symlink target than if the target value wasn't
encrypted.

Users were reporting these messages in their syslog:

[ 45.653441] ecryptfs_parse_tag_70_packet: max_packet_size is [56]; real
packet size is [51]
[ 45.653444] ecryptfs_decode_and_decrypt_filename: Could not parse tag
70 packet from filename; copying through filename as-is

This was due to bufsiz, one the arguments in readlink(), being used to
when allocating the buffer passed to the lower inode's readlink().
That symlink target may be very large, but when decoded and decrypted,
could end up being smaller than bufsize.

To fix this, the buffer passed to the lower inode's readlink() will
always be PATH_MAX in size when filename encryption is enabled.  Any
necessary truncation occurs after the decoding and decrypting.

Signed-off-by: Tyler Hicks

eCryptfs: Lock lower directory inode mutex during lookup

2009-04-22T21:27:12+00:00

This patch locks the lower directory inode's i_mutex before calling
lookup_one_len() to find the appropriate dentry in the lower filesystem.
This bug was found thanks to the warning set in commit 2f9092e1.

Signed-off-by: Tyler Hicks

eCryptfs: Fix data corruption when using ecryptfs_passthrough

2009-04-22T08:54:13+00:00

ecryptfs_passthrough is a mount option that allows eCryptfs to allow
data to be written to non-eCryptfs files in the lower filesystem.  The
passthrough option was causing data corruption due to it not always
being treated as a non-eCryptfs file.

The first 8 bytes of an eCryptfs file contains the decrypted file size.
This value was being written to the non-eCryptfs files, too.  Also,
extra 0x00 characters were being written to make the file size a
multiple of PAGE_CACHE_SIZE.

Signed-off-by: Tyler Hicks

eCryptfs: NULL crypt_stat dereference during lookup

2009-03-22T18:20:43+00:00

If ecryptfs_encrypted_view or ecryptfs_xattr_metadata were being
specified as mount options, a NULL pointer dereference of crypt_stat
was possible during lookup.

This patch moves the crypt_stat assignment into
ecryptfs_lookup_and_interpose_lower(), ensuring that crypt_stat
will not be NULL before we attempt to dereference it.

Thanks to Dan Carpenter and his static analysis tool, smatch, for
finding this bug.

Signed-off-by: Tyler Hicks 
Acked-by: Dustin Kirkland 
Cc: Dan Carpenter 
Cc: Serge Hallyn 
Signed-off-by: Linus Torvalds

fs/ecryptfs/inode.c: cleanup kerneldoc

2009-01-06T23:59:22+00:00

Arguments lower_dentry and ecryptfs_dentry in ecryptfs_create_underlying_file()
have been merged into dentry, now fix it.

Signed-off-by: Qinghuang Feng 
Cc: Randy Dunlap 
Cc: Michael Halcrow 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

eCryptfs: Fix data types (int/size_t)

2009-01-06T23:59:22+00:00

Correct several format string data type specifiers.  Correct filename size
data types; they should be size_t rather than int when passed as
parameters to some other functions (although note that the filenames will
never be larger than int).

Signed-off-by: Michael Halcrow 
Cc: Dustin Kirkland 
Cc: Eric Sandeen 
Cc: Tyler Hicks 
Cc: David Kleikamp 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

eCryptfs: Filename Encryption: filldir, lookup, and readlink

2009-01-06T23:59:22+00:00

Make the requisite modifications to ecryptfs_filldir(), ecryptfs_lookup(),
and ecryptfs_readlink() to call out to filename encryption functions.
Propagate filename encryption policy flags from mount-wide crypt_stat to
inode crypt_stat.

Signed-off-by: Michael Halcrow 
Cc: Dustin Kirkland 
Cc: Eric Sandeen 
Cc: Tyler Hicks 
Cc: David Kleikamp 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

inode->i_op is never NULL

2009-01-05T16:54:28+00:00

We used to have rather schizophrenic set of checks for NULL ->i_op even
though it had been eliminated years ago.  You'd need to go out of your
way to set it to NULL explicitly _and_ a bunch of code would die on
such inodes anyway.  After killing two remaining places that still
did that bogosity, all that crap can go away.

Signed-off-by: Al Viro