linux-toradex.git/fs/ecryptfs, branch v2.6.21

[PATCH] eCryptfs: fix possible NULL ptr deref in ecryptfs_d_release()

2007-03-17T02:25:05+00:00

ecryptfs_d_release() first dereferences a pointer (via
ecryptfs_dentry_to_lower()) and then afterwards checks to see if the
pointer it just dereferenced is NULL (via ecryptfs_dentry_to_private()).

This patch moves all of the work done on the dereferenced pointer inside a
block governed by the condition that the pointer is non-NULL.

Signed-off-by: Michael Halcrow 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

[PATCH] ecryptfs: nested locking annotation

2007-03-08T15:39:16+00:00

ecryptfs uses a lock_parent() function, which I hope really locks the parents
and is not abused

Signed-off-by: Peter Zijlstra 
Cc: Michael Halcrow 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

[PATCH] ecryptfs: handle AOP_TRUNCATED_PAGE better

2007-03-05T15:57:53+00:00

- In fact we don't have to fail if AOP_TRUNCATED_PAGE was returned from
  prepare_write or commit_write. It is beter to retry attempt where it
  is possible.

- Rearange ecryptfs_get_lower_page() error handling logic, make it more clean.

Signed-off-by: Dmitriy Monakhov 
Acked-by: Michael Halcrow 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

[PATCH] ecryptfs: lower root result must be adirectory

2007-03-05T15:57:53+00:00

- Currently after path_lookup succeed we dot't have any guarantie what
  it is DIR. This must be explicitly demanded.
- path_lookup can't return negative dentry, So inode check is useless.

Signed-off-by: Dmitriy Monakhov 
Acked-by: Michael Halcrow 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

[PATCH] ecryptfs: check xattr operation support fix

2007-03-05T15:57:50+00:00

  - ecryptfs_write_inode_size_to_metadata() error code was ignored.
  - i_op->setxattr() must be supported by lower fs because used below.

Signed-off-by: Monakhov Dmitriy 
Acked-by: Michael Halcrow 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

[PATCH] eCryptfs: no path_release() after path_lookup() error

2007-03-01T22:53:38+00:00

Dmitriy Monakhov wrote:
> if path_lookup() return non zero code we don't have to worry about
> 'nd' parameter, but ecryptfs_read_super does path_release(&nd) after
> path_lookup has failed, and dentry counter becomes negative

Do not do a path_release after a path_lookup error.

Signed-off-by: Michael Halcrow 
Cc: Dmitriy Monakhov 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

[PATCH] eCryptfs: remove unnecessary flush_dcache_page()

2007-03-01T22:53:38+00:00

Remove unnecessary flush_dcache_page() call. Thanks to Dmitriy
Monakhov for pointing this out.

Signed-off-by: Michael Halcrow 
Cc: Dmitriy Monakhov 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

[PATCH] eCryptfs: set O_LARGEFILE when opening lower file

2007-03-01T22:53:37+00:00

O_LARGEFILE should be set here when opening the lower file.

Signed-off-by: Michael Halcrow 
Cc: Dmitriy Monakhov 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

[PATCH] eCryptfs: resolve lower page unlocking problem

2007-03-01T22:53:37+00:00

eCryptfs lower file handling code has several issues:
  - Retval from prepare_write()/commit_write() wasn't checked to equality
    to AOP_TRUNCATED_PAGE.
  - In some places page wasn't unmapped and unlocked after error.

Signed-off-by: Michael Halcrow 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

[PATCH] ecryptfs: fix forgotten format specifier

2007-02-16T16:14:01+00:00

Add format specifier %d for uid in ecryptfs_printk

Signed-off-by: Thomas Hisch 
Cc: Michael Halcrow 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds