linux-toradex.git/fs/ecryptfs, branch v2.6.38.2

eCryptfs: Copy up lower inode attrs in getattr

2011-02-21T20:46:36+00:00

The lower filesystem may do some type of inode revalidation during a
getattr call. eCryptfs should take advantage of that by copying the
lower inode attributes to the eCryptfs inode after a call to
vfs_getattr() on the lower inode.

I originally wrote this fix while working on eCryptfs on nfsv3 support,
but discovered it also fixed an eCryptfs on ext4 nanosecond timestamp
bug that was reported.

https://bugs.launchpad.net/bugs/613873

Cc: 
Signed-off-by: Tyler Hicks

ecryptfs: read on a directory should return EISDIR if not supported

2011-02-21T20:46:36+00:00

read() calls against a file descriptor connected to a directory are
incorrectly returning EINVAL rather than EISDIR:

  [EISDIR]
    [XSI] [Option Start] The fildes argument refers to a directory and the
    implementation does not allow the directory to be read using read()
    or pread(). The readdir() function should be used instead. [Option End]

This occurs because we do not have a .read operation defined for
ecryptfs directories.  Connect this up to generic_read_dir().

BugLink: http://bugs.launchpad.net/bugs/719691
Signed-off-by: Andy Whitcroft 
Signed-off-by: Tyler Hicks

eCryptfs: Handle NULL nameidata pointers

2011-02-21T20:45:57+00:00

Allow for NULL nameidata pointers in eCryptfs create, lookup, and
d_revalidate functions.

Signed-off-by: Tyler Hicks

eCryptfs: Revert "dont call lookup_one_len to avoid NULL nameidata"

2011-02-18T02:30:29+00:00

This reverts commit 21edad32205e97dc7ccb81a85234c77e760364c8 and commit
93c3fe40c279f002906ad14584c30671097d4394, which fixed a regression by
the former.

Al Viro pointed out bypassed dcache lookups in
ecryptfs_new_lower_dentry(), misuse of vfs_path_lookup() in
ecryptfs_lookup_one_lower() and a dislike of passing nameidata to the
lower filesystem.

Reported-by: Al Viro 
Signed-off-by: Tyler Hicks

ecryptfs: remove unnecessary decrypt when extending a file

2011-01-17T19:01:25+00:00

Removes an unecessary page decrypt from ecryptfs_begin_write when the
page is beyond the current file size. Previously, the call to
ecryptfs_decrypt_page would result in a read of 0 bytes, but still
attempt to decrypt an entire page. This patch detects that case and
merely zeros the page before marking it up-to-date.

Signed-off-by: Frank Swiderski 
Signed-off-by: Tyler Hicks

ecryptfs: Fix ecryptfs_printk() size_t warnings

2011-01-17T19:01:24+00:00

Commit cb55d21f6fa19d8c6c2680d90317ce88c1f57269 revealed a number of
missing 'z' length modifiers in calls to ecryptfs_printk() when
printing variables of type size_t. This patch fixes those compiler
warnings.

Signed-off-by: Tyler Hicks

fs/ecryptfs: Add printf format/argument verification and fix fallout

2011-01-17T19:01:23+00:00

Add __attribute__((format... to __ecryptfs_printk
Make formats and arguments match.
Add casts to (unsigned long long) for %llu.

Signed-off-by: Joe Perches 
[tyhicks: 80 columns cleanup and fixed typo]
Signed-off-by: Tyler Hicks

ecryptfs: fixed testing of file descriptor flags

2011-01-17T17:24:43+00:00

This patch replaces the check (lower_file->f_flags & O_RDONLY) with
((lower_file & O_ACCMODE) == O_RDONLY).

Signed-off-by: Roberto Sassu 
Signed-off-by: Tyler Hicks

ecryptfs: test lower_file pointer when lower_file_mutex is locked

2011-01-17T17:24:42+00:00

This patch prevents the lower_file pointer in the 'ecryptfs_inode_info'
structure to be checked when the mutex 'lower_file_mutex' is not locked.

Signed-off-by: Roberto Sassu 
Signed-off-by: Tyler Hicks

ecryptfs: missing initialization of the superblock 'magic' field

2011-01-17T17:23:01+00:00

This patch initializes the 'magic' field of ecryptfs filesystems to
ECRYPTFS_SUPER_MAGIC.

Signed-off-by: Roberto Sassu 
[tyhicks: merge with 66cb76666d69]
Signed-off-by: Tyler Hicks