linux-toradex.git/fs/ext4/namei.c, branch v3.8.13

ext4: remove duplicate call to ext4_bread() in ext4_init_new_dir()

2013-01-07T04:40:25+00:00

This fixes a buffer cache leak when creating a directory, introduced
in commit a774f9c20.

Signed-off-by: Guo Chao 
Signed-off-by: "Theodore Ts'o" 
Reviewed-by: Tao Ma

ext4: release buffer in failed path in dx_probe()

2013-01-07T04:38:47+00:00

If checksum fails, we should also release the buffer
read from previous iteration.

Signed-off-by: Guo Chao 
Signed-off-by: "Theodore Ts'o" 
Reviewed-by: Darrick J. Wong -
Cc: stable@vger.kernel.org
--
 fs/ext4/namei.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

ext4: avoid hang when mounting non-journal filesystems with orphan list

2012-12-27T06:42:50+00:00

When trying to mount a file system which does not contain a journal,
but which does have a orphan list containing an inode which needs to
be truncated, the mount call with hang forever in
ext4_orphan_cleanup() because ext4_orphan_del() will return
immediately without removing the inode from the orphan list, leading
to an uninterruptible loop in kernel code which will busy out one of
the CPU's on the system.

This can be trivially reproduced by trying to mount the file system
found in tests/f_orphan_extents_inode/image.gz from the e2fsprogs
source tree.  If a malicious user were to put this on a USB stick, and
mount it on a Linux desktop which has automatic mounts enabled, this
could be considered a potential denial of service attack.  (Not a big
deal in practice, but professional paranoids worry about such things,
and have even been known to allocate CVE numbers for such problems.)

Signed-off-by: "Theodore Ts'o" 
Reviewed-by: Zheng Liu 
Cc: stable@vger.kernel.org

ext4: Remove CONFIG_EXT4_FS_XATTR

2012-12-10T21:30:43+00:00

Ted has sent out a RFC about removing this feature. Eric and Jan
confirmed that both RedHat and SUSE enable this feature in all their
product.  David also said that "As far as I know, it's enabled in all
Android kernels that use ext4."  So it seems OK for us.

And what's more, as inline data depends its implementation on xattr,
and to be frank, I don't run any test again inline data enabled while
xattr disabled.  So I think we should add inline data and remove this
config option in the same release.

[ The savings if you disable CONFIG_EXT4_FS_XATTR is only 27k, which
  isn't much in the grand scheme of things.  Since no one seems to be
  testing this configuration except for some automated compile farms, on
  balance we are better removing this config option, and so that it is
  effectively always enabled. -- tytso ]

Cc: David Brown 
Cc: Eric Sandeen 
Reviewed-by: Jan Kara 
Signed-off-by: Tao Ma 
Signed-off-by: "Theodore Ts'o"

ext4: let ext4_rename handle inline dir

2012-12-10T19:06:01+00:00

In case we rename a directory, ext4_rename has to read the dir block
and change its dotdot's information.  The old ext4_rename encapsulated
the dir_block read into itself.  So this patch adds a new function
ext4_get_first_dir_block() which gets the dir buffer information so
the ext4_rename can handle it properly.  As it will also change the
parent inode number, we return the parent_de so that ext4_rename() can
handle it more easily.

ext4_find_entry is also changed so that the caller(rename) can tell
whether the found entry is an inlined one or not and journaling the
corresponding buffer head.

Signed-off-by: Tao Ma 
Signed-off-by: "Theodore Ts'o"

ext4: let empty_dir handle inline dir

2012-12-10T19:06:01+00:00

empty_dir is used when deleting a dir.  So it should handle inline dir
properly.

Signed-off-by: Tao Ma 
Signed-off-by: "Theodore Ts'o"

ext4: let ext4_delete_entry() handle inline data

2012-12-10T19:06:00+00:00

Signed-off-by: Tao Ma 
Signed-off-by: "Theodore Ts'o"

ext4: make ext4_delete_entry generic

2012-12-10T19:06:00+00:00

Currently ext4_delete_entry() is used only for dir entry removing from
a dir block.  So let us create a new function
ext4_generic_delete_entry and this function takes a entry_buf and a
buf_size so that it can be used for inline data.

Signed-off-by: Tao Ma 
Signed-off-by: "Theodore Ts'o"

ext4: let ext4_find_entry handle inline data

2012-12-10T19:06:00+00:00

Create a new function ext4_find_inline_entry() to handle the case of
inline data.

Signed-off-by: Tao Ma 
Signed-off-by: "Theodore Ts'o"

ext4: create a new function search_dir

2012-12-10T19:05:59+00:00

search_dirblock is used to search a dir block, but the code is almost
the same for searching an inline dir.

So create a new fuction search_dir and let search_dirblock call it.

Signed-off-by: Tao Ma 
Signed-off-by: "Theodore Ts'o"