linux-toradex.git/fs/ext4/xattr.c, branch v3.17-rc2

ext4: add missing BUFFER_TRACE before ext4_journal_get_write_access

2014-05-13T02:06:43+00:00

Make them more consistently

Signed-off-by: xieliang 
Signed-off-by: "Theodore Ts'o"

ext4: remove unnecessary double parentheses

2014-05-12T16:55:07+00:00

Signed-off-by: Lukas Czerner 
Signed-off-by: "Theodore Ts'o"

ext4: avoid unneeded lookup when xattr name is invalid

2014-05-12T13:57:59+00:00

In ext4_xattr_set_handle() we have checked the xattr name's length. So
we should also check it in ext4_xattr_get() to avoid unneeded lookup
caused by invalid name.

Signed-off-by: Zhang Zhen 
Signed-off-by: "Theodore Ts'o"

ext4: fix jbd2 warning under heavy xattr load

2014-04-07T14:54:21+00:00

When heavily exercising xattr code the assertion that
jbd2_journal_dirty_metadata() shouldn't return error was triggered:

WARNING: at /srv/autobuild-ceph/gitbuilder.git/build/fs/jbd2/transaction.c:1237
jbd2_journal_dirty_metadata+0x1ba/0x260()

CPU: 0 PID: 8877 Comm: ceph-osd Tainted: G    W 3.10.0-ceph-00049-g68d04c9 #1
Hardware name: Dell Inc. PowerEdge R410/01V648, BIOS 1.6.3 02/07/2011
 ffffffff81a1d3c8 ffff880214469928 ffffffff816311b0 ffff880214469968
 ffffffff8103fae0 ffff880214469958 ffff880170a9dc30 ffff8802240fbe80
 0000000000000000 ffff88020b366000 ffff8802256e7510 ffff880214469978
Call Trace:
 [] dump_stack+0x19/0x1b
 [] warn_slowpath_common+0x70/0xa0
 [] warn_slowpath_null+0x1a/0x20
 [] jbd2_journal_dirty_metadata+0x1ba/0x260
 [] __ext4_handle_dirty_metadata+0xa3/0x140
 [] ext4_xattr_release_block+0x103/0x1f0
 [] ext4_xattr_block_set+0x1e0/0x910
 [] ext4_xattr_set_handle+0x38b/0x4a0
 [] ? trace_hardirqs_on+0xd/0x10
 [] ext4_xattr_set+0xc2/0x140
 [] ext4_xattr_user_set+0x47/0x50
 [] generic_setxattr+0x6e/0x90
 [] __vfs_setxattr_noperm+0x7b/0x1c0
 [] vfs_setxattr+0xc4/0xd0
 [] setxattr+0x13e/0x1e0
 [] ? __sb_start_write+0xe7/0x1b0
 [] ? mnt_want_write_file+0x28/0x60
 [] ? fget_light+0x3c/0x130
 [] ? mnt_want_write_file+0x28/0x60
 [] ? __mnt_want_write+0x58/0x70
 [] SyS_fsetxattr+0xbe/0x100
 [] system_call_fastpath+0x16/0x1b

The reason for the warning is that buffer_head passed into
jbd2_journal_dirty_metadata() didn't have journal_head attached. This is
caused by the following race of two ext4_xattr_release_block() calls:

CPU1                                CPU2
ext4_xattr_release_block()          ext4_xattr_release_block()
lock_buffer(bh);
/* False */
if (BHDR(bh)->h_refcount == cpu_to_le32(1))
} else {
  le32_add_cpu(&BHDR(bh)->h_refcount, -1);
  unlock_buffer(bh);
                                    lock_buffer(bh);
                                    /* True */
                                    if (BHDR(bh)->h_refcount == cpu_to_le32(1))
                                      get_bh(bh);
                                      ext4_free_blocks()
                                        ...
                                        jbd2_journal_forget()
                                          jbd2_journal_unfile_buffer()
                                          -> JH is gone
  error = ext4_handle_dirty_xattr_block(handle, inode, bh);
  -> triggers the warning

We fix the problem by moving ext4_handle_dirty_xattr_block() under the
buffer lock. Sadly this cannot be done in nojournal mode as that
function can call sync_dirty_buffer() which would deadlock. Luckily in
nojournal mode the race is harmless (we only dirty already freed buffer)
and thus for nojournal mode we leave the dirtying outside of the buffer
lock.

Reported-by: Sage Weil 
Signed-off-by: Jan Kara 
Signed-off-by: "Theodore Ts'o" 
Cc: stable@vger.kernel.org

ext4: each filesystem creates and uses its own mb_cache

2014-03-18T23:24:49+00:00

This patch adds new interfaces to create and destory cache,
ext4_xattr_create_cache() and ext4_xattr_destroy_cache(), and remove
the cache creation and destory calls from ex4_init_xattr() and
ext4_exitxattr() in fs/ext4/xattr.c.

fs/ext4/super.c has been changed so that when a filesystem is mounted
a cache is allocated and attched to its ext4_sb_info structure.

fs/mbcache.c has been changed so that only one slab allocator is
allocated and used by all mbcache structures.

Signed-off-by: T. Makphaibulchoke

ext4: don't calculate total xattr header size unless needed

2014-02-20T01:15:21+00:00

The function ext4_expand_extra_isize_ea() doesn't need the size of all
of the extended attribute headers.  So if we don't calculate it when
it is unneeded, it we can skip some undeeded memory references, and as
a bonus, we eliminate some kvetching by static code analysis tools.

Addresses-Coverity-Id: #741291

Signed-off-by: "Theodore Ts'o"

ext2/3/4: use generic posix ACL infrastructure

2014-01-26T04:58:19+00:00

Signed-off-by: Christoph Hellwig 
Reviewed-by: Jan Kara 
Signed-off-by: Al Viro

ext4: avoid bh leak in retry path of ext4_expand_extra_isize_ea()

2013-11-01T03:00:24+00:00

Reported-by: Dave Jones 
Signed-off-by: "Theodore Ts'o" 
Cc: stable@vger.kernel.org

ext4: fix memory leak in xattr

2013-10-12T18:39:49+00:00

If we take the 2nd retry path in ext4_expand_extra_isize_ea, we
potentionally return from the function without having freed these
allocations.  If we don't do the return, we over-write the previous
allocation pointers, so we leak either way.

Spotted with Coverity.

[ Fixed by tytso to set is and bs to NULL after freeing these
  pointers, in case in the retry loop we later end up triggering an
  error causing a jump to cleanup, at which point we could have a double
  free bug. -- Ted ]

Signed-off-by: Dave Jones 
Signed-off-by: "Theodore Ts'o" 
Reviewed-by: Eric Sandeen 
Cc: stable@vger.kernel.org

ext4: fix miscellaneous big endian warnings

2013-04-10T03:59:55+00:00

None of these result in any bug, but they makes sparse complain.

Signed-off-by: "Theodore Ts'o"