linux-toradex.git/fs/ext4, branch v2.6.22.15

dir_index: error out instead of BUG on corrupt dx dirs

2007-09-26T17:54:41+00:00

commit 3d82abae9523c33d4a16fdfdfd2bdde316d7b56a in mainline.

Convert asserts (BUGs) in dx_probe from bad on-disk data to recoverable
errors with helpful warnings.  With help catching other asserts from Duane
Griffin 

Signed-off-by: Eric Sandeen 
Acked-by: Duane Griffin 
Acked-by: Theodore Ts'o 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds 
Signed-off-by: Greg Kroah-Hartman

ext34: ensure do_split leaves enough free space in both blocks

2007-09-26T17:54:40+00:00

commit ef2b02d3e617cb0400eedf2668f86215e1b0e6af in mainline.

The do_split() function for htree dir blocks is intended to split a leaf
block to make room for a new entry.  It sorts the entries in the original
block by hash value, then moves the last half of the entries to the new
block - without accounting for how much space this actually moves.  (IOW,
it moves half of the entry *count* not half of the entry *space*).  If by
chance we have both large & small entries, and we move only the smallest
entries, and we have a large new entry to insert, we may not have created
enough space for it.

The patch below stores each record size when calculating the dx_map, and
then walks the hash-sorted dx_map, calculating how many entries must be
moved to more evenly split the existing entries between the old block and
the new block, guaranteeing enough space for the new entry.

The dx_map "offs" member is reduced to u16 so that the overall map size
does not change - it is temporarily stored at the end of the new block, and
if it grows too large it may be overwritten.  By making offs and size both
u16, we won't grow the map size.

Also add a few comments to the functions involved.

This fixes the testcase reported by hooanon05@yahoo.co.jp on the
linux-ext4 list, "ext3 dir_index causes an error"

Thanks to Andreas Dilger for discussing the problem & solution with me.

Signed-off-by: Eric Sandeen 
Signed-off-by: Andreas Dilger 
Tested-by: Junjiro Okajima 
Cc: Theodore Ts'o 
Cc: ext4 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds 
Signed-off-by: Greg Kroah-Hartman

"ext4_ext_put_in_cache" uses __u32 to receive physical block number

2007-08-09T21:27:36+00:00

Yan Zheng wrote:

> I think I found a bug in ext4/extents.c, "ext4_ext_put_in_cache" uses
> "__u32" to receive physical block number.  "ext4_ext_put_in_cache" is
> used in "ext4_ext_get_blocks", it sets ext4 inode's extent cache
> according most recently tree lookup (higher 16 bits of saved physical
> block number are always zero). when serving a mapping request,
> "ext4_ext_get_blocks" first check whether the logical block is in
> inode's extent cache. if the logical block is in the cache and the
> cached region isn't a gap, "ext4_ext_get_blocks" gets physical block
> number by using cached region's physical block number and offset in
> the cached region.  as described above, "ext4_ext_get_blocks" may
> return wrong result when there are physical block numbers bigger than
> 0xffffffff.
>

You are right.  Thanks for reporting this!

Signed-off-by: Mingming Cao 
Cc: Yan Zheng 
Cc: 
Signed-off-by: Andrew Morton 
Signed-off-by: Greg Kroah-Hartman

ext4: lost brelse in ext4_read_inode()

2007-06-24T15:59:12+00:00

One of error path in ext4_read_inode() leaks bh since brelse is forgoten.

Signed-off-by: Kirill Korotaev 
Acked-by: Vasily Averin 
Cc: Theodore Ts'o 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

When ext4_ext_insert_extent() fails to insert new blocks

2007-05-31T20:20:15+00:00

we should free just the allocated blocks.

Signed-off-by: Alex Tomas 
Signed-off-by: Mingming Cao 
Signed-off-by: "Theodore Ts'o"

ext4: Extent overlap bugfix

2007-05-31T20:20:15+00:00

This patch adds a check for overlap of extents and cuts short the
new extent to be inserted, if there is a chance of overlap.

Signed-off-by: Amit Arora 
Signed-off-by: "Theodore Ts'o"

Remove unnecessary exported symbols.

2007-05-31T20:20:15+00:00

Signed-Off-By: Mingming Cao 
Signed-off-by: "Theodore Ts'o"

EXT4: Fix whitespace

2007-05-31T20:20:14+00:00

Replace a lot of spaces with tabs

Signed-off-by: Dave Kleikamp 
Signed-off-by: "Theodore Ts'o"

Remove SLAB_CTOR_CONSTRUCTOR

2007-05-17T12:23:04+00:00

SLAB_CTOR_CONSTRUCTOR is always specified. No point in checking it.

Signed-off-by: Christoph Lameter 
Cc: David Howells 
Cc: Jens Axboe 
Cc: Steven French 
Cc: Michael Halcrow 
Cc: OGAWA Hirofumi 
Cc: Miklos Szeredi 
Cc: Steven Whitehouse 
Cc: Roman Zippel 
Cc: David Woodhouse 
Cc: Dave Kleikamp 
Cc: Trond Myklebust 
Cc: "J. Bruce Fields" 
Cc: Anton Altaparmakov 
Cc: Mark Fasheh 
Cc: Paul Mackerras 
Cc: Christoph Hellwig 
Cc: Jan Kara 
Cc: David Chinner 
Cc: "David S. Miller" 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

header cleaning: don't include smp_lock.h when not used

2007-05-08T18:15:07+00:00

Remove includes of  where it is not used/needed.
Suggested by Al Viro.

Builds cleanly on x86_64, i386, alpha, ia64, powerpc, sparc,
sparc64, and arm (all 59 defconfigs).

Signed-off-by: Randy Dunlap 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds