linux-toradex.git/fs/ext4, branch v3.8.2

ext4: fix free clusters calculation in bigalloc filesystem

2013-03-03T22:03:37+00:00

commit 304e220f0879198b1f5309ad6f0be862b4009491 upstream.

ext4_has_free_clusters() should tell us whether there is enough free
clusters to allocate, however number of free clusters in the file system
is converted to blocks using EXT4_C2B() which is not only wrong use of
the macro (we should have used EXT4_NUM_B2C) but it's also completely
wrong concept since everything else is in cluster units.

Moreover when calculating number of root clusters we should be using
macro EXT4_NUM_B2C() instead of EXT4_B2C() otherwise the result might be
off by one. However r_blocks_count should always be a multiple of the
cluster ratio so doing a plain bit shift should be enough here. We
avoid using EXT4_B2C() because it's confusing.

As a result of the first problem number of free clusters is much bigger
than it should have been and ext4_has_free_clusters() would return 1 even
if there is really not enough free clusters available.

Fix this by removing the EXT4_C2B() conversion of free clusters and
using bit shift when calculating number of root clusters. This bug
affects number of xfstests tests covering file system ENOSPC situation
handling. With this patch most of the ENOSPC problems with bigalloc file
system disappear, especially the errors caused by delayed allocation not
having enough space when the actual allocation is finally requested.

Signed-off-by: Lukas Czerner 
Signed-off-by: "Theodore Ts'o" 
Signed-off-by: Greg Kroah-Hartman

ext4: fix xattr block allocation/release with bigalloc

2013-03-03T22:03:37+00:00

commit 1231b3a1eb5740192aeebf5344dd6d6da000febf upstream.

Currently when new xattr block is created or released we we would call
dquot_free_block() or dquot_alloc_block() respectively, among the else
decrementing or incrementing the number of blocks assigned to the
inode by one block.

This however does not work for bigalloc file system because we always
allocate/free the whole cluster so we have to count with that in
dquot_free_block() and dquot_alloc_block() as well.

Use the clusters-to-blocks conversion EXT4_C2B() when passing number of
blocks to the dquot_alloc/free functions to fix the problem.

The problem has been revealed by xfstests #117 (and possibly others).

Signed-off-by: Lukas Czerner 
Signed-off-by: "Theodore Ts'o" 
Reviewed-by: Eric Sandeen 
Signed-off-by: Greg Kroah-Hartman

ext4: fix race in ext4_mb_add_n_trim()

2013-03-03T22:03:37+00:00

commit f1167009711032b0d747ec89a632a626c901a1ad upstream.

In ext4_mb_add_n_trim(), lg_prealloc_lock should be taken when
changing the lg_prealloc_list.

Signed-off-by: Niu Yawei 
Signed-off-by: "Theodore Ts'o" 
Signed-off-by: Greg Kroah-Hartman

ext4: release sysfs kobject when failing to enable quotas on mount

2013-03-03T22:03:37+00:00

commit 72ba74508b2857e71d65fc93f0d6b684492fc740 upstream.

In addition, print the error returned from ext4_enable_quotas()

Signed-off-by: "Theodore Ts'o" 
Reviewed-by: Carlos Maiolino 
Signed-off-by: Greg Kroah-Hartman

ext4: check bh in ext4_read_block_bitmap()

2013-03-03T22:03:37+00:00

commit 15b49132fc972c63894592f218ea5a9a61b1a18f upstream.

Validate the bh pointer before using it, since
ext4_read_block_bitmap_nowait() might return NULL.

I've seen this in fsfuzz testing.

 EXT4-fs error (device loop0): ext4_read_block_bitmap_nowait:385: comm touch: Cannot get buffer for block bitmap - block_group = 0, block_bitmap = 3925999616
 BUG: unable to handle kernel NULL pointer dereference at           (null)
 IP: [] ext4_wait_block_bitmap+0x25/0xe0
 ...
 Call Trace:
  [] ext4_read_block_bitmap+0x35/0x60
  [] ext4_free_blocks+0x236/0xb80
  [] ? __getblk+0x36/0x70
  [] ? __find_get_block+0x8f/0x210
  [] ? kmem_cache_free+0x33/0x140
  [] ext4_xattr_release_block+0x1b5/0x1d0
  [] ext4_xattr_delete_inode+0xbe/0x100
  [] ext4_free_inode+0x7c/0x4d0
  [] ? ext4_mark_inode_dirty+0x88/0x230
  [] ext4_evict_inode+0x32c/0x490
  [] evict+0xa7/0x1c0
  [] iput_final+0xe3/0x170
  [] iput+0x3e/0x50
  [] ext4_add_nondir+0x4d/0x90
  [] ext4_create+0xeb/0x170
  [] vfs_create+0xac/0xd0
  [] lookup_open+0x185/0x1c0
  [] ? selinux_inode_permission+0xa9/0x170
  [] do_last+0x2d4/0x7a0
  [] path_openat+0xb3/0x480
  [] ? handle_mm_fault+0x251/0x3b0
  [] do_filp_open+0x49/0xa0
  [] ? __alloc_fd+0xdd/0x150
  [] do_sys_open+0x108/0x1f0
  [] sys_open+0x21/0x30
  [] system_call_fastpath+0x16/0x1b

Also fix comment for ext4_read_block_bitmap_nowait()

Signed-off-by: Eryu Guan 
Signed-off-by: "Theodore Ts'o" 
Signed-off-by: Greg Kroah-Hartman

ext4: return ENOMEM if sb_getblk() fails

2013-03-03T22:03:36+00:00

commit 860d21e2c585f7ee8a4ecc06f474fdc33c9474f4 upstream.

The only reason for sb_getblk() failing is if it can't allocate the
buffer_head.  So ENOMEM is more appropriate than EIO.  In addition,
make sure that the file system is marked as being inconsistent if
sb_getblk() fails.

Signed-off-by: "Theodore Ts'o" 
Signed-off-by: Greg Kroah-Hartman

ext4: fix possible use-after-free with AIO

2013-03-03T22:03:36+00:00

commit 091e26dfc156aeb3b73bc5c5f277e433ad39331c upstream.

Running AIO is pinning inode in memory using file reference. Once AIO
is completed using aio_complete(), file reference is put and inode can
be freed from memory. So we have to be sure that calling aio_complete()
is the last thing we do with the inode.

Reviewed-by: Carlos Maiolino 
Acked-by: Jeff Moyer 
Signed-off-by: Jan Kara 
Signed-off-by: "Theodore Ts'o" 
Signed-off-by: Greg Kroah-Hartman

ext4: remove duplicate call to ext4_bread() in ext4_init_new_dir()

2013-01-07T04:40:25+00:00

This fixes a buffer cache leak when creating a directory, introduced
in commit a774f9c20.

Signed-off-by: Guo Chao 
Signed-off-by: "Theodore Ts'o" 
Reviewed-by: Tao Ma

ext4: release buffer in failed path in dx_probe()

2013-01-07T04:38:47+00:00

If checksum fails, we should also release the buffer
read from previous iteration.

Signed-off-by: Guo Chao 
Signed-off-by: "Theodore Ts'o" 
Reviewed-by: Darrick J. Wong -
Cc: stable@vger.kernel.org
--
 fs/ext4/namei.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

ext4: fix configuration dependencies for ext4 ACLs and security labels

2013-01-07T04:38:44+00:00

Commit "ext4: Remove CONFIG_EXT4_FS_XATTR" removed the configuration
dependencies for ext4 xattrs from the ext4 ACLs and security labels
configuration options, but did not replace them with a dependency on
ext4 itself.  Add back the dependency on ext4 so the options only show
up if ext4 is enabled.

Signed-off-by: Valerie Aurora 
Signed-off-by: "Theodore Ts'o" 
Reviewed-by: Tao Ma