linux-toradex.git/fs/f2fs/gc.c, branch v5.1

f2fs: check PageWriteback flag for ordered case

2018-12-26T23:16:56+00:00

For all ordered cases in f2fs_wait_on_page_writeback(), we need to
check PageWriteback status, so let's clean up to relocate the check
into f2fs_wait_on_page_writeback().

Signed-off-by: Chao Yu 
Signed-off-by: Jaegeuk Kim

f2fs: use kvmalloc, if kmalloc is failed

2018-12-26T23:16:53+00:00

One report says memalloc failure during mount.

 (unwind_backtrace) from [] (show_stack+0x10/0x14)
 (show_stack) from [] (dump_stack+0x8c/0xa0)
 (dump_stack) from [] (warn_alloc+0xc4/0x160)
 (warn_alloc) from [] (__alloc_pages_nodemask+0x3f4/0x10d0)
 (__alloc_pages_nodemask) from [] (kmalloc_order_trace+0x2c/0x120)
 (kmalloc_order_trace) from [] (build_node_manager+0x35c/0x688)
 (build_node_manager) from [] (f2fs_fill_super+0xf0c/0x16cc)
 (f2fs_fill_super) from [] (mount_bdev+0x15c/0x188)
 (mount_bdev) from [] (f2fs_mount+0x18/0x20)
 (f2fs_mount) from [] (mount_fs+0x158/0x19c)
 (mount_fs) from [] (vfs_kern_mount+0x78/0x134)
 (vfs_kern_mount) from [] (do_mount+0x474/0xca4)
 (do_mount) from [] (SyS_mount+0x94/0xbc)
 (SyS_mount) from [] (ret_fast_syscall+0x0/0x48)

Reviewed-by: Chao Yu 
Signed-off-by: Jaegeuk Kim

f2fs: fix to reorder set_page_dirty and wait_on_page_writeback

2018-12-14T14:38:36+00:00

This patch reorders flow from

- update page
- set_page_dirty
- wait_on_page_writeback

to

- wait_on_page_writeback
- update page
- set_page_dirty

The reason is:
- set_page_dirty will increase reference of dirty page, the reference
should be cleared before wait_on_page_writeback to keep its consistency.
- some devices need stable page during page writebacking, so we
should not change page's data.

Signed-off-by: Chao Yu 
Signed-off-by: Jaegeuk Kim

f2fs: adjust trace print in f2fs_get_victim() to cover all paths

2018-11-27T00:38:49+00:00

Adjust the trace print in f2fs_get_victim() to cover GC done by
F2FS_IOC_GARBAGE_COLLECT_RANGE.

Signed-off-by: Sahitya Tummala 
Reviewed-by: Chao Yu 
Signed-off-by: Jaegeuk Kim

f2fs: fix to allow node segment for GC by ioctl path

2018-11-27T00:38:46+00:00

Allow node type segments also to be GC'd via f2fs ioctl
F2FS_IOC_GARBAGE_COLLECT_RANGE.

Signed-off-by: Sahitya Tummala 
Reviewed-by: Chao Yu 
Signed-off-by: Jaegeuk Kim

f2fs: support subsectional garbage collection

2018-11-26T23:53:55+00:00

Section is minimal garbage collection unit of f2fs, in zoned block
device, or ancient block mapping flash device, in order to improve
GC efficiency, we can align GC unit to lower device erase unit,
normally, it consists of multiple of segments.

Once background or foreground GC triggers, it brings a large number
of IOs, which will impact user IO, and also occupy cpu/memory resource
intensively.

So, to reduce impact of GC on large size section, this patch supports
subsectional GC, in one cycle of GC, it only migrate partial segment{s}
in victim section. Currently, by default, we use sbi->segs_per_sec as
migration granularity.

Signed-off-by: Chao Yu 
Signed-off-by: Jaegeuk Kim

f2fs: introduce __is_large_section() for cleanup

2018-11-26T23:53:55+00:00

Introduce a wrapper __is_large_section() to clean up codes.

Signed-off-by: Chao Yu 
Signed-off-by: Jaegeuk Kim

f2fs: fix count of seg_freed to make sec_freed correct

2018-11-26T23:53:55+00:00

When sbi->segs_per_sec > 1, and if some segno has 0 valid blocks before
gc starts, do_garbage_collect will skip counting seg_freed++, and this
will cause seg_freed < sbi->segs_per_sec and finally skip sec_freed++.

Signed-off-by: Yunlong Song 
Signed-off-by: Chao Yu 
Reviewed-by: Chao Yu 
Signed-off-by: Jaegeuk Kim

f2fs: avoid GC causing encrypted file corrupted

2018-11-26T23:53:54+00:00

The encrypted file may be corrupted by GC in following case:

Time 1: | segment 1 blkaddr = A |  GC -> | segment 2 blkaddr = B |
Encrypted block 1 is moved from blkaddr A of segment 1 to blkaddr B of
segment 2,

Time 2: | segment 1 blkaddr = B |  GC -> | segment 3 blkaddr = C |

Before page 1 is written back and if segment 2 become a victim, then
page 1 is moved from blkaddr B of segment 2 to blkaddr Cof segment 3,
during the GC process of Time 2, f2fs should wait for page 1 written back
before reading it, or move_data_block will read a garbage block from
blkaddr B since page is not written back to blkaddr B yet.

Commit 6aa58d8a ("f2fs: readahead encrypted block during GC") introduce
ra_data_block to read encrypted block, but it forgets to add
f2fs_wait_on_page_writeback to avoid racing between GC and flush.

Signed-off-by: Yunlong Song 
Reviewed-by: Chao Yu 
Signed-off-by: Jaegeuk Kim

f2fs: submit cached bio to avoid endless PageWriteback

2018-10-16T16:36:59+00:00

When migrating encrypted block from background GC thread, we only add
them into f2fs inner bio cache, but forget to submit the cached bio, it
may cause potential deadlock when we are waiting page writebacked, fix
it.

Signed-off-by: Chao Yu 
Signed-off-by: Jaegeuk Kim