linux-toradex.git/fs/f2fs/inode.c, branch v4.12

f2fs: fix out-of free segments

2017-04-24T20:13:23+00:00

This patch also reverts d0db7703ac1 ("f2fs: do SSR in higher priority").

This patch fixes out of free segments caused by many small file creation by
1) mkfs -s 1 2G
2) mount
3) untar
 - preoduce 60000 small files burstly
4) sync
 - flush node pages
 - flush imeta

Here, when we do f2fs_balance_fs, we missed # of imeta blocks, resulting in
skipping to check has_not_enough_free_secs.

Another test is done by
1) mkfs -s 12 2G
2) mount
3) untar
 - preoduce 60000 small files burstly
4) sync
 - flush node pages
 - flush imeta

In this case, this patch also fixes wrong block allocation under large section
size.

Reported-by: William Brana 
Cc: 
Signed-off-by: Jaegeuk Kim

f2fs: fix fs corruption due to zero inode page

2017-04-12T19:57:06+00:00

This patch fixes the following scenario.

- f2fs_create/f2fs_mkdir             - write_checkpoint
 - f2fs_mark_inode_dirty_sync         - block_operations
                                       - f2fs_lock_all
                                       - f2fs_sync_inode_meta
                                        - f2fs_unlock_all
                                        - sync_inode_metadata
 - f2fs_lock_op
                                         - f2fs_write_inode
                                          - update_inode_page
                                           - get_node_page
                                             return -ENOENT
 - new_inode_page
  - fill_node_footer
 - f2fs_mark_inode_dirty_sync
 - ...
 - f2fs_unlock_op
                                          - f2fs_inode_synced
                                       - f2fs_lock_all
                                       - do_checkpoint

In this checkpoint, we can get an inode page which contains zeros having valid
node footer only.

Cc: 
Signed-off-by: Jaegeuk Kim

f2fs: fix wrong error injection for evict_inode

2017-03-21T20:52:16+00:00

The previous one was not a proper location to inject an error, since there
is no point to get errors. Instead, we can emulate EIO during truncation,
and the below logic should handle it correctly.

Signed-off-by: Jaegeuk Kim

f2fs: don't need to invalidate wrong node page

2017-03-21T20:52:16+00:00

If f2fs_new_inode() is failed, the bad inode will invalidate 0'th node page
during f2fs_evict_inode(), which doesn't need to do.

Reviewed-by: Chao Yu 
Signed-off-by: Jaegeuk Kim

f2fs: show simple call stack in fault injection message

2017-02-27T17:59:55+00:00

Previously kernel message can show that in which function we do the
injection, but unfortunately, most of the caller are the same, for
tracking more information of injection path, it needs to show upper
caller's name. This patch supports that ability.

Signed-off-by: Chao Yu 
Signed-off-by: Jaegeuk Kim

f2fs: record inode updating status correctly

2016-11-23T20:11:25+00:00

We should record updating status of inode only for living inode, for those
unlinked inode it needs to clear its ino cache, otherwise after the ino
was been reused, it will cause unneeded node page writing during ->fsync.

Signed-off-by: Chao Yu 
Signed-off-by: Jaegeuk Kim

f2fs: make clean inodes when flushing inode page

2016-11-23T20:11:09+00:00

This patch tries to make more clean inodes when flushing dirty inodes in
checkpoint.

Signed-off-by: Jaegeuk Kim

f2fs: keep dirty inodes selectively for checkpoint

2016-11-23T20:11:08+00:00

This is to avoid no free segment bug during checkpoint caused by a number of
dirty inodes.

The case was reported by Chao like this.
1. mount with lazytime option
2. fill 4k file until disk is full
3. sync filesystem
4. read all files in the image
5. umount

In this case, we actually don't need to flush dirty inode to inode page during
checkpoint.

Reviewed-by: Chao Yu 
Signed-off-by: Jaegeuk Kim

f2fs: clear nlink if fail to add_link

2016-11-23T20:10:59+00:00

We don't need to keep incomplete created inode in cache, so if we fail to
add link into directory during new inode creation, it's better to set
nlink of inode to zero, then we can evict inode immediately. Otherwise
release of nid belong to inode will be delayed until inode cache is being
shrunk, it may cause a seemingly endless loop while allocating free nids
in time of testing generic/269 case of fstest suit.

Signed-off-by: Chao Yu 
[Jaegeuk Kim: add update_inode_page to fix kernel panic]
Signed-off-by: Jaegeuk Kim

f2fs: fix to update largest extent under lock

2016-11-23T20:10:55+00:00

In order to avoid racing problem, make largest extent cache being updated
under lock.

Signed-off-by: Chao Yu 
Signed-off-by: Jaegeuk Kim