linux-toradex.git/fs/f2fs/xattr.c, branch v3.16

f2fs: fix recursive lock by f2fs_setxattr

2014-06-02T13:13:16+00:00

This patch should resolve the following recursive lock.

[] call_rwsem_down_write_failed+0x13/0x20
[] f2fs_setxattr+0x5c/0xa0 [f2fs]
[] __f2fs_set_acl+0x1b9/0x340 [f2fs]
[] f2fs_init_acl+0x4a/0xcb [f2fs]
[] __f2fs_add_link+0x26e/0x780 [f2fs]
[] f2fs_mkdir+0xb8/0x150 [f2fs]
[] vfs_mkdir+0xb7/0x160
[] SyS_mkdir+0xab/0xe0
[] tracesys+0xe1/0xe6
[] 0xffffffffffffffff

The call path indicates:
- f2fs_add_link
   : down_write(&fi->i_sem);

 - init_inode_metadata
   - f2fs_init_acl
     - __f2fs_set_acl
       - f2fs_setxattr
         : down_write(&fi->i_sem);

Here we should not call f2fs_setxattr, but __f2fs_setxattr.
But __f2fs_setxattr is a static function in xattr.c, so that I found the other
generic approach to use f2fs_setxattr.

In f2fs_setxattr, the page pointer is only given from init_inode_metadata.
So, this patch adds this condition to avoid this in f2fs_setxattr.

Signed-off-by: Jaegeuk Kim

f2fs: split grab_cache_page and wait_on_page_writeback for node pages

2014-05-07T01:21:58+00:00

This patch splits grab_cache_page_write_begin into grab_cache_page and
wait_on_page_writeback for node pages.

This patch intends to enhance the latency to get node pages by alleviating
unnecessary wait_on_page_writeback.

Signed-off-by: Chao Yu 
Signed-off-by: Jaegeuk Kim

f2fs: return errors right after checking them

2014-05-07T01:21:56+00:00

This patch adds two error conditions early in the setxattr operations.

Signed-off-by: Jaegeuk Kim

f2fs: pass flags field to setxattr functions

2014-05-07T01:21:56+00:00

This patch passes the "flags" field to the low level setxattr functions
to use XATTR_REPLACE in the following patches.

Signed-off-by: Jaegeuk Kim

f2fs: clean up long variable names

2014-05-07T01:21:56+00:00

This patch includes simple clean-ups to reduce unnecessary long variable names.

Signed-off-by: Jaegeuk Kim

f2fs: avoid unneeded lookup when xattr name length is too long

2014-04-01T09:54:24+00:00

In f2fs_setxattr we have limit this attribute name length, so we should also
check it in f2fs_getxattr to avoid useless lookup caused by invalid name length.

Signed-off-by: Chao Yu 
Signed-off-by: Jaegeuk Kim

f2fs: avoid RECLAIM_FS-ON-W warning

2014-03-20T13:21:08+00:00

This patch should resolve the following possible bug.

RECLAIM_FS-ON-W at:
 mark_held_locks+0xb9/0x140
 lockdep_trace_alloc+0x85/0xf0
 __kmalloc+0x53/0x1d0
 read_all_xattrs+0x3d1/0x3f0 [f2fs]
 f2fs_getxattr+0x4f/0x100 [f2fs]
 f2fs_get_acl+0x4c/0x290 [f2fs]
 get_acl+0x4f/0x80
 posix_acl_create+0x72/0x180
 f2fs_init_acl+0x29/0xcc [f2fs]
 __f2fs_add_link+0x259/0x710 [f2fs]
 f2fs_create+0xad/0x1c0 [f2fs]
 vfs_create+0xed/0x150
 do_last+0xd36/0xed0
 path_openat+0xc5/0x680
 do_filp_open+0x43/0xa0
 do_sys_open+0x13c/0x230
 SyS_creat+0x1e/0x20
 system_call_fastpath+0x16/0x1b

Signed-off-by: Jaegeuk Kim

f2fs: introduce fi->i_sem to protect fi's info

2014-03-20T13:10:11+00:00

This patch introduces fi->i_sem to protect fi's info that includes xattr_ver,
pino, i_nlink.
This enables to remove i_mutex during f2fs_sync_file, resulting in performance
improvement when a number of fsync calls are triggered from many concurrent
threads.

Signed-off-by: Jaegeuk Kim

Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs

2014-01-28T16:38:04+00:00

Pull vfs updates from Al Viro:
 "Assorted stuff; the biggest pile here is Christoph's ACL series.  Plus
  assorted cleanups and fixes all over the place...

  There will be another pile later this week"

* 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs: (43 commits)
  __dentry_path() fixes
  vfs: Remove second variable named error in __dentry_path
  vfs: Is mounted should be testing mnt_ns for NULL or error.
  Fix race when checking i_size on direct i/o read
  hfsplus: remove can_set_xattr
  nfsd: use get_acl and ->set_acl
  fs: remove generic_acl
  nfs: use generic posix ACL infrastructure for v3 Posix ACLs
  gfs2: use generic posix ACL infrastructure
  jfs: use generic posix ACL infrastructure
  xfs: use generic posix ACL infrastructure
  reiserfs: use generic posix ACL infrastructure
  ocfs2: use generic posix ACL infrastructure
  jffs2: use generic posix ACL infrastructure
  hfsplus: use generic posix ACL infrastructure
  f2fs: use generic posix ACL infrastructure
  ext2/3/4: use generic posix ACL infrastructure
  btrfs: use generic posix ACL infrastructure
  fs: make posix_acl_create more useful
  fs: make posix_acl_chmod more useful
  ...

f2fs: use generic posix ACL infrastructure

2014-01-26T04:58:19+00:00

f2fs has some weird mode bit handling, so still using the old
chmod code for now.

Signed-off-by: Christoph Hellwig 
Reviewed-by: Jaegeuk Kim 
Signed-off-by: Al Viro