linux-toradex.git/fs/f2fs, branch v3.17.6

f2fs: reposition unlock_new_inode to prevent accessing invalid inode

2014-09-02T07:22:24+00:00

As the race condition on the inode cache, following scenario can appear:
[Thread a]				[Thread b]
					->f2fs_mkdir
					  ->f2fs_add_link
					    ->__f2fs_add_link
					      ->init_inode_metadata failed here
->gc_thread_func
  ->f2fs_gc
    ->do_garbage_collect
      ->gc_data_segment
        ->f2fs_iget
          ->iget_locked
            ->wait_on_inode
					  ->unlock_new_inode
        ->move_data_page
					  ->make_bad_inode
					  ->iput

When we fail in create/symlink/mkdir/mknod/tmpfile, the new allocated inode
should be set as bad to avoid being accessed by other thread. But in above
scenario, it allows f2fs to access the invalid inode before this inode was set
as bad.
This patch fix the potential problem, and this issue was found by code review.

change log from v1:
 o Add condition judgment in gc_data_segment() suggested by Changman Lee.
 o use iget_failed to simplify code.

Signed-off-by: Chao Yu 
Signed-off-by: Jaegeuk Kim

f2fs: fix wrong casting for dentry name

2014-08-29T07:26:50+00:00

The dentry name type is unsigned char *.
If we don't match this type, some character codes can be changed by signed bit.

Signed-off-by: Jaegeuk Kim

f2fs: simplify by using a literal

2014-08-28T16:25:29+00:00

We can make the code a bit simpler because we know that "!retry" is
zero.

Signed-off-by: Dan Carpenter 
Signed-off-by: Jaegeuk Kim

f2fs: truncate stale block for inline_data

2014-08-25T21:52:09+00:00

This verifies to truncate any allocated blocks, offset[0], by inline_data.
Not figured out, but for making sure.

Signed-off-by: Jaegeuk Kim

f2fs: use macro for code readability

2014-08-22T20:56:47+00:00

This patch introduces DEF_NIDS_PER_INODE/GET_ORPHAN_BLOCKS/F2FS_CP_PACKS macro
instead of numbers in code for readability.

change log from v1:
 o fix typo pointed out by Jaegeuk Kim.

Signed-off-by: Chao Yu 
Signed-off-by: Jaegeuk Kim

f2fs: introduce need_do_checkpoint for readability

2014-08-21T20:57:07+00:00

This patch introduce need_do_checkpoint() to include numerous judgment condition
for readability.

Signed-off-by: Chao Yu 
Signed-off-by: Jaegeuk Kim

f2fs: fix incorrect calculation with total/free inode num

2014-08-21T20:57:06+00:00

Theoretically, our total inodes number is the same as total node number, but
there are three node ids are reserved in f2fs, they are 0, 1 (node nid), and 2
(meta nid), and they should never be used by user, so our total/free inode
number calculated in ->statfs is wrong.

This patch indroduces F2FS_RESERVED_NODE_NUM and then fixes this issue by
recalculating total/free inode number with the macro.

Signed-off-by: Chao Yu 
Signed-off-by: Jaegeuk Kim

f2fs: remove rename and use rename2

2014-08-21T20:57:04+00:00

Refer the following patch.

commit 7177a9c4b509eb357cc450256bc3cf39f1a1e639
Author: Miklos Szeredi 
Date:   Wed Jul 23 15:15:30 2014 +0200

    fs: call rename2 if exists

Signed-off-by: Jaegeuk Kim

f2fs: skip if inline_data was converted already

2014-08-21T20:57:03+00:00

This patch checks inline_data one more time under the inode page lock whether
its inline_data is converted or not.

Signed-off-by: Jaegeuk Kim

f2fs: remove rewrite_node_page

2014-08-21T20:57:02+00:00

I think we need to let the dirty node pages remain in the page cache instead
of rewriting them in their places.
So, after done with successful recovery, write_checkpoint will flush all of them
through the normal write path.
Through this, we can avoid potential error cases in terms of block allocation.

Signed-off-by: Jaegeuk Kim