linux-toradex.git/fs/file.c, branch v2.6.19.2

[PATCH] expand_fdtable(): remove pointless unlock+lock

2006-09-29T16:18:25+00:00

This unlock/lock on a super-unlikely path isn't worth the kernel text.

Cc: Vadim Lobanov 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

[PATCH] Clean up expand_fdtable() and expand_files()

2006-09-29T16:18:25+00:00

Perform a code cleanup against the expand_fdtable() and expand_files()
functions inside fs/file.c.  It aims to make the flow of code within these
functions simpler and easier to understand, via added comments and modest
refactoring.

Signed-off-by: Vadim Lobanov 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

[PATCH] alloc_fdtable() cleanup

2006-09-27T15:26:19+00:00

free_fdset(NULL, ...) is legal.

Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

[PATCH] alloc_fdtable() expansion fix

2006-07-12T19:52:55+00:00

We're supposed to go the next power of two if nfds==nr.

Of `nr', not of `nfsd'.

Spotted by Rene Scharfe 

Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

[PATCH] fix fdset leakage

2006-07-12T19:52:54+00:00

When found, it is obvious.  nfds calculated when allocating fdsets is
rewritten by calculation of size of fdtable, and when we are unlucky, we
try to free fdsets of wrong size.

Found due to OpenVZ resource management (User Beancounters).

Signed-off-by: Alexey Kuznetsov 
Signed-off-by: Kirill Korotaev 
Cc: 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

[PATCH] fix weird logic in alloc_fdtable()

2006-07-10T20:24:25+00:00

There's a fairly obvious infinite loop in there.

Also, use roundup_pow_of_two() rather than open-coding stuff.

Cc: Eric Dumazet 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

[PATCH] for_each_possible_cpu: fixes for generic part

2006-03-28T17:16:05+00:00

replaces for_each_cpu with for_each_possible_cpu().

Signed-off-by: KAMEZAWA Hiroyuki 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

[PATCH] Shrinks sizeof(files_struct) and better layout

2006-03-23T15:38:09+00:00

1) Reduce the size of (struct fdtable) to exactly 64 bytes on 32bits
   platforms, lowering kmalloc() allocated space by 50%.

2) Reduce the size of (files_struct), using a special 32 bits (or
   64bits) embedded_fd_set, instead of a 1024 bits fd_set for the
   close_on_exec_init and open_fds_init fields.  This save some ram (248
   bytes per task) as most tasks dont open more than 32 files.  D-Cache
   footprint for such tasks is also reduced to the minimum.

3) Reduce size of allocated fdset.  Currently two full pages are
   allocated, that is 32768 bits on x86 for example, and way too much.  The
   minimum is now L1_CACHE_BYTES.

UP and SMP should benefit from this patch, because most tasks will touch
only one cache line when open()/close() stdin/stdout/stderr (0/1/2),
(next_fd, close_on_exec_init, open_fds_init, fd_array[0 ..  2] being in the
same cache line)

Signed-off-by: Eric Dumazet 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

[PATCH] percpu data: only iterate over possible CPUs

2006-02-05T19:06:51+00:00

percpu_data blindly allocates bootmem memory to store NR_CPUS instances of
cpudata, instead of allocating memory only for possible cpus.

As a preparation for changing that, we need to convert various 0 -> NR_CPUS
loops to use for_each_cpu().

(The above only applies to users of asm-generic/percpu.h.  powerpc has gone it
alone and is presently only allocating memory for present CPUs, so it's
currently corrupting memory).

Signed-off-by: Eric Dumazet 
Cc: "David S. Miller" 
Cc: James Bottomley 
Acked-by: Ingo Molnar 
Cc: Jens Axboe 
Cc: Anton Blanchard 
Acked-by: William Irwin 
Cc: Andi Kleen 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

[PATCH] Fix the fdtable freeing in the case of vmalloced fdset/arrays

2005-09-14T19:38:26+00:00

Noted by David Miller:

  "The bug is that free_fd_array() takes a "num" argument, but when
   calling it from __free_fdtable() we're instead passing in the size in
   bytes (ie.  "num * sizeof(struct file *)")."

Yes it is a bug. I think I messed it up while merging newer
changes with an older version where I was using size in bytes
to optimize.

Signed-off-by: Dipankar Sarma 
Signed-off-by: Linus Torvalds